Date: Fri, 31 May 2002 16:50:40 -0400 From: Bosko Milekic <bmilekic@unixdaemons.com> To: Archie Cobbs <archie@dellroad.org> Cc: Julian Elischer <julian@elischer.org>, freebsd-net@FreeBSD.ORG Subject: Re: m_split() considered harmful Message-ID: <20020531165040.A71744@unixdaemons.com> In-Reply-To: <200205312025.g4VKP9t02205@arch20m.dellroad.org>; from archie@dellroad.org on Fri, May 31, 2002 at 01:25:09PM -0700 References: <Pine.BSF.4.21.0205311243460.29361-100000@InterJet.elischer.org> <200205312025.g4VKP9t02205@arch20m.dellroad.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Fri, May 31, 2002 at 01:25:09PM -0700, Archie Cobbs wrote: [...] > As a temporary saftey measure, I'll add M_WRITABLE(m) into the > M_TRAILINGSPACE() macro. However, I see this as a temporary hack; > the correct fix is to put the burden of writability on the caller. > After all, M_TRAILINGSPACE() doesn't modify the mbuf data! > > That is, what we really need is a more general audit for code that > writes into mbufs that might be read-only -- and, as one special case > of tha, code that calls M_TRAILINGSPACE()/M_LEADINGSPACE() before writing > into an mbuf. Agreed. [...] > Updated patch below. > > -Archie [...] Patch looks good. -- Bosko Milekic bmilekic@unixdaemons.com bmilekic@FreeBSD.org To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-net" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20020531165040.A71744>