From owner-cvs-src@FreeBSD.ORG Tue Jul 22 03:45:29 2003 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 27D9337B401; Tue, 22 Jul 2003 03:45:29 -0700 (PDT) Received: from mx0.freebsd-services.com (survey.codeburst.net [195.149.39.161]) by mx1.FreeBSD.org (Postfix) with ESMTP id 5BAF743FB1; Tue, 22 Jul 2003 03:45:28 -0700 (PDT) (envelope-from paul@freebsd-services.com) Received: by mx0.freebsd-services.com (Postfix, from userid 1002) id 10C2E1B211; Tue, 22 Jul 2003 11:45:25 +0100 (BST) Date: Tue, 22 Jul 2003 11:45:24 +0100 From: Paul Richards To: Poul-Henning Kamp Message-ID: <20030722104524.GA80471@survey.codeburst.net> References: <200307220922.h6M9M0YQ062963@repoman.freebsd.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200307220922.h6M9M0YQ062963@repoman.freebsd.org> User-Agent: Mutt/1.5.4i cc: cvs-src@FreeBSD.org cc: src-committers@FreeBSD.org cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/dev/lnc if_lnc.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 22 Jul 2003 10:45:29 -0000 On Tue, Jul 22, 2003 at 02:22:00AM -0700, Poul-Henning Kamp wrote: > phk 2003/07/22 02:22:00 PDT > > FreeBSD src repository > > Modified files: > sys/dev/lnc if_lnc.c > Log: > Don't inline ridiculously very large functions. > > Compared to the contents of these functions, an extra function call > is nano-peanuts. Both of those functions were called from just one place, inside the interrupt handler. Is there any reason to not inline them? -- Tis a wise thing to know what is wanted, wiser still to know when it has been achieved and wisest of all to know when it is unachievable for then striving is folly. [Magician]