From owner-freebsd-geom@FreeBSD.ORG  Wed Aug 18 17:06:43 2010
Return-Path: <owner-freebsd-geom@FreeBSD.ORG>
Delivered-To: freebsd-geom@FreeBSD.ORG
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 8159C106566B;
	Wed, 18 Aug 2010 17:06:43 +0000 (UTC)
	(envelope-from olli@lurza.secnetix.de)
Received: from lurza.secnetix.de (lurza.secnetix.de [IPv6:2a01:170:102f::2])
	by mx1.freebsd.org (Postfix) with ESMTP id 012328FC18;
	Wed, 18 Aug 2010 17:06:42 +0000 (UTC)
Received: from lurza.secnetix.de (localhost [127.0.0.1])
	by lurza.secnetix.de (8.14.3/8.14.3) with ESMTP id o7IH6QtR042333;
	Wed, 18 Aug 2010 19:06:41 +0200 (CEST)
	(envelope-from oliver.fromme@secnetix.de)
Received: (from olli@localhost)
	by lurza.secnetix.de (8.14.3/8.14.3/Submit) id o7IH6Q3q042332;
	Wed, 18 Aug 2010 19:06:26 +0200 (CEST) (envelope-from olli)
Date: Wed, 18 Aug 2010 19:06:26 +0200 (CEST)
Message-Id: <201008181706.o7IH6Q3q042332@lurza.secnetix.de>
From: Oliver Fromme <olli@lurza.secnetix.de>
To: freebsd-geom@FreeBSD.ORG, bug-followup@FreeBSD.ORG, walter@pelissero.de
In-Reply-To: <201008181650.o7IGo3vu096176@freefall.freebsd.org>
X-Newsgroups: list.freebsd-geom
User-Agent: tin/1.8.3-20070201 ("Scotasay") (UNIX)
	(FreeBSD/6.4-PRERELEASE-20080904 (i386))
MIME-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 8bit
X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.3.4
	(lurza.secnetix.de [127.0.0.1]);
	Wed, 18 Aug 2010 19:06:41 +0200 (CEST)
Cc: 
Subject: Re: kern/149762: volume labels with rogue characters
X-BeenThere: freebsd-geom@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: GEOM-specific discussions and implementations
	<freebsd-geom.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-geom>,
	<mailto:freebsd-geom-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-geom>
List-Post: <mailto:freebsd-geom@freebsd.org>
List-Help: <mailto:freebsd-geom-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-geom>,
	<mailto:freebsd-geom-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 18 Aug 2010 17:06:43 -0000

Oliver Fromme wrote:
 >  I have reviewed the patch (the second one from the followup),
 >  and it looks good to me, except for a few minor style(9)
 >  issues, and one type problem:  By default, char is unsigned,
                                              ^^^^^^^^^^^^^^^^^^
 >  so the comparisons p <= ' ' and p > '~' probably don't do
 >  what you expect.

I'm sorry, I meant signed, of course.
You need to specify "unsigned char" if you want it to be unsigned.

Best regards
   Oliver

-- 
Oliver Fromme, secnetix GmbH & Co. KG, Marktplatz 29, 85567 Grafing b. M.
Handelsregister: Registergericht Muenchen, HRA 74606,  Geschäftsfuehrung:
secnetix Verwaltungsgesellsch. mbH, Handelsregister: Registergericht Mün-
chen, HRB 125758,  Geschäftsführer: Maik Bachmann, Olaf Erb, Ralf Gebhart

FreeBSD-Dienstleistungen, -Produkte und mehr:  http://www.secnetix.de/bsd

"C is quirky, flawed, and an enormous success."
        -- Dennis M. Ritchie.