Date: Fri, 20 Dec 2019 14:12:05 +0100 From: Piotr Kubaj <pkubaj@anongoth.pl> To: "Jason E. Hale" <jhale@freebsd.org> Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r520503 - head/sysutils/libcdio/files Message-ID: <20191220131205.GA43637@KGPE-D16> In-Reply-To: <201912201303.xBKD3Prl001374@repo.freebsd.org> References: <201912201303.xBKD3Prl001374@repo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--OXfL5xGRrasGEqWY Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Such old versions won't be used anyway, because USES=3Dcompiler:c11 will ma= ke GCC9 to be used. So this patch doesn't fix anything (although it probably also doesn't break= anything). On 19-12-20 13:03:25, Jason E. Hale wrote: > Author: jhale > Date: Fri Dec 20 13:03:25 2019 > New Revision: 520503 > URL: https://svnweb.freebsd.org/changeset/ports/520503 >=20 > Log: > sysutils/libcdio: Fix build with GCC versions older than 4.6.0 which do= not > allow "#pragma GCC diagnostic" to be used inside of functions > =20 > PR: 242693 > Reported by: canardo <canardo909@gmx.com> >=20 > Added: > head/sysutils/libcdio/files/patch-lib_iso9660_iso9660.c (contents, pr= ops changed) >=20 > Added: head/sysutils/libcdio/files/patch-lib_iso9660_iso9660.c > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D > --- /dev/null 00:00:00 1970 (empty, because file is newly added) > +++ head/sysutils/libcdio/files/patch-lib_iso9660_iso9660.c Fri Dec 20 13= :03:25 2019 (r520503) > @@ -0,0 +1,26 @@ > +Fix build on GCC older than 4.6.0 which does not allow #pragma GCC diagn= ostic > +inside of functions. > + > +PR: 242693 > + > +--- lib/iso9660/iso9660.c.orig 2019-04-13 15:15:15 UTC > ++++ lib/iso9660/iso9660.c > +@@ -373,12 +373,18 @@ iso9660_set_ltime_with_timezone(const struct tm *p= _tm, > +=20 > + if (!p_tm) return; > +=20 > ++#if defined(__GNUC__) && __GNUC__ >=3D 5 > ++#pragma GCC diagnostic push > + #pragma GCC diagnostic ignored "-Wformat-truncation" > ++#endif > + snprintf(_pvd_date, 17, > + "%4.4d%2.2d%2.2d" "%2.2d%2.2d%2.2d" "%2.2d", > + p_tm->tm_year + 1900, p_tm->tm_mon + 1, p_tm->tm_mday, > + p_tm->tm_hour, p_tm->tm_min, p_tm->tm_sec, > + 0 /* 1/100 secs */ ); > ++#if defined(__GNUC__) && __GNUC__ >=3D 5 > ++#pragma GCC diagnostic pop > ++#endif > +=20 > + /* Set time zone in 15-minute interval encoding. */ > + pvd_date->lt_gmtoff -=3D (time_zone / 15); --OXfL5xGRrasGEqWY Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEycyIeNkkgohzsoorelmbhSCDnJ0FAl38yKUACgkQelmbhSCD nJ0KXBAAtMeaLb6i+lJooQwvfbSSERloaWkt8SRAkdkmU9mHCYFe58FWKX3E567e 9cy/eQ0oW1RgO54e+zO7wnRnKbIcE7FBOLERANmiI2QK/DMhJ/WElv6o7AZXbiXE G8NrQxDTgOjUkBzDOtk7whH8kz+qTgvmzP35Zz4lWmsY2+LZ8/cR5mQg8BHmELcf 9hzpt581cf/2b42pqFZGuGPW0DxI4GcVn9XIEt7hW806JwlZoItvqFxLNhsmwKXS OAFqKPvjCBddAwHnU+SHnkQL1P6qQS6/RM94atNCO6Do8BAILw5JMjifUH42W4JQ N5BQQK4YetNq8FgnyxkHifgD6z/3OfGy8z5VZ9H+WphdqD8vvFDad0vDWCz1qKw2 UjGSbNZeg5zCFsFrohH1NnP1cKhpczWcKkbOMLONglYcefRivIcPm74w01QZjSWj tYvuG1rLs6pKjstQcLxXCxVS2K2Mie32sSTsFZYWT553l/IDiv4S2TzZplfdrmXS 9ZhVCEIWCeFAl608Jesq+oa1Dh0mYnjVS39yuJlqzoGzGawZuEIV4f5ImLclwU9K 1JrFlkMkVtRCFRYKyFU7JVf6mx/uKIsmOEAXSwy4fnvSlPdUVcr7+/zZt4bvzF4v GQwrT4hQ1pxZfS8vCB5ta6lcAZbkZtAZPSjt9O2jNk9CwFhO5m8= =CZBq -----END PGP SIGNATURE----- --OXfL5xGRrasGEqWY--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20191220131205.GA43637>