From owner-svn-src-head@FreeBSD.ORG Sun Oct 28 10:06:00 2012 Return-Path: Delivered-To: svn-src-head@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id E461247B; Sun, 28 Oct 2012 10:06:00 +0000 (UTC) (envelope-from uqs@FreeBSD.org) Received: from acme.spoerlein.net (acme.spoerlein.net [IPv6:2a01:4f8:131:23c2::1]) by mx1.freebsd.org (Postfix) with ESMTP id 6D7B08FC0C; Sun, 28 Oct 2012 10:06:00 +0000 (UTC) Received: from localhost (acme.spoerlein.net [IPv6:2a01:4f8:131:23c2::1]) by acme.spoerlein.net (8.14.5/8.14.5) with ESMTP id q9SA5txP065029 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO); Sun, 28 Oct 2012 11:05:55 +0100 (CET) (envelope-from uqs@FreeBSD.org) Date: Sun, 28 Oct 2012 11:05:55 +0100 From: Ulrich =?utf-8?B?U3DDtnJsZWlu?= To: Michael Tuexen Subject: Re: svn commit: r241916 - in head/sys: netinet netinet6 Message-ID: <20121028100555.GA28199@acme.spoerlein.net> Mail-Followup-To: Ulrich =?utf-8?B?U3DDtnJsZWlu?= , Michael Tuexen , Bruce Evans , Xin LI , src-committers@FreeBSD.org, svn-src-all@FreeBSD.org, svn-src-head@FreeBSD.org References: <201210222149.q9MLnvrt014543@svn.freebsd.org> <20121023142219.K1008@besplex.bde.org> <20121024052525.T4723@besplex.bde.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) Cc: svn-src-head@FreeBSD.org, svn-src-all@FreeBSD.org, src-committers@FreeBSD.org, Xin LI , Bruce Evans X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 28 Oct 2012 10:06:01 -0000 On Tue, 2012-10-23 at 20:43:33 +0200, Michael Tuexen wrote: > On Oct 23, 2012, at 8:28 PM, Bruce Evans wrote: > > > On Tue, 23 Oct 2012, Michael Tuexen wrote: > > > >> On Oct 23, 2012, at 6:23 AM, Bruce Evans wrote: > >> > >>> On Mon, 22 Oct 2012, Xin LI wrote: > >>> > >>>> Log: > >>>> Remove __P. > >>> > >>> This was a chance to remove style bugs in the prototypes. At least it > >>> didn't create so many new ones, unlike the original __P axing. It > >>> still enlarged about a hundred by changing from Gnu style continuation > >>> to Gnu style continuation indentation with an off-by-5 error. > >> > >> please note that the SCTP code in the FreeBSD sources is generated > >> via an export script from a codebase which runs on multiple platforms. > >> The script tries to follow FreeBSDs guidelines, but is far from being > >> perfect. > > > > The export script might not like manual editing of its output. > > > > Portability might require __P(()), and then removing it cleaning requires > > a complicated script. > Maybe I wasn't clear... > > * The removal of __P() needs also be done upstream. I'll handle this, not problem. > I don't think we need __P on any platform. > * My comment was regarding your list of formatting issues of the code. Changing > the formatting would require changing the export script. > If someone "just" changes the FreeBSD sources and these changes are not included > upstream, they are lost by the next commit of rrs@ or mine. > > My point was: Getting rid of __P is fine and we can handle that upstream (as > any other non whitespace/formatting changes needed), but changing the formatting > is NOT that easy. I'm sorry about that and just wanted to let you know that > there is a reason why the style 9 stuff is not followed exactly within the > SCTP code. > > I hope this makes the situation clearer. Maybe running it through uncrustify[1] as part of the export for FreeBSD could help here? hth Uli [1] http://uncrustify.sourceforge.net/ and textproc/uncrustify