From owner-freebsd-stable@FreeBSD.ORG Tue Mar 30 15:21:50 2010 Return-Path: Delivered-To: freebsd-stable@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 49C9C106564A for ; Tue, 30 Mar 2010 15:21:50 +0000 (UTC) (envelope-from bp@barryp.org) Received: from itasca.hexavalent.net (itasca.hexavalent.net [67.207.138.180]) by mx1.freebsd.org (Postfix) with ESMTP id 0C5F68FC15 for ; Tue, 30 Mar 2010 15:21:49 +0000 (UTC) Received: from barryp.org (host-145-114-107-208.midco.net [208.107.114.145]) by itasca.hexavalent.net (Postfix) with ESMTPS id 81A7523C2FD for ; Tue, 30 Mar 2010 10:21:48 -0500 (CDT) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=barryp.org; s=itasca; t=1269962508; bh=1afWAuV1T9tE740KphXe+8HiDdUGiGiX7r7ggSFGP7A=; h=Message-ID:Date:From:MIME-Version:To:CC:Subject:References: In-Reply-To:Content-Type:Content-Transfer-Encoding; b=KnXwt2h/OreD sIpDL5BRNPIWhHlgEAMAC+ESM0ACyVh1S51holgU6ogb38CMY4N3fM5lfAFGsx/Sis6 BelgoXoJzaRQGQNIThiC6EneIDkqhS4Z+dzj59SXEwQGTnv+KH7l7jBjsaN3b1B46KN Cw24dySODhRcq3aA1hcvkY7/M= Received: from macbook.home ([10.66.1.10]) by barryp.org with esmtpsa (TLSv1:CAMELLIA256-SHA:256) (Exim 4.67 (FreeBSD)) (envelope-from ) id 1NwdGD-0006jV-PZ; Tue, 30 Mar 2010 10:21:46 -0500 Message-ID: <4BB21709.1070101@barryp.org> Date: Tue, 30 Mar 2010 10:21:45 -0500 From: Barry Pederson User-Agent: Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.6; en-US; rv:1.9.1.8) Gecko/20100227 Lightning/1.0b1 Thunderbird/3.0.3 MIME-Version: 1.0 To: jhell References: <20100215090756.GA54764@icarus.home.lan> <20100215105000.101326yj01j0f64g@webmail.leidinger.net> <20100215122744.GA57382@icarus.home.lan> <20100215161105.14071eiflhc9le68@webmail.leidinger.net> <4B79BA9C.3020402@quip.cz> <4B7AD0A3.9080701@barryp.org> <4BB0BC7C.3000801@barryp.org> <4BB20AED.70802@dataix.net> In-Reply-To: <4BB20AED.70802@dataix.net> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: FreeBSD Stable Subject: Re: ZFS Tuning - arc_summary.pl X-BeenThere: freebsd-stable@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Production branch of FreeBSD source code List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 30 Mar 2010 15:21:50 -0000 On 3/30/10 9:30 AM, jhell wrote: > Ill mark this up on my todo. Thanks for the feedback& I should have > something committed back within the next couple days, possibly even tonight. > > I never recalculated for this difference as that area of the code was > just a formatting fix. > > But as Jeremy has pointed out, it would have to verify against > __FreeBSD_version but since I already pull in the sysctl MIB > kern.osreldate I should be able to compare to that and say 700000 or > higher make the above correction. > > As this is mainly ZFS v13 dependent now I don't feel to bad doing what I > have stated above. > > Thanks again, > > Regards, Shouldn't the "ARC Size Breakdown" be based on the current size (instead of the target size) no matter what? If the current size was *less* than arc_max, you'd also get an nonsensical breakdown - in that case with the "recently used" and "frequently used" adding up to *more* than the current size. It seems to me that the only thing that would be different between newer and older FreeBSD version would be whether arc_max would be described as a "Hard Limit" or not - which is maybe not that important to show. If that's all true, then the patch should work for both older and newer versions of FreeBSD. Barry