From nobody Fri Dec 29 11:39:06 2023 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4T1k182Vnmz55w2q; Fri, 29 Dec 2023 11:39:08 +0000 (UTC) (envelope-from dim@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [IPv6:2610:1c1:1:606c::24b:4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4T1k18200Pz3NGc; Fri, 29 Dec 2023 11:39:08 +0000 (UTC) (envelope-from dim@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1703849948; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=P2uQw9eEOLN7R2wtRnwjvvJxmu68IFLfO2G6p/zRDBo=; b=kyph0hzI7O6lieXRmQ7sEPMo78A6cQkxtSloBqRdysB2F0xdXI8dFr6/hY80Q7R3xGaGyF lrrTPZgEGvZErFtS4tvNJHEniuYkLX2/Z3Aj/uQkRCCgwfWIsR5/uizkp8LRDdZwiEwHPi /YXfrMvXp1KF9RVv3Jnp2DDgQ3+tM1f9lJXTKWBf7PF9NtsWBTnMYCbo5d/uufhIXc9OGv QtGPrHd4D4G/z6ISuIzfHswfvNsX8Cus6x3mfSQe17yi9TycvxGcIeaRHq7n5QVRyB0pIs t+aW0F2Z1O7Xd/Ocru/dhWgibh4NOa9IKTrR4nKE+XdfY+f9tNVZBm8YmOblRg== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1703849948; a=rsa-sha256; cv=none; b=b+khgTO4Hspym/KmrS+o6P/q0g+6P4gZYFE9XiGYONMA8br5UBIEdyt4JrhiobN6uXJBqH A5r1pzuCDJqd0etPuxvVwqGs7Wjvi86EAzvb+6giKFVTZ8rwCDs5VAnJCZUyxE/4+1f3vF rfUe9tbXbie+pByprRTLIxmYoIOMPqGC4Noirwf8ZUzLVywZpOdbdBlbBxckbfvUxZMmHo iz0G6p9FP1rC1dLKsAPINXoXzlX9juN0m861sm4DTcJ4gDv23dCcxzj8kvdAwrLL0e0VZ4 W+j6XLuQzMB5xN18Q7nkOqyeDz4oSXBjh0I2/OIPEhcy9Eut/MB60oq4BxNZGw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1703849948; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=P2uQw9eEOLN7R2wtRnwjvvJxmu68IFLfO2G6p/zRDBo=; b=cbOQf/+S/y0PkB4dkXim2TSWXqa+1zlCC7KtOMf4t4fRbfXYlREd+Csb7vSOW3v1PQC0vy Y4MkVTO8HphZgUYUvbp3n4BmBaXztUjS/a6Owm+x9NPZHMtqsDbrWhkm1OfIFcIRZNfY1M QLk8A6QO85JRkm530L9fkP1B3Qjpr3XBvH4ra94nhNeLQL+2iO/LIIQ+enX9yZwzBJQplE hH/uaNz8FBUPyBy1hMQTl+jdaxlV9z5PjRN25TiM6tduovdRQKElUtg0xHfCvYyO2hvjvL D05pz1kNJx3XTez2Wp8WkJrgGMQHp4AbmiUKFJlWHKKVe1q39sBY0Yg6wX4yug== Received: from tensor.andric.com (tensor.andric.com [87.251.56.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "tensor.andric.com", Issuer "R3" (verified OK)) (Authenticated sender: dim) by smtp.freebsd.org (Postfix) with ESMTPSA id 4T1k180GK7zxXv; Fri, 29 Dec 2023 11:39:08 +0000 (UTC) (envelope-from dim@FreeBSD.org) Received: from smtpclient.apple (longrow.home.andric.com [192.168.0.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by tensor.andric.com (Postfix) with ESMTPSA id E3E3442C04; Fri, 29 Dec 2023 12:39:06 +0100 (CET) Content-Type: text/plain; charset=utf-8 List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-all@freebsd.org X-BeenThere: dev-commits-src-all@freebsd.org Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3731.700.6\)) Subject: Re: git: a8b70cf26030 - main - netpfil: Use accessor functions and named constants for all tcphdr flags From: Dimitry Andric In-Reply-To: <24134FF7-8C03-490D-A476-4EFF4EAD8132@FreeBSD.org> Date: Fri, 29 Dec 2023 12:39:06 +0100 Cc: Gleb Smirnoff , Richard Scheffenegger , src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Content-Transfer-Encoding: quoted-printable Message-Id: <0452FE2C-00E9-4E06-880B-6F7B56751728@FreeBSD.org> References: <202312270143.3BR1hMQf085312@gitrepo.freebsd.org> <24134FF7-8C03-490D-A476-4EFF4EAD8132@FreeBSD.org> To: Antoine Brodin X-Mailer: Apple Mail (2.3731.700.6) On 29 Dec 2023, at 11:17, Dimitry Andric wrote: >=20 > On 29 Dec 2023, at 08:35, Antoine Brodin wrote: >>=20 >> On Thu, Dec 28, 2023 at 10:37=E2=80=AFPM Gleb Smirnoff = wrote: >>>=20 >>> Antoine, >>>=20 >>> On Thu, Dec 28, 2023 at 08:48:36PM +0000, Antoine Brodin wrote: >>> A> > netpfil: Use accessor functions and named constants for all = tcphdr flags >>> A> > >>> ... >>> A> This breaks some ports: >>> A> /usr/include/netinet/tcp.h:82:8: error: unknown type name = 'inline' >>>=20 >>> Definitely some ports that use some strange compilers :) >>>=20 >>> Can you please give at least port names? >>=20 >> Some examples: >>=20 >> = https://pkg-status.freebsd.org/gohan04/data/mainamd64PR275986-default-foo/= 2023-12-28_20h35m41s/logs/errors/nspr-4.35.log >> = https://pkg-status.freebsd.org/gohan04/data/mainamd64PR275986-default-foo/= 2023-12-28_20h35m41s/logs/errors/opusfile-0.12_1.log >=20 > The culprit is likely the "-ansi" option. Just get rid of that, it is = not really useful: >=20 > cc -o prmapopt.o -c -fvisibility=3Dhidden -O2 -pipe = -fstack-protector-strong -fno-strict-aliasing -ansi -Wall -fPIC -UDEBUG = -DPACKAGE_NAME=3D\"\" -DPACKAGE_TARNAME=3D\"\" -DPACKAGE_VERSION=3D\"\" = -DPACKAGE_STRING=3D\"\" -DPACKAGE_BUGREPORT=3D\"\" -DPACKAGE_URL=3D\"\" = -DNDEBUG=3D1 -DHAVE_VISIBILITY_HIDDEN_ATTRIBUTE=3D1 = -DHAVE_VISIBILITY_PRAGMA=3D1 -DXP_UNIX=3D1 -DFREEBSD=3D1 = -DHAVE_BSD_FLOCK=3D1 -DHAVE_SOCKLEN_T=3D1 -DHAVE_POINTER_LOCALTIME_R=3D1 = -DHAVE_DLADDR=3D1 -DHAVE_LCHOWN=3D1 -DHAVE_SETPRIORITY=3D1 = -DHAVE_STRERROR=3D1 -DHAVE_SYSCALL=3D1 -DHAVE_SECURE_GETENV=3D1 = -D_REENTRANT=3D1 -D_THREAD_SAFE=3D1 -DFORCE_PR_LOG -D_PR_PTHREADS = -UHAVE_CVAR_BUILT_ON_SEM -D_NSPR_BUILD_ -I../../../dist/include/nspr = -I../../../pr/include -I../../../pr/include/private prmapopt.c > In file included from prmapopt.c:46: > In file included from prmapopt.c:46: > /usr/include/netinet/tcp.h:82:8: error: unknown type name 'inline' > 82 | static inline uint16_t > | ^ Hm, I may have spoken too soon here. If this port has always compiled = successfully with -ansi, then indeed it may not be that handy to = directly use the 'inline' keyword in system headers. I think most other = system headers use '__inline', which is supported by both gcc and clang, = even in ANSI mode. And if the compiler somehow does not support = __inline, sys/cdefs.h can make sure all those keywords get removed. -Dimitry