From owner-freebsd-bugs@freebsd.org Tue Nov 10 12:59:58 2015 Return-Path: Delivered-To: freebsd-bugs@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 5F362A2BAE6 for ; Tue, 10 Nov 2015 12:59:58 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2001:1900:2254:206a::16:76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 31AC81924 for ; Tue, 10 Nov 2015 12:59:58 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from bugs.freebsd.org ([127.0.1.118]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id tAACxwmt060896 for ; Tue, 10 Nov 2015 12:59:58 GMT (envelope-from bugzilla-noreply@freebsd.org) From: bugzilla-noreply@freebsd.org To: freebsd-bugs@FreeBSD.org Subject: [Bug 83995] CFLAGS & COPTFLAGS ambiguous behaviour Date: Tue, 10 Nov 2015 12:59:57 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: 6.0-BETA1 X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: ngie@FreeBSD.org X-Bugzilla-Status: In Progress X-Bugzilla-Priority: Normal X-Bugzilla-Assigned-To: freebsd-bugs@FreeBSD.org X-Bugzilla-Target-Milestone: --- X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: see_also cc Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 10 Nov 2015 12:59:58 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=83995 NGie Cooper changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.freebsd.org/bu | |gzilla/show_bug.cgi?id=1901 | |03, | |https://bugs.freebsd.org/bu | |gzilla/show_bug.cgi?id=1937 | |68 CC| |bdrewery@FreeBSD.org, | |imp@FreeBSD.org, | |ngie@FreeBSD.org --- Comment #1 from NGie Cooper --- Agreed. This logic is broken/confusing: 38 .if defined(DEBUG) 39 _MINUS_O= -O 40 CTFFLAGS+= -g 41 .else 42 .if ${MACHINE_CPUARCH} == "powerpc" 43 _MINUS_O= -O # gcc miscompiles some code at -O2 44 .else 45 _MINUS_O= -O2 46 .endif 47 .endif 48 .if ${MACHINE_CPUARCH} == "amd64" 49 .if ${COMPILER_TYPE} == "clang" 50 COPTFLAGS?=-O2 -pipe 51 .else 52 COPTFLAGS?=-O2 -frename-registers -pipe 53 .endif 54 .else 55 COPTFLAGS?=${_MINUS_O} -pipe 56 .endif 57 .if !empty(COPTFLAGS:M-O[23s]) && empty(COPTFLAGS:M-fno-strict-aliasing) 58 COPTFLAGS+= -fno-strict-aliasing 59 .endif 60 .if !defined(NO_CPU_COPTFLAGS) 61 COPTFLAGS+= ${_CPUCFLAGS} 62 .endif In particular, clang's version of COPTFLAGS always override the ${_MINUS_O}, -O on clang is synonymous with -O2, etc. brewery was complaining about this as well the other day/week. -- You are receiving this mail because: You are the assignee for the bug.