From owner-svn-ports-all@FreeBSD.ORG Wed Sep 25 16:36:33 2013 Return-Path: Delivered-To: svn-ports-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTP id C92794CC for ; Wed, 25 Sep 2013 16:36:33 +0000 (UTC) (envelope-from bsd-src@helfman.org) Received: from mail-pb0-f52.google.com (mail-pb0-f52.google.com [209.85.160.52]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 9F084221F for ; Wed, 25 Sep 2013 16:36:33 +0000 (UTC) Received: by mail-pb0-f52.google.com with SMTP id wz12so6209284pbc.39 for ; Wed, 25 Sep 2013 09:36:27 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:sender:in-reply-to:references:date :message-id:subject:from:to:cc:content-type; bh=ilVxZohN3t7q1eBp8AheEg4Y8K3EDMKSuFuX7JtuiFk=; b=e+iWSAiDBkPwNOyAggHuTpenwemZWG/P9sGELdttBSh6kgnpZ0Qck2rVNutXbES00K ZLgM6VKveb0K4ROkvxXpGYWCOe1+guoquTOtEgQsFdRdJSMX9HhIiUnyUI/q13jRdbzN BoC8xaVqRnf97J01DlAE7Ha+32Kq22FrrDGOnFWPXfBBx2zLockRLlD6yETniLPU4me5 ecYCaYA+GSoBmVrkGLWm1p613Gt80uBVIvvx4ltqaDv7uwv3ovDtXYDKdqEXwdcf67gV DUZ6HFrNhvnIk7XnLreDlAhexLMYA42qSEtE7tBOsYtz4D4ac1I7p+62aALFJ5/3yFWA 0adg== X-Gm-Message-State: ALoCoQlMMCSVqdhoFbbF2ea7kyOsXINacTtNDrjQjNtvsIcnq/CnxTL9j3Sekm7oPw5KwnCEdqbi MIME-Version: 1.0 X-Received: by 10.66.7.102 with SMTP id i6mr34358paa.149.1380126987593; Wed, 25 Sep 2013 09:36:27 -0700 (PDT) Sender: bsd-src@helfman.org Received: by 10.70.100.165 with HTTP; Wed, 25 Sep 2013 09:36:27 -0700 (PDT) In-Reply-To: <201309251631.r8PGVQug087427@svn.freebsd.org> References: <201309251631.r8PGVQug087427@svn.freebsd.org> Date: Wed, 25 Sep 2013 09:36:27 -0700 X-Google-Sender-Auth: 0YLzkYwOZQKlug45muA8ADwQG0c Message-ID: Subject: Re: svn commit: r328299 - head/games/bubble-chains From: Jason Helfman To: Rusmir Dusko Content-Type: text/plain; charset=ISO-8859-1 X-Content-Filtered-By: Mailman/MimeDel 2.1.14 Cc: "svn-ports-head@freebsd.org" , "svn-ports-all@freebsd.org" , "ports-committers@freebsd.org" X-BeenThere: svn-ports-all@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: SVN commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 25 Sep 2013 16:36:33 -0000 You removed NO_STAGE, but are not supporting staging. This should be put back or fixed. -jgh On Wed, Sep 25, 2013 at 9:31 AM, Rusmir Dusko wrote: > Author: nemysis > Date: Wed Sep 25 16:31:26 2013 > New Revision: 328299 > URL: http://svnweb.freebsd.org/changeset/ports/328299 > > Log: > - Change Makefile header > - Change maintainer email to @FreeBSD.org > - Add USE_DOS2UNIX > - Change Desktop entry file > - Add DOCS Option > - Add post-configure, fix build with Clang > - Mute dir install > > Approved by: wg/pawel (mentors) > > Modified: > head/games/bubble-chains/Makefile > > Modified: head/games/bubble-chains/Makefile > > ============================================================================== > --- head/games/bubble-chains/Makefile Wed Sep 25 16:05:48 2013 > (r328298) > +++ head/games/bubble-chains/Makefile Wed Sep 25 16:31:26 2013 > (r328299) > @@ -1,4 +1,4 @@ > -# Created by: nemysis@gmx.ch > +# Created by: nemysis > # $FreeBSD$ > > PORTNAME= bubble-chains > @@ -9,7 +9,7 @@ MASTER_SITES= http://bubble-chains.sinte > DISTNAME= chains-${DISTVERSION} > EXTRACT_SUFX= -src.7z > > -MAINTAINER= nemysis@gmx.ch > +MAINTAINER= nemysis@FreeBSD.org > COMMENT= The aim is to remove all of the targets on each level > > LICENSE= GPLv2 > @@ -22,17 +22,17 @@ WRKSRC= ${WRKDIR}/chains-${PORTVERSION} > USE_SDL= sdl image mixer > USE_GL= glut glew glu > USE_XORG= xrandr > +USE_DOS2UNIX= *.pro *.cpp *.h *.ui *.ui *.rc *.htm *.dat *.css > USE_QT4= moc_build qmake_build rcc_build uic_build iconengines > imageformats \ > corelib svg xml opengl network > > - > PORTDOCS= README > > -DESKTOP_ENTRIES="Bubble Chains" "${COMMENT}" \ > - "${PREFIX}/share/pixmaps/${PORTNAME}.png" \ > +DESKTOP_ENTRIES="Bubble Chains" "${COMMENT}" "${PORTNAME}" \ > "${PORTNAME}" "Game;ArcadeGame;" false > > -NO_STAGE= yes > +OPTIONS_DEFINE= DOCS > + > .include > > P7ZIP_CMD= ${LOCALBASE}/bin/7z > @@ -50,6 +50,11 @@ do-configure: > @cd ${WRKSRC} && ${SETENV} ${CONFIGURE_ENV} \ > ${QMAKE} ${QMAKEFLAGS} PREFIX=${PREFIX} > > +post-configure: > + @${REINPLACE_CMD} -e 's|CFLAGS =|CFLAGS ?=|' \ > + -e 's|CXXFLAGS =|CXXFLAGS ?=|' \ > + ${WRKSRC}/Makefile > + > do-install: > ${INSTALL_PROGRAM} ${WRKSRC}/bin/chains ${PREFIX}/bin/${PORTNAME} > @(cd ${WRKSRC} && ${COPYTREE_SHARE} data ${DATADIR}) > @@ -60,7 +65,7 @@ do-install: > ${PREFIX}/share/pixmaps/${PORTNAME}.ico > > .if ${PORT_OPTIONS:MDOCS} > - ${MKDIR} ${DOCSDIR} > + @${MKDIR} ${DOCSDIR} > ${INSTALL_DATA} ${PORTDOCS:S|^|${WRKSRC}/|} ${DOCSDIR} > .endif > > > -- Jason Helfman | FreeBSD Committer jgh@FreeBSD.org | http://people.freebsd.org/~jgh | The Power to Serve