From owner-freebsd-amd64@freebsd.org Mon Mar 21 00:05:42 2016 Return-Path: Delivered-To: freebsd-amd64@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id BAF61AD7B55 for ; Mon, 21 Mar 2016 00:05:42 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2001:1900:2254:206a::16:76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id ABB8BF4 for ; Mon, 21 Mar 2016 00:05:42 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from bugs.freebsd.org ([127.0.1.118]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id u2L05gSh054870 for ; Mon, 21 Mar 2016 00:05:42 GMT (envelope-from bugzilla-noreply@freebsd.org) From: bugzilla-noreply@freebsd.org To: freebsd-amd64@FreeBSD.org Subject: [Bug 208168] Bad KASSERT in vmm.c vm_gpa_hold() Date: Mon, 21 Mar 2016 00:05:42 +0000 X-Bugzilla-Reason: CC X-Bugzilla-Type: new X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: 11.0-CURRENT X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: daverabbitz@ihug.co.nz X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: freebsd-bugs@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: bug_id short_desc product version rep_platform op_sys bug_status bug_severity priority component assigned_to reporter cc Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-Mailman-Approved-At: Mon, 21 Mar 2016 00:17:01 +0000 X-BeenThere: freebsd-amd64@freebsd.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: Porting FreeBSD to the AMD64 platform List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 21 Mar 2016 00:05:42 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D208168 Bug ID: 208168 Summary: Bad KASSERT in vmm.c vm_gpa_hold() Product: Base System Version: 11.0-CURRENT Hardware: amd64 OS: Any Status: New Severity: Affects Only Me Priority: --- Component: kern Assignee: freebsd-bugs@FreeBSD.org Reporter: daverabbitz@ihug.co.nz CC: freebsd-amd64@FreeBSD.org CC: freebsd-amd64@FreeBSD.org The KASSERT in this function is always true for positive values of vcpuid, = it looks like it is intended to check vcpuid is in the range -1 to VM_MAXCPU. Here is a patch to make it right: diff --git a/sys/amd64/vmm/vmm.c b/sys/amd64/vmm/vmm.c index cb04f3c..ebd6360 100644 --- a/sys/amd64/vmm/vmm.c +++ b/sys/amd64/vmm/vmm.c @@ -914,7 +914,7 @@ vm_gpa_hold(struct vm *vm, int vcpuid, vm_paddr_t gpa, size_t len, int reqprot, * guaranteed if at least one vcpu is in the VCPU_FROZEN state. */ int state; - KASSERT(vcpuid >=3D -1 || vcpuid < VM_MAXCPU, ("%s: invalid vcpuid = %d", + KASSERT(vcpuid >=3D -1 && vcpuid < VM_MAXCPU, ("%s: invalid vcpuid = %d", __func__, vcpuid)); for (i =3D 0; i < VM_MAXCPU; i++) { if (vcpuid !=3D -1 && vcpuid !=3D i) --=20 You are receiving this mail because: You are on the CC list for the bug.=