From owner-svn-src-all@freebsd.org Sat Aug 12 21:45:56 2017 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id D9B32DCA4AF; Sat, 12 Aug 2017 21:45:56 +0000 (UTC) (envelope-from yaneurabeya@gmail.com) Received: from mail-pg0-x231.google.com (mail-pg0-x231.google.com [IPv6:2607:f8b0:400e:c05::231]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id A215B72623; Sat, 12 Aug 2017 21:45:56 +0000 (UTC) (envelope-from yaneurabeya@gmail.com) Received: by mail-pg0-x231.google.com with SMTP id u185so27797869pgb.1; Sat, 12 Aug 2017 14:45:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:mime-version:from:in-reply-to:date:cc:message-id:references :to; bh=wHtsmVXHgznhA2o4GJz/Ajf4qyG7oqr+8UbML9lt+cQ=; b=YsLkoxRJPOSjvQBlc6DjWxTel/cTgiCYWY4GE0x/hhMlEPmp2XTlM8RdFxdcWwIoqh /aZw+M5/7x9c483htfYv+nKvHm2y52Te1apkYU3f4hB0qAWx0TI3eGF6CK4xuFzNcO6j DGAl3MzWGRZ7slJsbFrsv7TZNcb18grwU32InJTSYp15gRcftAjvDcwiu9ZQNA4GT9hq E3k4VTNjQ/U9VMgIG2dsdqWRocTTn8ktS3wYTeGecRU+r02tJH84seKopk30JDHLzlno aHz+lyxcARjcfbAwXSTYkfOuAf2QPlMBnQS/Y0WKRlFsJ2Y4/aZfscczf0a7eL0HVGDF aImg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:mime-version:from:in-reply-to:date:cc :message-id:references:to; bh=wHtsmVXHgznhA2o4GJz/Ajf4qyG7oqr+8UbML9lt+cQ=; b=aGDXuf7utKU85X5E95gABgj7HUGzmmjM/RB27AiutS6N1/aoMKcXdwCAh2tHLzKdbs YKxq85b6KA/uLk/W3M27XyFvjtGn9be2r26Xg8nftcWoqn1vddj3wsSo1aRbEb+e1NQ0 HOKFlp35p8yGgygyzfk9ArWwRQ6+2kBiRRFfosMp/wKA3Sff0dTiQGeX8i70OPQ2yiVk M82eSWGcUQnjp2gK5XCGcuCu98/a5yZWs+Q18UcROzzYRbVJOujCaj6tb4lwOvY7nl+d QtonvMVfpPtx+jv8U3Q9OAjkAwD+MZnDDQOWZDm5ZZSTafIx4mCU+LkLcLPDDb0SGXVj C7Rg== X-Gm-Message-State: AHYfb5h1qsMlEOE8qFfOtPKGMQbz0zNmihhcrzL4aNtpXIpPa6126Dod S/zf77CctXT5Ri00D7Q= X-Received: by 10.84.247.9 with SMTP id n9mr11207257pll.451.1502574355713; Sat, 12 Aug 2017 14:45:55 -0700 (PDT) Received: from pinklady.local (c-73-19-52-228.hsd1.wa.comcast.net. [73.19.52.228]) by smtp.gmail.com with ESMTPSA id c7sm7367590pfg.29.2017.08.12.14.45.54 (version=TLS1 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Sat, 12 Aug 2017 14:45:54 -0700 (PDT) Subject: Re: svn commit: r322418 - head/lib/msun/src Mime-Version: 1.0 (Mac OS X Mail 9.3 \(3124\)) Content-Type: multipart/signed; boundary="Apple-Mail=_D3F0B8CF-3165-4A57-B6AD-9A720E908915"; protocol="application/pgp-signature"; micalg=pgp-sha512 X-Pgp-Agent: GPGMail From: "Ngie Cooper (yaneurabeya)" In-Reply-To: Date: Sat, 12 Aug 2017 14:45:53 -0700 Cc: Ian Lepore , src-committers , svn-src-all@freebsd.org, svn-src-head@freebsd.org, Bruce Evans Message-Id: <5672BE7A-0640-4C8B-9B41-44AD83D7B59E@gmail.com> References: <201708112241.v7BMfP5X028262@repo.freebsd.org> <1502555191.47886.30.camel@freebsd.org> To: Ryan Libby X-Mailer: Apple Mail (2.3124) X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 12 Aug 2017 21:45:57 -0000 --Apple-Mail=_D3F0B8CF-3165-4A57-B6AD-9A720E908915 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=utf-8 > On Aug 12, 2017, at 10:55, Ryan Libby wrote: =E2=80=A6 > A few possible quick fixes: >=20 > - Change the {arm64,riscv,sparc64}/include/float.h LDBL_MAX_EXP > definitions from (+16384) to 16384. >=20 > - Change HALF_LDBL_MAX from > #define HALF_LDBL_MAX __CONCAT(__CONCAT(0x0.8p, LDBL_MAX_EXP), L) > to > #if LDBL_MAX_EXP !=3D 0x4000 > #error "Unsupported long double format" > #endif > #define HALF_LDBL_MAX 0x0.8p16384L >=20 > - Change the HALF_LDBL_MAX constant to a variable constructed with > LD80C(), I think with > LD80C(0x8000000000000000, 16383, 5.9486574767861588254e+4931L) > but this also requires #error for LDBL_MAX_EXP !=3D 0x4000, so not > really any better than the above. >=20 > I think I will back the patch out for now and go back to review. The issue is an inconsistency with how LDBL_MAX_EXP is defined in the MD = headers: $ grep -r LDBL_MAX_EXP sys/sparc64/ sys/sparc64/include/float.h:#define LDBL_MAX_EXP (+16384) $ grep -r LDBL_MAX_EXP sys/x86/ sys/x86/include/float.h:#define LDBL_MAX_EXP 16384 Cheers, -Ngie --Apple-Mail=_D3F0B8CF-3165-4A57-B6AD-9A720E908915 Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename=signature.asc Content-Type: application/pgp-signature; name=signature.asc Content-Description: Message signed with OpenPGP using GPGMail -----BEGIN PGP SIGNATURE----- Comment: GPGTools - https://gpgtools.org iQIcBAEBCgAGBQJZj3cRAAoJEPWDqSZpMIYVmIwQAMNw+sDbhRARTgI5+idAgLEn VJQASSEIYpWOJ8TkwoqRRY0oKGMS50thM9NCbHAEb2+6X0FyUbdkuVqj6oUw9qc7 8TjOEJIs2iLUTP2bnVtOdv6FpI3eiT0RljdVVXp9GdOm//JkHx9o7x5ym3VOD9d8 B2B44oJ9avveX217G8rrbTZD5KkyAZYMUDJOF8ir/eMVgpK+51QOgHtCxTVOyCnj GvrDJuyA6zTzJyx/CHigbLIp3BCLf97MigNZ2N/9w4f5MgYBy0ouOM2+VulcWVpM GAMM+NkLlAbucb2PgcsrT9YGblREcT7VSJJaqpn2nR7vAEQcEnadHXTvhVUtlK0b z2UsBz5TE3pOGFzJ0uUD1hMyeGUXf1F3ysSc8TWxfTnu5MF2eE+yOXdkdlJuN9ow 1i9/0XX93jeuJplMr4boS/dymcPJyU0VD9M86HltzNpqda5Wof5CDLgdkvsLNthV TPVN1ZL2DYvFsk8PwqcITlImTu6EzkzlueGHe4Mvcr3VWWkQccGh0yg8WQMKNw9E HZuNPw+turGtykjW0/BxgZ/r4vR+eyZ3CCYzXVO/JFRES830+Wn/CpYx/ylzPuF6 50gL/0HlnQ++3VGQv5X4y01EDIUyKW5fC4HZ/Cl6e/OSgFvg5fqktvD4lNUkj9vx CVMJGelbvypV6YiopWUa =5zwd -----END PGP SIGNATURE----- --Apple-Mail=_D3F0B8CF-3165-4A57-B6AD-9A720E908915--