From owner-freebsd-current@FreeBSD.ORG Wed Jan 28 21:15:31 2015 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 09FAACCF; Wed, 28 Jan 2015 21:15:31 +0000 (UTC) Received: from smtpout7.timeweb.ru (smtpout7.timeweb.ru [92.53.117.21]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id B006FFBF; Wed, 28 Jan 2015 21:15:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=amdmi3.ru; s=dkim; h=In-Reply-To:Content-Type:MIME-Version:References:Message-ID:Subject:Cc:To:From:Date; bh=g0fU6g7W+ldemdSCtp4FUf6Jq1ZppAxlBmpHgQn/2XE=; b=Gllw7WIp0zk7tp6DRXVvyKk0R2UDzm+WevLonhxO4ENRKmQxnQ5O0VmnrGnL/sXJyM/nW0PjnwfDUtCghC74LOTaZzQ9DLY6/aaO1YsKxV1W0Qe5ZQ/aK6ye33KLS2cHN+nCsQM78X5v773L8NOhRyn+pgDh5k9qUwrqOtHxGIA=; Received: from [213.148.20.85] (helo=hive.panopticon) by smtp.timeweb.ru with esmtpsa (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.76) (envelope-from ) id 1YGZxO-000247-UG; Thu, 29 Jan 2015 00:15:26 +0300 Received: from hades.panopticon (hades.panopticon [192.168.0.32]) by hive.panopticon (Postfix) with ESMTP id BA57F8E5; Thu, 29 Jan 2015 00:14:46 +0300 (MSK) Received: by hades.panopticon (Postfix, from userid 1000) id 237CF4AD8; Thu, 29 Jan 2015 00:15:04 +0300 (MSK) Date: Thu, 29 Jan 2015 00:15:04 +0300 From: Dmitry Marakasov To: freebsd-current@FreeBSD.org Subject: Re: OptionalObsoleteFiles.inc completeness improvement, try 2 Message-ID: <20150128211504.GB55246@hades.panopticon> References: <20150124002956.GI1101@hades.panopticon> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20150124002956.GI1101@hades.panopticon> User-Agent: Mutt/1.5.23 (2014-03-12) Cc: Warner Losh , Nathan Whitehorn , Garrett Cooper X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 28 Jan 2015 21:15:31 -0000 * Dmitry Marakasov (amdmi3@amdmi3.ru) wrote: The patch is complete, see https://reviews.freebsd.org/D1600. - With it, for all knobs from src.conf(5) there are no difference in file tree contents between `KNOB make installworld` and `make installworld && KNOB make delete-old delete-old-libs` - Note that some OLD_DIRS were removed - they were incorrect as most directories are installed unconditionally by mtree. Since empty directores are not really needed, the install process should be probably improved - Some knobs which delete massive number of files (WITHOUT_MAN, WITHOUT_INCLUDES) were implemented with FILES!=find ... OLD_FILES+=${FILES} (similar construct was already used in WITHOUT_TESTS) I though of more effective implementation for this, such as introducing OLD_DIRS_RECURSIVE to fill from OptionalObsoleteFiles, in which delete-old will just call `find ... -delete` - Unneeded conditions such as .if ${TARGET_ARCH} == "amd64" || ${TARGET_ARCH} == "powerpc64" OLD_FILES+=usr/lib32/... .else were not removed yet. Maybe with the next patch. -- Dmitry Marakasov . 55B5 0596 FF1E 8D84 5F56 9510 D35A 80DD F9D2 F77D amdmi3@amdmi3.ru ..: jabber: amdmi3@jabber.ru http://www.amdmi3.ru