From owner-freebsd-current@freebsd.org Wed Apr 11 17:24:40 2018 Return-Path: Delivered-To: freebsd-current@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 91C6AF811BF for ; Wed, 11 Apr 2018 17:24:40 +0000 (UTC) (envelope-from kmacybsd@gmail.com) Received: from mailman.ysv.freebsd.org (mailman.ysv.freebsd.org [IPv6:2001:1900:2254:206a::50:5]) by mx1.freebsd.org (Postfix) with ESMTP id 25F0F6BC84 for ; Wed, 11 Apr 2018 17:24:40 +0000 (UTC) (envelope-from kmacybsd@gmail.com) Received: by mailman.ysv.freebsd.org (Postfix) id D0F46F811BD; Wed, 11 Apr 2018 17:24:39 +0000 (UTC) Delivered-To: current@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id AEAE9F811BB for ; Wed, 11 Apr 2018 17:24:39 +0000 (UTC) (envelope-from kmacybsd@gmail.com) Received: from mail-oi0-x234.google.com (mail-oi0-x234.google.com [IPv6:2607:f8b0:4003:c06::234]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 443386BC82 for ; Wed, 11 Apr 2018 17:24:39 +0000 (UTC) (envelope-from kmacybsd@gmail.com) Received: by mail-oi0-x234.google.com with SMTP id u84-v6so2464574oie.10 for ; Wed, 11 Apr 2018 10:24:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to; bh=c8aH9qG/Olqs9OXn15BfOMsa68TjU8TmmWv1Ootm8OQ=; b=sG2fVsc+xDwvoxCTgRRa5fYMqFdYwZjZ+gVOTTnj6bN/elyZTKvB6XI0DxdEKtHgaL /SPYgHz1zHOpKJNAqRmn5D2dMkw+Jeyn4oE1U4HpaoSMzJqUxStIUlfpQ2dElOHOHrmb YR3I37ZVUkdKO8fmQs+BmxTcuYiDNt6qk4dwwHY3obt+E/dRd1dpqgPfjpjotZ1SNxTL 7o7G16+CmgON66sCSULUn6fKdyapJ8DRkV25t7LNNEDLI1LU9wHBIx82gNY26prB2Nn/ bh31vShcx9goB0b5grD2nPaZxd92KN8lFXM6frvkoVRwk8haysj6z2oRSJrr0ffRUNXw 32ew== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to; bh=c8aH9qG/Olqs9OXn15BfOMsa68TjU8TmmWv1Ootm8OQ=; b=g5FeDcQAMZ7LVV8EERfWG1+ZvZ3MuAJAludkHarSkvesQpKDrjSISG8EJ4I+krGOey VE8zTQQVW0pMcvArbjpGcwC1eYgWnbopV6RHqzrvMiMS9dLDH6aYztoJS9KFCXnjBk1M RjlDz/vm+KlUuw1IIb7U5Mo8nUgbaiqI33VZhQjytLJrMIWUD/mxjq+rWx77k5t4WIwT LPao0MtQXN8OEV8QdJgoD+cmcd6VZgFxcqRFvy5xfWpC7Fc0d+SPK9gwuZRjoSCakJ/z i5MC4XWiotH/RAld8Ou/eC9j9GVUVHf7nefCUIcE3KmL5mZcB0A6awLUo3c45RlsNUVp MRgQ== X-Gm-Message-State: ALQs6tD+9OksU3A48cMXGx5rKopkgPiekWXwebFNyjaNGueTeqw7VtrE k4MVtLptw9ck1z1rAwcdiTqRHB85b3qQINU88FnbOPmr X-Google-Smtp-Source: AIpwx4+1B3CCbXLTikcJMLZEy2nH/y/2ELQtqRC7dv2LVZjiHbzLhkDpftx8ilvCRdOhGSKVqAInkb/x7UaINqn6LY0= X-Received: by 2002:aca:121a:: with SMTP id 26-v6mr3763519ois.250.1523467478469; Wed, 11 Apr 2018 10:24:38 -0700 (PDT) MIME-Version: 1.0 Sender: kmacybsd@gmail.com Received: by 2002:a9d:4782:0:0:0:0:0 with HTTP; Wed, 11 Apr 2018 10:24:38 -0700 (PDT) In-Reply-To: <20180411113958.GE1134@albert.catwhisker.org> References: <20180411113958.GE1134@albert.catwhisker.org> From: "K. Macy" Date: Wed, 11 Apr 2018 10:24:38 -0700 X-Google-Sender-Auth: 0kaCMfpYv-VcyxHXXs-hhImA-e4 Message-ID: Subject: Re: panic: mtx_lock() of spin mutex (null) @ /usr/src/sys/net/iflib.c:3716 To: David Wolfskill , current@freebsd.org Content-Type: text/plain; charset="UTF-8" X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.25 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 11 Apr 2018 17:24:40 -0000 Sorry about that. It looks like my review must have been missing a line. @@ -4702,8 +4707,8 @@ iflib_register(if_ctx_t ctx) _iflib_assert(sctx); - CTX_LOCK_INIT(ctx, device_get_nameunit(ctx->ifc_dev)); - + CTX_LOCK_INIT(ctx); + STATE_LOCK_INIT(ctx, device_get_nameunit(ctx->ifc_dev)); ifp = ctx->ifc_ifp = if_gethandle(IFT_ETHER); if (ifp == NULL) { device_printf(dev, "can not allocate ifnet structure\n"); @@ -5430,8 +5435,8 @@ iflib_io_tqg_attach(struct grouptask *gt, void *uniq, int cpu, char *name) } void On Wed, Apr 11, 2018 at 4:39 AM, David Wolfskill wrote: > This was running: > > FreeBSD g1-215.catwhisker.org 12.0-CURRENT FreeBSD 12.0-CURRENT #156 r332399M/332400:1200061: Wed Apr 11 04:17:45 PDT 2018 root@g1-215.catwhisker.org:/common/S4/obj/usr/src/amd64.amd64/sys/CANARY amd64 > > during boot, after updating from: > > FreeBSD g1-215.catwhisker.org 12.0-CURRENT FreeBSD 12.0-CURRENT #155 r332354M/332357:1200061: Tue Apr 10 04:00:41 PDT 2018 root@g1-215.catwhisker.org:/common/S4/obj/usr/src/amd64.amd64/sys/CANARY amd64 > > (My build machine, which uses an re((4) NIC, did not encounter the issue.) > > It appears that r332389 is implicated. > > ... > Unread portion of the kernel message buffer: > > __curthread () at ./machine/pcpu.h:230 > 230 __asm("movq %%gs:%1,%0" : "=r" (td) > (kgdb) #0 __curthread () at ./machine/pcpu.h:230 > #1 doadump (textdump=3) at /usr/src/sys/kern/kern_shutdown.c:361 > #2 0xffffffff80433f4c in db_fncall_generic (addr=, > rv=, nargs=, args=) > at /usr/src/sys/ddb/db_command.c:609 > #3 db_fncall (dummy1=, dummy2=, > dummy3=, dummy4=) > at /usr/src/sys/ddb/db_command.c:657 > #4 0xffffffff80433a99 in db_command (last_cmdp=, > cmd_table=, dopager=) > at /usr/src/sys/ddb/db_command.c:481 > #5 0xffffffff80433814 in db_command_loop () > at /usr/src/sys/ddb/db_command.c:534 > #6 0xffffffff80436a3f in db_trap (type=, code=) > at /usr/src/sys/ddb/db_main.c:250 > #7 0xffffffff80b753e3 in kdb_trap (type=3, code=-61456, tf=) > at /usr/src/sys/kern/subr_kdb.c:697 > #8 0xffffffff80f7eaa8 in trap (frame=0xfffffe00004377a0) > at /usr/src/sys/amd64/amd64/trap.c:548 > #9 > #10 kdb_enter (why=0xffffffff811df9d4 "panic", msg=) > at /usr/src/sys/kern/subr_kdb.c:479 > #11 0xffffffff80b2feda in vpanic (fmt=, ap=0xfffffe0000437910) > at /usr/src/sys/kern/kern_shutdown.c:826 > #12 0xffffffff80b2fca0 in kassert_panic ( > fmt=0xffffffff811dadca "mtx_lock() of spin mutex %s @ %s:%d") > at /usr/src/sys/kern/kern_shutdown.c:723 > #13 0xffffffff80b0ec93 in __mtx_lock_flags (c=0xfffff80008c85d88, opts=0, > file=0xffffffff81113c90 "/usr/src/sys/net/iflib.c", line=) > at /usr/src/sys/kern/kern_mutex.c:246 > #14 0xffffffff80c466e1 in _task_fn_admin (context=0xfffff80008c85c00) > at /usr/src/sys/net/iflib.c:3716 > #15 0xffffffff80b73849 in gtaskqueue_run_locked (queue=0xfffff80008489500) > at /usr/src/sys/kern/subr_gtaskqueue.c:331 > #16 0xffffffff80b735c8 in gtaskqueue_thread_loop (arg=) > at /usr/src/sys/kern/subr_gtaskqueue.c:506 > #17 0xffffffff80af0064 in fork_exit ( > callout=0xffffffff80b73540 , > arg=0xfffffe0844223008, frame=0xfffffe0000437ac0) > at /usr/src/sys/kern/kern_fork.c:1039 > #18 > (kgdb) > > If the dump would be useful, I can put it up for access. > > Peace, > david > -- > David H. Wolfskill david@catwhisker.org > Well, what did you EXPECT from Trump? He has a history of breaking promises. > > See http://www.catwhisker.org/~david/publickey.gpg for my public key.