Date: Sun, 8 Oct 2000 18:46:03 -0700 (PDT) From: "Justin T. Gibbs" <gibbs@FreeBSD.org> To: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: cvs commit: src/sys/dev/aic7xxx aic7xxx.c aic7xxx.h aic7xxx.seq aic7xxx_freebsd.c aic7xxx_pci.c Message-ID: <200010090146.SAA98297@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
gibbs 2000/10/08 18:46:03 PDT
Modified files:
sys/dev/aic7xxx aic7xxx.c aic7xxx.h aic7xxx.seq
aic7xxx_freebsd.c aic7xxx_pci.c
Log:
Clean up error recovery code:
aic7xxx.c:
In target mode, reset the TQINPOS on every restart of the sequencer.
In the past we did this only during a bus reset, but there are other
reasons the sequencer might be reset.
In ahc_clear_critical_section(), disable pausing chip interrupts while
we step the sequencer out of a critical section. This avoids the
possibility of getting a pausing interrupt (unexpected bus free,
bus reset, etc.) that would prevent the sequencer from stepping.
Send the correct async notifications in the case of a BDR or bus reset.
In ahc_loadseq(), correct the calculation of our critical sections.
In some cases, the sections would be larger than needed.
aic7xxx.h:
Remove an unused SCB flag.
aic7xxx.seq:
MK_MESSAGE is cleared by the kernel, there is no need to waste
a sequencer instruction clearing it.
aic7xxx_freebsd.c:
Go through the host message loop instead of issuing a single
byte message directly in the ahc_timeout() case where we
are currently on the bus to the device. The effect is the same,
but this way we get a nice printf saying that an expected BDR
was delivered instead of an unexpected bus free.
If we are requeuing an SCB for an error recovery action, be sure
to set the DISCONNECTED flag in the in-core version of the SCB.
This ensures that, in the SCB-paging case, the sequencer will
still recognize the reselection as valid even if the version
of the SCB with this flag set was never previously paged out
to system memory. In the non-paging case, set the MK_MESSAGE
flag in SCB_CONTROL directly.
aic7xxx_pci.c:
Enable the Memeory Write and Invalidate bug workaround for
all aic7880 chips with revs < 1. This bug is rarely triggered
in FreeBSD as most transfers end on cache-aligned boundaries,
but a recheck of my references indicates that these chips
are affected.
Revision Changes Path
1.55 +57 -48 src/sys/dev/aic7xxx/aic7xxx.c
1.27 +1 -2 src/sys/dev/aic7xxx/aic7xxx.h
1.102 +1 -2 src/sys/dev/aic7xxx/aic7xxx.seq
1.9 +31 -10 src/sys/dev/aic7xxx/aic7xxx_freebsd.c
1.4 +2 -2 src/sys/dev/aic7xxx/aic7xxx_pci.c
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200010090146.SAA98297>