From nobody Sat Aug 8 00:38:22 2026 X-Original-To: dev-commits-src-branches@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4hH2Dv05Qlz6mYX7 for ; Sat, 08 Aug 2026 00:38:23 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "YR1" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4hH2Dt4fBBz3mGr for ; Sat, 08 Aug 2026 00:38:22 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1786149502; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=9eM/FcjEV1PG5/rj1JOwji6v+phU8a2he0nlPcNZyL8=; b=YPyB51qdLRtCGT2Q9nkfAq/am0SzsjBsSEXqELTQ38YoA963L3Y1YoUWZ4EkVrAwVB0PKr xR+iCIzmyLr2MLpYguJe4pRjTTWcXYzGdIhJqAVXm7KwVsJ6W21GSE+uAA+pIDiJLFK5bE f3lBMLlQ/Rbdoh8aybKnxozrd6Z+mqxSgya6FEjf/T422ylPixaUqLorL2N86EkRNrjAms Hm+bdnJ7BWci7uyg7lgJjldVWBwUQWjCgag+eJr+m3d8i92dBIabqV5KZyGgSxo4Lo8FFt dyRqo5KpMRaptp8em7Z/acym+gt59PZStU+BXpNx7/ny8aGvWLdjP/RBd+hy6Q== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1786149502; a=rsa-sha256; cv=none; b=CLxFgk2G6fEedNFrnAYmM2NmaIwBJbegh2zg89eoKPIyG2nI51W28vFoEsrrxAXnm9tGPk C3Cso4zFRfnQizjd1X5Pg5xLPN+iblTSPsVWgR3knDPnExBLX7Timaz418wJQ5V4q8PBxA rm7WrbmebtgmfbuXxvUNADaaOxL0Aiin/zP151P597tpST4+uXIphUQtiN4muFV6+9SgSx bZd2RKySK1ZiLYguaO+BXjXTKfCSFWppusChm9I+j+5sCFgvBTiQBloAQmB/iYhFMVjDvL mxp0K2f/0Prc4L3MMaQfCLjjWOUMLzQ2m4QtSocxvGX3DTX/9QaNWVNvoNH+vg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1786149502; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=9eM/FcjEV1PG5/rj1JOwji6v+phU8a2he0nlPcNZyL8=; b=sYj1ic9CpMpQOl3aqndV+3QRoF4x5U9Bi8yUaU4zFuhI3kZGrcx51ECnJrXSP8Ie9p5Mku QEHCSG64xXgYdSp3Qlaw78AXFCNMd2KMM+hhZl4i2HSA/rWlizjfcSMry8BwkyTNKD4DIr eWY5dH+zjNwoAz6KyqeBQWfQozK6ISZQyguREot4MOADzrxxYa79RebN/rnexW9kVD+KfA NnusVKudchCQ3uW5G639LppSkOR2+boAP5vq6rhPyAIZCvGYPiFIzOAT7EXiUNkyOwAGXC V+zYrIFiGBUoLXbSBIsJCEr611uvB07KY5mbEEsGG6PLgSEHhj0qM6XlS3ecmA== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4hH2Dt3GH6zmt for ; Sat, 08 Aug 2026 00:38:22 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 3f229 by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Sat, 08 Aug 2026 00:38:22 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: Kevin Bowling Subject: git: b6bff124973e - stable/15 - ixgbe: fix unaligned access in ixgbe_update_flash_X550() List-Id: Commits to the stable branches of the FreeBSD src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-branches List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-branches@freebsd.org Sender: owner-dev-commits-src-branches@FreeBSD.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: kbowling X-Git-Repository: src X-Git-Refname: refs/heads/stable/15 X-Git-Reftype: branch X-Git-Commit: b6bff124973e231237ed8c4df6144b7cb3a81d33 Auto-Submitted: auto-generated Date: Sat, 08 Aug 2026 00:38:22 +0000 Message-Id: <6a767a7e.3f229.5005d7ea@gitrepo.freebsd.org> The branch stable/15 has been updated by kbowling: URL: https://cgit.FreeBSD.org/src/commit/?id=b6bff124973e231237ed8c4df6144b7cb3a81d33 commit b6bff124973e231237ed8c4df6144b7cb3a81d33 Author: Kevin Bowling AuthorDate: 2026-07-28 11:09:39 +0000 Commit: Kevin Bowling CommitDate: 2026-08-08 00:35:52 +0000 ixgbe: fix unaligned access in ixgbe_update_flash_X550() ixgbe_host_interface_command() treats its buffer as a u32 array. The local union contained only byte-sized fields, giving it one-byte stack alignment and allowing unaligned accesses on strict-align systems. Add a u32 member to the union to provide the required alignment and pass that member to ixgbe_host_interface_command(). No functional change is expected on x86. Obtained from: Intel ix 3.4.39 (cherry picked from commit 8fa2a7503468abb5f863729c4e244d738239503d) --- sys/dev/ixgbe/ixgbe_type.h | 1 + sys/dev/ixgbe/ixgbe_x550.c | 3 +-- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/sys/dev/ixgbe/ixgbe_type.h b/sys/dev/ixgbe/ixgbe_type.h index 4e242b7189cb..80f8effca6d5 100644 --- a/sys/dev/ixgbe/ixgbe_type.h +++ b/sys/dev/ixgbe/ixgbe_type.h @@ -3273,6 +3273,7 @@ struct ixgbe_hic_hdr2_rsp { }; union ixgbe_hic_hdr2 { + u32 buf[1]; struct ixgbe_hic_hdr2_req req; struct ixgbe_hic_hdr2_rsp rsp; }; diff --git a/sys/dev/ixgbe/ixgbe_x550.c b/sys/dev/ixgbe/ixgbe_x550.c index 7f07190f832c..f6ce0d10b9e2 100644 --- a/sys/dev/ixgbe/ixgbe_x550.c +++ b/sys/dev/ixgbe/ixgbe_x550.c @@ -3557,8 +3557,7 @@ s32 ixgbe_update_flash_X550(struct ixgbe_hw *hw) buffer.req.buf_lenl = FW_SHADOW_RAM_DUMP_LEN; buffer.req.checksum = FW_DEFAULT_CHECKSUM; - status = ixgbe_host_interface_command(hw, (u32 *)&buffer, - sizeof(buffer), + status = ixgbe_host_interface_command(hw, buffer.buf, sizeof(buffer), IXGBE_HI_COMMAND_TIMEOUT, false); return status;