From owner-freebsd-current@freebsd.org Tue Jun 4 14:58:56 2019 Return-Path: Delivered-To: freebsd-current@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 7059D15B33E1 for ; Tue, 4 Jun 2019 14:58:56 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: from mail-qk1-x730.google.com (mail-qk1-x730.google.com [IPv6:2607:f8b0:4864:20::730]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 6DD246C8AA for ; Tue, 4 Jun 2019 14:58:55 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: by mail-qk1-x730.google.com with SMTP id a132so2990996qkb.13 for ; Tue, 04 Jun 2019 07:58:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bsdimp-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=l2+Ox9/0Uxb8+LmRB1dTJ4ax7rZTRa5bL1opHlIso+E=; b=VfL0VXsY93w+ykkoIZLhDOSWd3aWGnAkTIX/HhkV+dFK5sOE7G4x3fqeYPDQu6n9oH r3ZNvpSTooS3uDF6IX0EubtuTIPWuTt8E/pS95LQQ2We5nP3gPnm7gG7CQUqHQucSVpK J9EcHVQ7Ot3qvhokHPgCKyarRvo/EQGEWiwtbd9DF3A2PRbsqoajCqmwjt2wT4/0NVBh VXFyiakt4vDgT8YYLV+F25Qkb1/kb736e9LNzpZUcYr7U7nA2u0/Fmfywo04OsNtmhfz Pzrm+0+PTYh8g3QJYoo7ox3wKXwI5dHrqgpbGW3yR+3yMXcqq2f7DyfyM1OwqHOr6BNR xsJA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=l2+Ox9/0Uxb8+LmRB1dTJ4ax7rZTRa5bL1opHlIso+E=; b=M9y280IxBTwQ9/0Ovnez7il2xTJWn9qdkLrRXcT8+nAIwg1LlQkaFaIFiS8O44Ixx9 PGQjhiIrEGrHQdIFkr+cBJNXaZ9piTR8ANCzP6W7sbQcmxyMSvCHdFiMEfdz+s7howsM PEqoTWUgLl/7Qch5lRI/mQGCpam99zCMa9xkBpIfKDuT//4fQBbeuQiOqZTHfRb/CAON 6Uu0M/fYwFRV3jtd8uYuGEk9YuAfM9VNBC+Ocf12noZid/oohsdnY4IncBGUrbdMk2oX 3sgu/jSdnnmD9BZvDsHkEbwKnd0IkRLKo3Cj8u5MTY6XyGbjw4D1goFwB4qk2cVE6Z02 SaTg== X-Gm-Message-State: APjAAAVH2Omr0RE0WD+Ql0Wxr/Krbr1R7QK6b00ZGCg+sPy7x1fD4FHV mZx2GEhoW2kGKW/3r6YAj5YI6/DYzB0/9Ea7MHc1KA== X-Google-Smtp-Source: APXvYqy4N9eZ5ZDBXeruzAjvYZEQed9rpdKHmzwVeXeIm1We/KR3pbBUTPT1LUv0bBTQEb3pkaSQpKh3eq4KqfEgNGI= X-Received: by 2002:a37:4b48:: with SMTP id y69mr27578457qka.77.1559660334457; Tue, 04 Jun 2019 07:58:54 -0700 (PDT) MIME-Version: 1.0 References: <71a0c9f7-0b1f-3757-fc04-4c0d0a1e1085@FreeBSD.org> <20190604212831.360fd1a0c34c9f329e3084fc@dec.sakura.ne.jp> In-Reply-To: From: Warner Losh Date: Tue, 4 Jun 2019 08:58:43 -0600 Message-ID: Subject: Re: UEFI boot broken in 13? To: Tomoaki AOKI Cc: FreeBSD Current , Johannes Lundberg , Warner Losh X-Rspamd-Queue-Id: 6DD246C8AA X-Spamd-Bar: --- Authentication-Results: mx1.freebsd.org; dkim=pass header.d=bsdimp-com.20150623.gappssmtp.com header.s=20150623 header.b=VfL0VXsY X-Spamd-Result: default: False [-3.89 / 15.00]; ARC_NA(0.00)[]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; R_DKIM_ALLOW(-0.20)[bsdimp-com.20150623.gappssmtp.com:s=20150623]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_THREE(0.00)[4]; IP_SCORE(-3.01)[ip: (-9.47), ipnet: 2607:f8b0::/32(-3.24), asn: 15169(-2.29), country: US(-0.06)]; MIME_GOOD(-0.10)[multipart/alternative,text/plain]; PREVIOUSLY_DELIVERED(0.00)[freebsd-current@freebsd.org]; DMARC_NA(0.00)[bsdimp.com]; URI_COUNT_ODD(1.00)[7]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; TO_MATCH_ENVRCPT_SOME(0.00)[]; TO_DN_ALL(0.00)[]; DKIM_TRACE(0.00)[bsdimp-com.20150623.gappssmtp.com:+]; MX_GOOD(-0.01)[cached: ALT1.aspmx.l.google.com]; RCVD_IN_DNSWL_NONE(0.00)[0.3.7.0.0.0.0.0.0.0.0.0.0.0.0.0.0.2.0.0.4.6.8.4.0.b.8.f.7.0.6.2.list.dnswl.org : 127.0.5.0]; NEURAL_HAM_SHORT(-0.87)[-0.871,0]; R_SPF_NA(0.00)[]; FORGED_SENDER(0.30)[imp@bsdimp.com,wlosh@bsdimp.com]; SUBJECT_ENDS_QUESTION(1.00)[]; MIME_TRACE(0.00)[0:+,1:+]; ASN(0.00)[asn:15169, ipnet:2607:f8b0::/32, country:US]; FROM_NEQ_ENVFROM(0.00)[imp@bsdimp.com,wlosh@bsdimp.com]; RCVD_TLS_LAST(0.00)[]; RCVD_COUNT_TWO(0.00)[2] Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.29 X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 04 Jun 2019 14:58:56 -0000 On Tue, Jun 4, 2019 at 8:16 AM Warner Losh wrote: > > > On Tue, Jun 4, 2019 at 7:11 AM Tomoaki AOKI > wrote: > >> Hi. >> >> Try attached patch for stand/efi/boot1/boot1.c. >> This partially reverts r347193 and works at least for me. >> >> Without this, boot1.efi (bootx64.efi) forcibly boot from >> first physical HDD/SSD, even if forcibly booted from other >> physical drive via BIOS (UEFI firmware) menu. >> >> Remaining parts of >> https://reviews.freebsd.org/D20513https://reviews.freebsd.org/D20513 and >> following some commits does not >> affect. >> >> *Hand-crafted reverse patch from commit mail [1]. >> Reverting whole r347193 is fine, too. >> >> [1] >> https://lists.freebsd.org/pipermail/svn-src-head/2019-May/124677.html > > > I'll take a look. My experience is that even prior to this patch, forcibly > booting also failed though due to ordering issues... > More testing reveals that the issues prior to r347193 turned out to be different, and r347193 really did break things. I've opted to fix this in a slightly different way: https://reviews.freebsd.org/D20513 Aoki-san, can you please check to see if the above review fixes things for you as well? Thanks! Warner