From owner-svn-ports-head@freebsd.org Thu Sep 15 08:22:54 2016 Return-Path: Delivered-To: svn-ports-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 1645EBDC0E7; Thu, 15 Sep 2016 08:22:54 +0000 (UTC) (envelope-from madpilot@FreeBSD.org) Received: from mail.madpilot.net (grunt.madpilot.net [78.47.145.38]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 9429D11B8; Thu, 15 Sep 2016 08:22:53 +0000 (UTC) (envelope-from madpilot@FreeBSD.org) Received: from mail (mail [192.168.254.3]) by mail.madpilot.net (Postfix) with ESMTP id 3sZWcq2P3hzZrg; Thu, 15 Sep 2016 10:22:51 +0200 (CEST) Received: from mail.madpilot.net ([192.168.254.3]) by mail (mail.madpilot.net [192.168.254.3]) (amavisd-new, port 10024) with ESMTP id L9tT5m7vxP7G; Thu, 15 Sep 2016 10:22:45 +0200 (CEST) Received: from marvin.madpilot.net (micro.madpilot.net [88.149.173.206]) by mail.madpilot.net (Postfix) with ESMTPSA; Thu, 15 Sep 2016 10:22:45 +0200 (CEST) Subject: Re: svn commit: r422151 - head/devel/php70-APCu To: Mathieu Arnold , ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org References: <201609141913.u8EJD7pP073092@repo.freebsd.org> <1ac065a3-8ddb-0e3b-4d21-d35d726fb63e@FreeBSD.org> <8c68d72d-eee6-17ce-55d0-6867bf6c707e@FreeBSD.org> Cc: portmgr@FreeBSD.org From: Guido Falsi Message-ID: Date: Thu, 15 Sep 2016 10:22:31 +0200 User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:45.0) Gecko/20100101 Thunderbird/45.3.0 MIME-Version: 1.0 In-Reply-To: Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="GX1FjLmDlwn0p7DXuiva0PA23CJCxdnKH" X-BeenThere: svn-ports-head@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: SVN commit messages for the ports tree for head List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 15 Sep 2016 08:22:54 -0000 This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --GX1FjLmDlwn0p7DXuiva0PA23CJCxdnKH Content-Type: multipart/mixed; boundary="troLbdosPnEO15qKiwlqEaUHuDjQG3Ida"; protected-headers="v1" From: Guido Falsi To: Mathieu Arnold , ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Cc: portmgr@FreeBSD.org Message-ID: Subject: Re: svn commit: r422151 - head/devel/php70-APCu References: <201609141913.u8EJD7pP073092@repo.freebsd.org> <1ac065a3-8ddb-0e3b-4d21-d35d726fb63e@FreeBSD.org> <8c68d72d-eee6-17ce-55d0-6867bf6c707e@FreeBSD.org> In-Reply-To: --troLbdosPnEO15qKiwlqEaUHuDjQG3Ida Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 09/15/16 10:01, Mathieu Arnold wrote: > Le 15/09/2016 =C3=A0 01:29, Guido Falsi a =C3=A9crit : >> On 09/15/16 01:22, Guido Falsi wrote: >> >>> Meybe some cleaner way to allow php7 parts to be built on the cluster= >>> should be made available, although I don't know what that can be righ= t now. >>> >> For example, would such definition be more acceptable if limited to >> PACKAGE_BUILDING? >=20 > The problem I have with its usage directly in ports is that it is > supposed to be a global user settable variable, saying "I want php XX" > (using DEFAULT_VERSIONS+=3Dphp=3DXX in /etc/make.conf). >=20 > For this port, though, I may have over-reacted, it is named php70- and > can only work with 7.0. Now that I have slept on it, I would say leave > it like that, with PHP_DEFAULT set. It is the only case where setting i= t > is acceptable. >=20 > For example, it is not acceptable in a pecl-foo port, because the user > will be left to wonder why running "pkg install pecl-foo" removed his > php 5.6 installation. >=20 For the record, I was looking at the tree and the other ports doing the same are: www/pecl-http databases/php70-redis databases/php55-redis databases/php56-redis devel/php70-APCu (each setting the relevant PHP version) The only one not respecting your reasoning(which I tend to agree with) is www/pecl-http, which is really a php 7.0 only version, there are ports for older versions supporting only php 5.6 and php 5.5. While the name does not make it perfectly clear, the same reasoning could be applied. Thanks for keeping an eye on commits though, this is the only way to spot real mistakes! --=20 Guido Falsi --troLbdosPnEO15qKiwlqEaUHuDjQG3Ida-- --GX1FjLmDlwn0p7DXuiva0PA23CJCxdnKH Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEyBAEBCAAcBQJX2lpRFRxtYWRwaWxvdEBmcmVlYnNkLm9yZwAKCRAa5oYOVsvS kxODB/9tF8BbcQ8dWNxaSdhHMYv8kLjboVqMfGRoaJW/8ew0TC6P5qShH1kyck4V WU8MYe5mQRlLJhAn8ffnYICKS9qhtVoWWfQnOmUCmF390+pdRKXzi9qcQxcsu1Wu lHcB3xHHAT/o6ODK7NjmcSguQVMI4IW6aleax+XhejFaV0WDL949CI5athFCm7NI XAZ+0BkE7tIi7XSUcu3tMtNWMZ+1zd/BsLJHcP9RUhOgoUCh+X09MGOq3shS84VF nxMpuG22hkfXioUpbZj01yi3ydPz6+Y9DhBenCNAvctFqAvv4sau01oKmrQ8WuDb SS0zYKMJzgdZ9W319osyH3xGTntf =N6by -----END PGP SIGNATURE----- --GX1FjLmDlwn0p7DXuiva0PA23CJCxdnKH--