From owner-svn-ports-all@freebsd.org Thu Feb 4 06:06:20 2016
Return-Path: <owner-svn-ports-all@freebsd.org>
Delivered-To: svn-ports-all@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
[IPv6:2001:1900:2254:206a::19:1])
by mailman.ysv.freebsd.org (Postfix) with ESMTP id 42B71A9BA14;
Thu, 4 Feb 2016 06:06:20 +0000 (UTC)
(envelope-from koobs.freebsd@gmail.com)
Received: from mail-pf0-x22d.google.com (mail-pf0-x22d.google.com
[IPv6:2607:f8b0:400e:c00::22d])
(using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))
(Client CN "smtp.gmail.com",
Issuer "Google Internet Authority G2" (verified OK))
by mx1.freebsd.org (Postfix) with ESMTPS id 12B211370;
Thu, 4 Feb 2016 06:06:20 +0000 (UTC)
(envelope-from koobs.freebsd@gmail.com)
Received: by mail-pf0-x22d.google.com with SMTP id o185so33347961pfb.1;
Wed, 03 Feb 2016 22:06:20 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113;
h=sender:reply-to:subject:references:to:from:message-id:date
:user-agent:mime-version:in-reply-to:content-type
:content-transfer-encoding;
bh=lI7LNFedP5COo0juaMW4GarsW0cCXj0BTHMzoXLtBQE=;
b=Vex0nzqeVqBvzJy1ObVZFL4UpO+gAZLeWKP3I1bsksXRYDMITlLIiP+WPWr+H0bcXx
Ho3AlpAd5x16zOrfKISxSHfEEI/JWEr7AMTgVw2SYdaRvpBxkiCD5AB3KiJHftf46tVz
S4DxCdOWBFwVADFjFmgKFuSpH6zANdu4EVxPv4vzmRs41WU2EkT2GCVoONqoS/GtvYrA
yo/M8mRTTu8iVKY8bbEvJ83fOPtMjuC36JiEZfukDDuQOu718rP0vtQkQHgmYyJAFkUm
6uruPbIIZVEML/bEKviWlzDU7uR0OEvETyy9ZseEPY2OqGQLGtKM4szLpSVAtalgQRt+
6utg==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=1e100.net; s=20130820;
h=x-gm-message-state:sender:reply-to:subject:references:to:from
:message-id:date:user-agent:mime-version:in-reply-to:content-type
:content-transfer-encoding;
bh=lI7LNFedP5COo0juaMW4GarsW0cCXj0BTHMzoXLtBQE=;
b=KQQGksIvQJeq4E4SkKWLctLqngyWCWvTWQnvHwSYjU2O1GSxwjXuz1GJ3fMlQjAfX4
dGisGeje05oTkpfO4ge7JbTtqFFs28IwTtbr9m551BGPOM4wO6s4MZRyecJV3cp2D6A3
L2xrVdqPlHWCaNPWdgzNTKy1EKYUEXShL3P7VVCESRX1li52t2Z1U/H6RqjpKKSQoVo2
9DTMaAyusorYA9oqHjeGLQl22D582/oZQPeAydYJH9ogo/3ZjdPbJ+5HIp4d1I5lfSQz
2YpxHp4dDyqMNTtOT7S6N9/x69nN5baIAcUBOtq2JWq3pFRaaJsnQNIdpvZg8KO5edZI
pINA==
X-Gm-Message-State: AG10YORroAE3hE67s5V9MSFpGmIyqXjJ8kXacF1j9+iAqQjs0Y7NGg40Pq6OVArvKvXMfg==
X-Received: by 10.98.33.199 with SMTP id o68mr8183543pfj.125.1454565979647;
Wed, 03 Feb 2016 22:06:19 -0800 (PST)
Received: from ?IPv6:2001:44b8:31ae:7b01:b1ac:464b:e316:e4af?
(2001-44b8-31ae-7b01-b1ac-464b-e316-e4af.static.ipv6.internode.on.net.
[2001:44b8:31ae:7b01:b1ac:464b:e316:e4af])
by smtp.gmail.com with ESMTPSA id w85sm13965611pfi.13.2016.02.03.22.06.16
(version=TLSv1/SSLv3 cipher=OTHER);
Wed, 03 Feb 2016 22:06:19 -0800 (PST)
Sender: Kubilay Kocak <koobs.freebsd@gmail.com>
Reply-To: koobs@FreeBSD.org
Subject: Re: svn commit: r407978 - head/dns/py-py3dns
References: <201602032054.u13KsXim088211@repo.freebsd.org>
To: Sunpoet Po-Chuan Hsieh <sunpoet@FreeBSD.org>,
ports-committers@freebsd.org, svn-ports-all@freebsd.org,
svn-ports-head@freebsd.org
From: Kubilay Kocak <koobs@FreeBSD.org>
X-Enigmail-Draft-Status: N1110
Message-ID: <56B2EA50.2070205@FreeBSD.org>
Date: Thu, 4 Feb 2016 17:06:08 +1100
User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:44.0) Gecko/20100101
Thunderbird/44.0
MIME-Version: 1.0
In-Reply-To: <201602032054.u13KsXim088211@repo.freebsd.org>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
X-BeenThere: svn-ports-all@freebsd.org
X-Mailman-Version: 2.1.20
Precedence: list
List-Id: SVN commit messages for the ports tree <svn-ports-all.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-ports-all>,
<mailto:svn-ports-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-ports-all/>
List-Post: <mailto:svn-ports-all@freebsd.org>
List-Help: <mailto:svn-ports-all-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-ports-all>,
<mailto:svn-ports-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 04 Feb 2016 06:06:20 -0000
On 4/02/2016 7:54 AM, Sunpoet Po-Chuan Hsieh wrote:
> Author: sunpoet
> Date: Wed Feb 3 20:54:33 2016
> New Revision: 407978
> URL: https://svnweb.freebsd.org/changeset/ports/407978
>
> Log:
> - Sort knobs
> - Remove incorrect and outdated PYTHON_REL check
> - Do not silence test message
>
> Modified:
> head/dns/py-py3dns/Makefile
>
> Modified: head/dns/py-py3dns/Makefile
> ==============================================================================
> --- head/dns/py-py3dns/Makefile Wed Feb 3 20:54:28 2016 (r407977)
> +++ head/dns/py-py3dns/Makefile Wed Feb 3 20:54:33 2016 (r407978)
> @@ -17,20 +17,11 @@ LICENSE_PERMS= dist-mirror dist-sell pkg
>
> TEST_DEPENDS= ${PYTHON_PKGNAMEPREFIX}pytest>=0:${PORTSDIR}/devel/py-pytest
>
> -USES= python:3.3+
> -USE_PYTHON= autoplist distutils
> -
> NO_ARCH= yes
> -
> -.include <bsd.port.pre.mk>
> -
> -.if ${PYTHON_REL} == 3300
> -RUN_DEPENDS+= ${PYTHON_PKGNAMEPREFIX}ipaddress>=0:${PORTSDIR}/net/py-ipaddress
> -.elif ${PYTHON_REL} <= 3200
> -RUN_DEPENDS+= ${PYTHON_PKGNAMEPREFIX}ipaddr>=0:${PORTSDIR}/devel/py-ipaddr
> -.endif
> +USE_PYTHON= autoplist distutils
> +USES= python:3.3+
Removing the 3300 check breaks the port, which is what r407821 and
r407820 fixed:
https://svnweb.freebsd.org/changeset/ports/407821
https://svnweb.freebsd.org/changeset/ports/407820
This causes a regression on 3.3
I'm also -1 on removing declarations of which python versions a package
supports, whether or not we have them in the tree.
If a package supports 3.2+, we remove information, and make the
dependency declaration incorrect, by changing it to 3.3+.
Dependencies (particularly for python ports) are declarative, not
imperative, with the framework then deriving which lang/pythonXY ports
match, or are suitable.
> do-test:
> - @cd ${WRKSRC} && ${PYTHON_CMD} -m pytest
> + cd ${WRKSRC}/ && ${PYTHON_CMD} -m pytest
>
> -.include <bsd.port.post.mk>
> +.include <bsd.port.mk>
>