From owner-freebsd-hackers@FreeBSD.ORG  Tue Oct 21 21:04:44 2008
Return-Path: <owner-freebsd-hackers@FreeBSD.ORG>
Delivered-To: freebsd-hackers@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id E496B106567D;
	Tue, 21 Oct 2008 21:04:44 +0000 (UTC)
	(envelope-from bright@elvis.mu.org)
Received: from elvis.mu.org (elvis.mu.org [192.203.228.196])
	by mx1.freebsd.org (Postfix) with ESMTP id D4A798FC16;
	Tue, 21 Oct 2008 21:04:44 +0000 (UTC)
	(envelope-from bright@elvis.mu.org)
Received: by elvis.mu.org (Postfix, from userid 1192)
	id 825271A3C3C; Tue, 21 Oct 2008 14:04:44 -0700 (PDT)
Date: Tue, 21 Oct 2008 14:04:44 -0700
From: Alfred Perlstein <alfred@freebsd.org>
To: Norbert Koch <nkoch@demig.de>
Message-ID: <20081021210444.GB22503@elvis.mu.org>
References: <48FD88B1.3050106@demig.de>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <48FD88B1.3050106@demig.de>
User-Agent: Mutt/1.4.2.3i
Cc: freebsd-hackers@freebsd.org, freebsd-threads@freebsd.org
Subject: Re: 'libc_r: enter/leave_cancellation_point()
X-BeenThere: freebsd-hackers@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Technical Discussions relating to FreeBSD
	<freebsd-hackers.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-hackers>, 
	<mailto:freebsd-hackers-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-hackers>
List-Post: <mailto:freebsd-hackers@freebsd.org>
List-Help: <mailto:freebsd-hackers-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-hackers>,
	<mailto:freebsd-hackers-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 21 Oct 2008 21:04:45 -0000

Hey Norbert, this is probably a bug, but might not be addressed
because libc_r is not really supported any longer.

Someone may pick it up, but I'm uncertain of that.

* Norbert Koch <nkoch@demig.de> [081021 01:32] wrote:
> Hello,
> 
> I was just inspecting libc_r for trying to understand
> some things and found this:
> 
> <-------------------------
> 
> --- src/lib/libc_r/uthread/uthread_cond.c	2002/05/24 04:32:28	1.33
> +++ src/lib/libc_r/uthread/uthread_cond.c	2002/11/13 18:13:26	1.34
> 
> ...
> 
>  int
> -_pthread_cond_signal(pthread_cond_t * cond)
> +__pthread_cond_timedwait(pthread_cond_t *cond, pthread_mutex_t *mutex,
> +		       const struct timespec *abstime)
> +{
> +	int ret;
> +
> +	_thread_enter_cancellation_point();
> +	ret = _pthread_cond_timedwait(cond, mutex, abstime);
> +	_thread_enter_cancellation_point();
> +	return (ret);
> +}
> 
> 
> ---------------------------->
> 
> Shouldn't that be _thread_leave_cancellation_point() after
> calling _pthread_cond_timedwait() ?
> What effect should I see if this is wrong?
> 
> Best regards,
> 
> Norbert Koch
> 
> _______________________________________________
> freebsd-hackers@freebsd.org mailing list
> http://lists.freebsd.org/mailman/listinfo/freebsd-hackers
> To unsubscribe, send any mail to "freebsd-hackers-unsubscribe@freebsd.org"
> _______________________________________________
> freebsd-threads@freebsd.org mailing list
> http://lists.freebsd.org/mailman/listinfo/freebsd-threads
> To unsubscribe, send any mail to "freebsd-threads-unsubscribe@freebsd.org"

-- 
- Alfred Perlstein