From owner-cvs-all Tue Jan 2 11:36:39 2001 From owner-cvs-all@FreeBSD.ORG Tue Jan 2 11:36:34 2001 Return-Path: Delivered-To: cvs-all@freebsd.org Received: from meow.osd.bsdi.com (meow.osd.bsdi.com [204.216.28.88]) by hub.freebsd.org (Postfix) with ESMTP id 43A1237B400; Tue, 2 Jan 2001 11:36:34 -0800 (PST) Received: from laptop.baldwin.cx (john@jhb-laptop.osd.bsdi.com [204.216.28.241]) by meow.osd.bsdi.com (8.11.1/8.9.3) with ESMTP id f02JZvG01056; Tue, 2 Jan 2001 11:35:57 -0800 (PST) (envelope-from jhb@FreeBSD.org) Message-ID: X-Mailer: XFMail 1.4.0 on FreeBSD X-Priority: 3 (Normal) Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 8bit MIME-Version: 1.0 In-Reply-To: <200101021927.f02JRtO11317@gratis.grondar.za> Date: Tue, 02 Jan 2001 11:36:21 -0800 (PST) From: John Baldwin To: Mark Murray Subject: Re: cvs commit: src/sys/kern kern_sig.c Cc: cvs-all@FreeBSD.org, cvs-committers@FreeBSD.org Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG On 02-Jan-01 Mark Murray wrote: >> jhb 2001/01/02 10:54:10 PST >> >> Modified files: >> sys/kern kern_sig.c >> Log: >> The previous commit wasn't entirely correct. At least one goto to the >> out: label in psignal() did not grab sched_lock before trying to release >> it. Also, the previous version had several cases where it grabbed >> sched_lock before jumping to out: unneccessarily, so rework this a bit. >> The runfast: and out: labels must be called with sched_lock released, and >> the run: label must be called with it held. Appropriate mtx_assert()'s >> have been added that should catch any bugs that may still be in this >> code. > > It this likely to catch any or all of the CURRENT deadlocks? It might fix hangs involving signal handling, though I think the previous checkin was close enough to have already fixed those. One of my SMP boxes now hangs relatively quickly (10 - 15 minutes into an installworld). I'll need to rig up a serial console, turn on a lot of KTR logging and let it run for however long KTR slows it down (my guess is multiple days :( ) until it hangs then stare the KTR logs until I can figure out where it hung. -- John Baldwin -- http://www.FreeBSD.org/~jhb/ PGP Key: http://www.baldwin.cx/~john/pgpkey.asc "Power Users Use the Power to Serve!" - http://www.FreeBSD.org/ To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message