From nobody Sat Aug 19 08:51:25 2023 X-Original-To: ports@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4RSXXg0bXTz4qRHr for ; Sat, 19 Aug 2023 08:51:31 +0000 (UTC) (envelope-from mat@freebsd.org) Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4RSXXf5FmWz4fRQ for ; Sat, 19 Aug 2023 08:51:30 +0000 (UTC) (envelope-from mat@freebsd.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1692435090; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=GoZfWlPlQAN88tZFHyb3wROMgaaCuRGYCDKgkght8ms=; b=rUw3X7warvn/Kt3E5Mkr/z/PO44LsLjZkn90meO7gGSaB5/eFTB+JAZUKQFz/4ayta/nNq lY+CT0rej/te8FbSIj8gHdis7c2xhSl7fsTTMsw8LI374A64fOMGX70/DZi86f21AL/GmB 5WXuLN2WMAxvzoHPe8MuybCVn+ulC+8JZPtBfPKJM0roR7CSR5KL1uh1b3tS1rvzl63uqQ zddbDR4jhqQ6I5dixGcItogQ7W/d7RBkzq5OaN4pLYV9x7yb0p3G+wP9IuRHREbFctIx9/ YIuQq2RXfhBmoAe8ooqDYmwmoGdWcQ9zTkuJmCs5XFPe3teaeab8om0PLLt5Jg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1692435090; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=GoZfWlPlQAN88tZFHyb3wROMgaaCuRGYCDKgkght8ms=; b=wFYIK89hXY+9FfVXftRkd0bUHpXWKkZXsYJrh5P4gLMAzR7joSFcFV2x3ZlvtCWwQlnzRI vgcf/PqXDgrtJ6gLYzQ1S/CmIZifjKXy+/2/p90ojiYzGvhr+fWWniuJmdiJqIupnzCxRK xfhVd9/f0ZmibmfV/yFESy1QiZAbAZxAhPVWracnOWZpHpjAQB0YWsg1sgKYfrAIU04nuV OjhkcKnno6PvSGsc+3rsa3qcn/iXSDgwysFBhUCT/ri0p/rc2lJVc+RzBhbAOWDBGZf34T iirjTmuiMzyK315lfAYBBhO1CXnF3P+12BFvy9ZXH5Kf7dun/SkTsTSV+ic9Og== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1692435090; a=rsa-sha256; cv=none; b=BegxCMyghFhInUqVvSedaBYcwhmNubFp/bsTgpinucDDb0fA6KEsOq/ZT7Ql8LBusEq+OE SxSgkcu7EnR6Kft0FMOf3QPtP2yslquWI8fHL7YnwJhSeq+tJsImTnY3AeGvl7XkYmJnoN dRMMrUmTwSWlZJ1QUDlg2xr4fH9mRPbLshPECzoz0R96Ql4uAfMc9WS3Mwni8CC92+z4Th 8ZinPLvKyUP5GG80w3UqhKCQPFDTx0UUSZbGDE3EepR8nmhzR9Ya2xSJZCTD56PxK0DmZi 9Ws5nh0HGNNRNrm9TW9LDSloGvTd9Ed/uSJDqPnPMyJmokkXXvH7wNR5/KUlfA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from mail.j.mat.cc (owncloud.cube.mat.cc [79.143.240.228]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mail.mat.cc", Issuer "R3" (verified OK)) (Authenticated sender: mat/mail) by smtp.freebsd.org (Postfix) with ESMTPSA id 4RSXXf3ZY4z5xQ for ; Sat, 19 Aug 2023 08:51:30 +0000 (UTC) (envelope-from mat@freebsd.org) Received: from aching.in.mat.cc (unknown [IPv6:2a01:e0a:836:f670:e410:e320:2fe6:e575]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: mat@mat.cc) by mail.j.mat.cc (Postfix) with ESMTPSA id 79379942D80 for ; Sat, 19 Aug 2023 08:51:28 +0000 (UTC) Date: Sat, 19 Aug 2023 10:51:25 +0200 From: Mathieu Arnold To: ports@freebsd.org Subject: Re: plist-check not reporting orphaned files present in a @comment Message-ID: References: <5h3c6jbzs7y5k3hyimqn7jkyo3se3txvcywahpcffzc24hjew7@kx4mhnqq7gh4> <8raa-vofq-wny@FreeBSD.org> <2ppfted4t72jo2bhgxfmoghpm6zukhrcqevucxvouqqwehwugg@zy4chydjtuxy> <67hyj5pbnd2hf66tdj2szrtyhxozmjjcevw5rooas2vzrltxna@oqjzi7m5tfho> List-Id: Porting software to FreeBSD List-Archive: https://lists.freebsd.org/archives/freebsd-ports List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-ports@freebsd.org X-BeenThere: freebsd-ports@freebsd.org MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="kjdm7z7bhib5svja" Content-Disposition: inline In-Reply-To: <67hyj5pbnd2hf66tdj2szrtyhxozmjjcevw5rooas2vzrltxna@oqjzi7m5tfho> --kjdm7z7bhib5svja Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Aug 16, 2023 at 08:37:22PM +0200, Felix Palmen wrote: > IMHO, the straight-forward solution would be: A port hit by that should > add some "post-install-" (or -off) recipe explicitly removing the > unwanted files from ${STAGEDIR}. Well, it is a solution, but it is slower. How it works now: 1. some file gets installed 2. that file is not in the plist, so it does not get packaged (actually it is @comment'ed, but for pkg, it is the same thing as it not being there) So, that file only has one i/o operation, when it is installed, it then is left there. It gets removed when `make clean` is ran, but so are all files in WRKDIR, so the io hit is low because all the directory is removed anyway. What you want to do is : 1. some file gets installed 2. you run rm on it So, the file now has two i/o operations associated to it, when it is installed, and when it is removed. The io hit is higher because only that file is removed, and then when `make clean` that directory gets hit again. It may not seems much for one port, but when you have 30k+ ports doing that for many files, it adds up. --=20 Mathieu Arnold --kjdm7z7bhib5svja Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQITBAABCgB9FiEE9XJBpJetWizkEBUef2IOCp6dQb4FAmTggo1fFIAAAAAALgAo aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldEY1 NzI0MUE0OTdBRDVBMkNFNDEwMTUxRTdGNjIwRTBBOUU5RDQxQkUACgkQf2IOCp6d Qb5eZgwAmeXTU+KatsyUUBPZtojUdaQAAf2at3JXrT4eBCVyiphMjIRSNOarvbGI X5UwB0J+1G/UQCcbDTC82ygniD+CmrpOPlIXUaZi/qY7WHK/UGsWQQEpswTKSTxO 8IKPOmtxNSkgsNs+9iazQlOigcq8jhG32FTmr0V6I823dSVMlOgou0CF4q1laE5f zLjnNVatkrIGACEvBXCHBehUcgToN4Vh26EwEfYgjOnCTGTLqHLqrz59NMc3HoA4 oJ83u8JDxJ8lghLpJ2vcSeszPdZY4KowWqJkfVvdy1iy+0cmCCpD3UGYznrZU7wl LJeS2aFT+lZBXY4eaIDn2iqaDWSIDJu9H9xWeMx0vSGKOxs+P9hjfjdGR90OfBGm WPFP3cx4izEV+0tXKKp8R6lrKEt6pvpMeYXP9TsgqvkgBA5nqY54BGWAHqBJsnHe 2e7sPOMANZe635fFSijH2L0TS1gM1muYj84fy7TJJBv4KODyTAnFe1LoKRFldAxt 1YRh+Fvu =9Sl6 -----END PGP SIGNATURE----- --kjdm7z7bhib5svja--