From owner-freebsd-ports-bugs@FreeBSD.ORG Thu Apr 14 23:30:23 2005 Return-Path: Delivered-To: freebsd-ports-bugs@hub.freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id B67CD16A4CE for ; Thu, 14 Apr 2005 23:30:23 +0000 (GMT) Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21]) by mx1.FreeBSD.org (Postfix) with ESMTP id 8F02943D45 for ; Thu, 14 Apr 2005 23:30:23 +0000 (GMT) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1]) by freefall.freebsd.org (8.13.3/8.13.3) with ESMTP id j3ENUNnw051229 for ; Thu, 14 Apr 2005 23:30:23 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.13.3/8.13.1/Submit) id j3ENUNqt051228; Thu, 14 Apr 2005 23:30:23 GMT (envelope-from gnats) Date: Thu, 14 Apr 2005 23:30:23 GMT Message-Id: <200504142330.j3ENUNqt051228@freefall.freebsd.org> To: freebsd-ports-bugs@FreeBSD.org From: Michael Nottebrock Subject: Re: ports/79938: New port:x11-themes/kdmtheme KDM Theme Manager X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list Reply-To: Michael Nottebrock List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 14 Apr 2005 23:30:23 -0000 The following reply was made to PR ports/79938; it has been noted by GNATS. From: Michael Nottebrock To: bug-followup@FreeBSD.org, illusia@inbox.lv Cc: Subject: Re: ports/79938: New port:x11-themes/kdmtheme KDM Theme Manager Date: Fri, 15 Apr 2005 01:21:59 +0200 This port had a few problems. I've fixed all of them, but here's for reference for your future submissions: 1.) Indentions in Makefiles must be tabs, not spaces. For targets make itself will insist on tabs, for varibles it's good practice to use tabs as well (saves space in CVS). Many mailers convert tabs to spaces if stuff is pasted into them, so do the text-widgets of gtk-send-pr and some editors, so make sure to attach shars/diffs instead of pasting them. 2.) The port didn't compile on FreeBSD 4. If you cannot test your ports or patches for ports on FreeBSD 4, please note this in the PR. 3.) The port was not PTHREAD_LIBS-safe (configure tries "-lpthread" and will use it if it succeeds regardless of the value of PTHREAD_LIBS). 4.) The port Makefile contained one unnecessary and one unused variable. 5.) It's good practice to run pkg-descr through fmt(1) before submitting. It generally does a good job with formatting to ports' (and sysinstall's) requirements and making things nice to read. -- ,_, | Michael Nottebrock | lofi@freebsd.org (/^ ^\) | FreeBSD - The Power to Serve | http://www.freebsd.org \u/ | K Desktop Environment on FreeBSD | http://freebsd.kde.org