From owner-svn-ports-head@FreeBSD.ORG Thu May 14 16:03:45 2015 Return-Path: Delivered-To: svn-ports-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 1D08D2B6 for ; Thu, 14 May 2015 16:03:45 +0000 (UTC) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:1900:2254:206c::16:87]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id D8C741E7B for ; Thu, 14 May 2015 16:03:44 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.9/8.14.9) with ESMTP id t4EG3ii6009599 for ; Thu, 14 May 2015 16:03:44 GMT (envelope-from bdrewery@freefall.freebsd.org) Received: (from bdrewery@localhost) by freefall.freebsd.org (8.14.9/8.14.9/Submit) id t4EG3ic8009592 for svn-ports-head@freebsd.org; Thu, 14 May 2015 16:03:44 GMT (envelope-from bdrewery) Received: (qmail 68347 invoked from network); 14 May 2015 11:03:43 -0500 Received: from unknown (HELO ?10.10.1.139?) (freebsd@shatow.net@10.10.1.139) by sweb.xzibition.com with ESMTPA; 14 May 2015 11:03:43 -0500 Message-ID: <5554C761.3060609@FreeBSD.org> Date: Thu, 14 May 2015 11:03:45 -0500 From: Bryan Drewery Organization: FreeBSD User-Agent: Mozilla/5.0 (Windows NT 6.3; WOW64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 MIME-Version: 1.0 To: Adam Weinberger , "Philip M. Gollucci" CC: "ports-committers@freebsd.org" , "svn-ports-all@freebsd.org" , "svn-ports-head@freebsd.org" Subject: Re: svn commit: r386285 - head/security/keychain References: <201505140101.t4E11r9T031351@svn.freebsd.org> <08F806A7-3CD9-417A-BA4E-AF739E83B6A8@adamw.org> <082DB80D-6385-4F4F-8A86-2DB4561E39E8@adamw.org> In-Reply-To: <082DB80D-6385-4F4F-8A86-2DB4561E39E8@adamw.org> OpenPGP: id=F9173CB2C3AAEA7A5C8A1F0935D771BB6E4697CF; url=http://www.shatow.net/bryan/bryan2.asc Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="oA2QsfE2fSgNKWthDLnvxhi5QEA2s29f1" X-BeenThere: svn-ports-head@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: SVN commit messages for the ports tree for head List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 14 May 2015 16:03:45 -0000 This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --oA2QsfE2fSgNKWthDLnvxhi5QEA2s29f1 Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: quoted-printable On 5/14/2015 11:00 AM, Adam Weinberger wrote: >> On 13 May, 2015, at 21:20, Philip M. Gollucci w= rote: >> >> Then it needs an option not an if exists() >=20 > Bryan, can you please consider reverting it, or giving me approval to r= evert it? It may fix the case when the port is built in poudriere without= sshd in base, but it is a regression for everybody else. >=20 > # Adam >=20 >=20 No. The way RUN_DEPENDS is supposed to work is what I said in the commit. These exists() checks are redundant and confuse the package dependencies. How are you building? It's possible the tool you are using is incorrectly handling RUN_DEPENDS. --=20 Regards, Bryan Drewery --oA2QsfE2fSgNKWthDLnvxhi5QEA2s29f1 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBAgAGBQJVVMdhAAoJEDXXcbtuRpfPO6oH/jjjncrur4c3R6BWA3vUZPEZ jaaI2L3/+ZrbKDD4/tYMbUOSnEcbeyF73cSi3iTSmunMnERwMK8n0u2UksGINcZ7 D7RivZdT7rT4JFDD0Uxt32amfh5nSzdufckOa4Sd/6EFFJIedhqW0eKJWfz7JGND H5nKzN+jfVC4v6Gx3s806G9DHuzc7lbYYQy/YzeezT4U8VEkSmHhYy30sfWvKn3w SoLvn3IHUILs1FPEF8OsQE4Bdw+Ba3ic1Dtw+dkRMnmyvHv1lK24OvowbN9hfexT Z1xQDrJPxiMFSJYrQVY9dzGzgxdss19NORDYAiuGvEq+UTLoXxKvEthu+U6+H+U= =qYon -----END PGP SIGNATURE----- --oA2QsfE2fSgNKWthDLnvxhi5QEA2s29f1--