From owner-freebsd-current@FreeBSD.ORG Sun Feb 17 06:42:03 2008 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id DF8F016A473 for ; Sun, 17 Feb 2008 06:42:03 +0000 (UTC) (envelope-from pyunyh@gmail.com) Received: from wa-out-1112.google.com (wa-out-1112.google.com [209.85.146.180]) by mx1.freebsd.org (Postfix) with ESMTP id B9A7713C461 for ; Sun, 17 Feb 2008 06:42:03 +0000 (UTC) (envelope-from pyunyh@gmail.com) Received: by wa-out-1112.google.com with SMTP id k17so2100108waf.3 for ; Sat, 16 Feb 2008 22:42:03 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:received:received:date:from:to:cc:subject:message-id:reply-to:references:mime-version:content-type:content-disposition:in-reply-to:user-agent; bh=659DAyZ+47DPDDtGa5X6thlb56myhLDU/Qw5Z4uTS8A=; b=nH+FrJx5Xomj08Z+q3FVYz/+7wompMJNdTLlePgkyECO3UkyFivMBKp8/exLFEr06KgCWPnZ9JYaE8fsotbNv3QJd/NNsZkrXks1gMDdjgaSLLmmvIE0jcsYO3otA9tHuZp2IHeE9CDamjKYt1Og2FkbC+xu+KFyOpYd0IHKINg= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=date:from:to:cc:subject:message-id:reply-to:references:mime-version:content-type:content-disposition:in-reply-to:user-agent; b=UgshepMuFjyc75rkOV3nlMb5sJLxpa5Sp/ujjHDg+0VuJn1eAkihlWWmddnDzTL5t7AjlpzVmHk3LnSggVyjnx/AIg/5AY3u2ZarZ01AVuN7QZvo4LOKv07YK5KBENVi09VFtRI9dNim0+tRBW5qHH/tL1HA/AcRCT5M/ttqFPY= Received: by 10.142.241.10 with SMTP id o10mr3459795wfh.27.1203230522454; Sat, 16 Feb 2008 22:42:02 -0800 (PST) Received: from michelle.cdnetworks.co.kr ( [211.53.35.84]) by mx.google.com with ESMTPS id 22sm14321711wfg.15.2008.02.16.22.42.00 (version=TLSv1/SSLv3 cipher=OTHER); Sat, 16 Feb 2008 22:42:01 -0800 (PST) Received: from michelle.cdnetworks.co.kr (localhost.cdnetworks.co.kr [127.0.0.1]) by michelle.cdnetworks.co.kr (8.13.5/8.13.5) with ESMTP id m1H6fuTm011436 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Sun, 17 Feb 2008 15:41:56 +0900 (KST) (envelope-from pyunyh@gmail.com) Received: (from yongari@localhost) by michelle.cdnetworks.co.kr (8.13.5/8.13.5/Submit) id m1H6ftmR011435; Sun, 17 Feb 2008 15:41:55 +0900 (KST) (envelope-from pyunyh@gmail.com) Date: Sun, 17 Feb 2008 15:41:55 +0900 From: Pyun YongHyeon To: Mike Tancsa Message-ID: <20080217064155.GB10866@cdnetworks.co.kr> References: <20071008061758.GF46694@cdnetworks.co.kr> <200802160638.m1G6cSX1088707@lava.sentex.ca> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200802160638.m1G6cSX1088707@lava.sentex.ca> User-Agent: Mutt/1.4.2.1i Cc: freebsd-current@freebsd.org Subject: Re: CFT: vr(4) X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: pyunyh@gmail.com List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 17 Feb 2008 06:42:04 -0000 On Sat, Feb 16, 2008 at 01:38:46AM -0500, Mike Tancsa wrote: > At 01:17 AM 10/8/2007, Pyun YongHyeon wrote: > >It seems that there had been several stability issues in vr(4). > >Here is mimimal patch that make vr(4) work reliably under heavy > >network loads. The patch does the following: > > - Always check writability of mbuf before padding and make a > > writable copy of the mbuf if mbuf is marked as read-only. > > - Before padding is done check remaining bytes such that it can > > safely extend buffer size of the mbuf. > > - Before padding always check the return value of m_defrag(9). > > - Zero out pad space to avoid leaking data. > > > >If you have vr(4) hardware please give it spin and let me know > >the result. > > Its been working quite well on 3 Soekris 5501 boards! It would be > great to see these fixes committed. > I'll commit it in a week. Thanks a lot for your time/testing! -- Regards, Pyun YongHyeon