From owner-freebsd-ports@FreeBSD.ORG  Tue May  6 05:09:01 2003
Return-Path: <owner-freebsd-ports@FreeBSD.ORG>
Delivered-To: freebsd-ports@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 1E26737B405
	for <ports@FreeBSD.org>; Tue,  6 May 2003 05:09:01 -0700 (PDT)
Received: from outpost.globcon.net (outpost.globcon.net [62.141.88.161])
	by mx1.FreeBSD.org (Postfix) with SMTP id BD38443FAF
	for <ports@FreeBSD.org>; Tue,  6 May 2003 05:08:58 -0700 (PDT)
	(envelope-from sergei@kolobov.com)
Received: (qmail 91434 invoked from network); 6 May 2003 12:08:59 -0000
Received: from agdcgw01.akingump.com (HELO kolobov.com) (12.40.174.2)
  by outpost.globcon.net with SMTP; 6 May 2003 12:08:59 -0000
Received: (qmail 34410 invoked by uid 911); 6 May 2003 12:04:47 -0000
Date: Tue, 6 May 2003 16:04:47 +0400
From: Sergei Kolobov <sergei@kolobov.com>
To: FreeBSD-gnats-submit@FreeBSD.org, ports@FreeBSD.org
Message-ID: <20030506120446.GB674@globcon.net>
Mail-Followup-To: FreeBSD-gnats-submit@FreeBSD.org, ports@FreeBSD.org
References: <20030312143443.54532.qmail@outpost.globcon.net>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20030312143443.54532.qmail@outpost.globcon.net>
User-Agent: Mutt/1.5.3i
Subject: Re: ports/49961: [PATCH] Mega tree sweep for SITE_PERL usage
X-BeenThere: freebsd-ports@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: Porting software to FreeBSD <freebsd-ports.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-ports>,
	<mailto:freebsd-ports-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-ports>
List-Post: <mailto:freebsd-ports@freebsd.org>
List-Help: <mailto:freebsd-ports-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-ports>,
	<mailto:freebsd-ports-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 06 May 2003 12:09:01 -0000

On 2003-03-12 at 14:34 -0000, Sergei Kolobov wrote:
> This is a sweep through the ports tree looking for possible usage of SITE_PERL 
> in Makefile and pkg-plist:
> 
> -RUN_DEPENDS=           ${LOCALBASE}/lib/perl5/site_perl/${PERL_VER}/${PERL_ARCH}/Tk.pm:${PORTSDIR}/x11-toolkits/p5-T
> k
> +RUN_DEPENDS=           ${SITE_PERL}/${PERL_ARCH}/Tk.pm:${PORTSDIR}/x11-toolkits/p5-Tk
> 
> and
> 
> -lib/perl5/site_perl/%%PERL_VER%%/X11/Protocol/Connection/UNIXSocket.pm
> +%%SITE_PERL%%/X11/Protocol/Connection/UNIXSocket.pm
> 
> IMHO, Makefiles and pkg-plists are much more readable and maintainable this way.
> 
> Note: there are some edge cases - when a variable was defined for the same purpose 
> as SITE_PERL, but with a different name (e.g. PERL_SITELIBDIR, etc.). 
> My script did not handle those case yet.
> >How-To-Repeat:
> >Fix:
> The patches are available at the following URL:
> 
> http://www.kolobov.com/site_perl.patches.tar.gz
> 
> The tarball contains a collection of patch files, each file corresponds to a separate ports category.


I have created the patched almost 2 months ago and they are getting
stale already.

Can I ask a committer with some interest in Perl to take a look at them, please?

Thanks.