From owner-freebsd-bugs@FreeBSD.ORG Sun Dec 27 10:30:03 2009 Return-Path: Delivered-To: freebsd-bugs@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 9FBBE1065679 for ; Sun, 27 Dec 2009 10:30:03 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id 634CC8FC1B for ; Sun, 27 Dec 2009 10:30:03 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.3/8.14.3) with ESMTP id nBRAU3ck091630 for ; Sun, 27 Dec 2009 10:30:03 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.3/8.14.3/Submit) id nBRAU31q091626; Sun, 27 Dec 2009 10:30:03 GMT (envelope-from gnats) Resent-Date: Sun, 27 Dec 2009 10:30:03 GMT Resent-Message-Id: <200912271030.nBRAU31q091626@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, Henning Petersen Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id CF5261065672 for ; Sun, 27 Dec 2009 10:21:58 +0000 (UTC) (envelope-from nobody@FreeBSD.org) Received: from www.freebsd.org (www.freebsd.org [IPv6:2001:4f8:fff6::21]) by mx1.freebsd.org (Postfix) with ESMTP id BEF7C8FC0A for ; Sun, 27 Dec 2009 10:21:58 +0000 (UTC) Received: from www.freebsd.org (localhost [127.0.0.1]) by www.freebsd.org (8.14.3/8.14.3) with ESMTP id nBRALw3q091628 for ; Sun, 27 Dec 2009 10:21:58 GMT (envelope-from nobody@www.freebsd.org) Received: (from nobody@localhost) by www.freebsd.org (8.14.3/8.14.3/Submit) id nBRALwWq091627; Sun, 27 Dec 2009 10:21:58 GMT (envelope-from nobody) Message-Id: <200912271021.nBRALwWq091627@www.freebsd.org> Date: Sun, 27 Dec 2009 10:21:58 GMT From: Henning Petersen To: freebsd-gnats-submit@FreeBSD.org X-Send-Pr-Version: www-3.1 Cc: Subject: kern/142066: Missing parenthesis in sys/netinet/sctp_pcb.c . X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 27 Dec 2009 10:30:03 -0000 >Number: 142066 >Category: kern >Synopsis: Missing parenthesis in sys/netinet/sctp_pcb.c . >Confidential: no >Severity: serious >Priority: medium >Responsible: freebsd-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: sw-bug >Submitter-Id: current-users >Arrival-Date: Sun Dec 27 10:30:03 UTC 2009 >Closed-Date: >Last-Modified: >Originator: Henning Petersen >Release: Freebsd-current >Organization: >Environment: >Description: Missplaced parenthesis found with cppcheck. >How-To-Repeat: >Fix: diff -u -r1.94 sctp_pcb.c --- sys/netinet/sctp_pcb.c 17 Nov 2009 20:56:14 -0000 1.94 +++ sys/netinet/sctp_pcb.c 27 Dec 2009 10:11:48 -0000 @@ -6385,7 +6385,7 @@ } skip_vtag_check: - chain = &SCTP_BASE_INFO(vtag_timewait[(tag % SCTP_STACK_VTAG_HASH_SIZE))]; + chain = &SCTP_BASE_INFO(vtag_timewait)[(tag % SCTP_STACK_VTAG_HASH_SIZE)]; /* Now what about timed wait ? */ if (!LIST_EMPTY(chain)) { /* Patch attached with submission follows: Index: sys/netinet/sctp_pcb.c =================================================================== RCS file: /usr/ncvs/src/sys/netinet/sctp_pcb.c,v retrieving revision 1.94 diff -u -r1.94 sctp_pcb.c --- sys/netinet/sctp_pcb.c 17 Nov 2009 20:56:14 -0000 1.94 +++ sys/netinet/sctp_pcb.c 27 Dec 2009 10:11:48 -0000 @@ -6385,7 +6385,7 @@ } skip_vtag_check: - chain = &SCTP_BASE_INFO(vtag_timewait[(tag % SCTP_STACK_VTAG_HASH_SIZE))]; + chain = &SCTP_BASE_INFO(vtag_timewait)[(tag % SCTP_STACK_VTAG_HASH_SIZE)]; /* Now what about timed wait ? */ if (!LIST_EMPTY(chain)) { /* >Release-Note: >Audit-Trail: >Unformatted: