From owner-freebsd-stable@FreeBSD.ORG Tue Aug 12 06:51:22 2003 Return-Path: Delivered-To: freebsd-stable@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id BB35F37B401 for ; Tue, 12 Aug 2003 06:51:22 -0700 (PDT) Received: from cadillac.meteo.fr (cadillac.meteo.fr [137.129.1.4]) by mx1.FreeBSD.org (Postfix) with ESMTP id 34A5043FB1 for ; Tue, 12 Aug 2003 06:51:21 -0700 (PDT) (envelope-from igor.pokrovsky@cnrm.meteo.fr) Received: from cti825.cnrm.meteo.fr (localhost.meteo.fr [127.0.0.1]) NAA26621 for ; Tue, 12 Aug 2003 13:51:13 GMT Received: from xdata.cnrm.meteo.fr (xdata.cnrm.meteo.fr [137.129.150.2]) PAA16462; Tue, 12 Aug 2003 15:51:10 +0200 (METDST) Received: from exmatis1.cnrm.meteo.fr (exmatis1.cnrm.meteo.fr [137.129.157.46]) by xdata.cnrm.meteo.fr with ESMTP (8.9.3 (PHNE_24419)/8.7.1) id PAA26199; Tue, 12 Aug 2003 15:51:40 +0200 (METDST) Received: from exmatis1.cnrm.meteo.fr (localhost [127.0.0.1]) h7CDkZJr003843; Tue, 12 Aug 2003 15:46:35 +0200 (CEST) (envelope-from pokrovsi@exmatis1.cnrm.meteo.fr) Received: (from pokrovsi@localhost) by exmatis1.cnrm.meteo.fr (8.12.9/8.12.9/Submit) id h7CDkYaJ003842; Tue, 12 Aug 2003 15:46:34 +0200 (CEST) Date: Tue, 12 Aug 2003 15:46:34 +0200 From: Igor Pokrovsky To: Don Bowman Message-ID: <20030812134634.GA3783@exmatis1.cnrm.meteo.fr> Mail-Followup-To: Igor Pokrovsky , Don Bowman , Stijn Hoop , freebsd-stable@freebsd.org References: Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.4.1i X-Accept-Language: ru X-AntiVirus: scanned for viruses by AMaViS 0.2.1 (cti825/CNRM) Organization: METEO FRANCE(CNRM) cc: freebsd-stable@freebsd.org Subject: Re: support of SMBus on ICH3 X-BeenThere: freebsd-stable@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list Reply-To: Igor Pokrovsky List-Id: Production branch of FreeBSD source code List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 12 Aug 2003 13:51:23 -0000 On Tue, Aug 12, 2003 at 09:40:50AM -0400, Don Bowman wrote: Thank you Don! > ... ich3 smbus not showing up in pciconf output ... > > see p297 of ICH3 datasheet [intel pn 290733-002], FUNC_DIS register. > > pciconf -r -h 0:31:0 > > shows the value. > clear bit '3'. > > bit 0 should be either set or cleared :) I suspect it should be clear. > > this datasheet is on intel's website. # pciconf -r -h 0:31:0 00 0x00008086 # pciconf -r -h 0:31:0 02 0x0000248c What about the following patch: Index: ichsmb_pci.c =================================================================== RCS file: /home/src/CVS/FreeBSD/src/sys/dev/ichsmb/ichsmb_pci.c,v retrieving revision 1.1.2.3 diff -u -r1.1.2.3 ichsmb_pci.c --- ichsmb_pci.c 20 Oct 2002 14:57:19 -0000 1.1.2.3 +++ ichsmb_pci.c 12 Aug 2003 13:44:48 -0000 @@ -68,6 +68,7 @@ #define ID_82801AB 0x24238086 #define ID_82801BA 0x24438086 #define ID_82801CA 0x24838086 +#define ID_82801CA_M 0x248C8086 #define PCIS_SERIALBUS_SMBUS_PROGIF 0x00 @@ -125,6 +126,9 @@ break; case ID_82801CA: device_set_desc(dev, "Intel 82801CA (ICH3) SMBus controller"); + break; + case ID_82801CA_M: + device_set_desc(dev, "Intel 82801CA (ICH3-M) SMBus controller"); break; default: if (pci_get_class(dev) == PCIC_SERIALBUS -ip -- FORTUNE'S PARTY TIPS #14 Tired of finding that other people are helping themselves to your good liquor at BYOB parties? Take along a candle, which you insert and light after you've opened the bottle. No one ever expects anything drinkable to be in a bottle which has a candle stuck in its neck.