Date: Thu, 12 Mar 2015 01:16:47 +0100 From: Kristof Provost <kristof@sigsegv.be> To: "Andrey V. Elsukov" <bu7cher@yandex.ru> Cc: freebsd-net@FreeBSD.org, freebsd-pf@FreeBSD.org Subject: Re: [PATCH] Fix panic with pf fastroute Message-ID: <20150312001647.GS1975@vega.codepro.be> In-Reply-To: <20150311125050.GR1975@vega.codepro.be> References: <1426064691-1238-1-git-send-email-kristof@sigsegv.be> <20150311083916.GQ1975@vega.codepro.be> <55000FDF.10007@yandex.ru> <20150311125050.GR1975@vega.codepro.be>
next in thread | previous in thread | raw e-mail | index | archive | help
On 2015-03-11 13:50:50 (+0100), Kristof Provost <kristof@sigsegv.be> wrote: > On 2015-03-11 12:50:23 (+0300), Andrey V. Elsukov <bu7cher@yandex.ru> wrote: > > It looks like there are some code paths that do a copy of original mbuf. > > Are you sure this doesn't introduce mbuf leak? > > > I'll check again in the morning when I'm less drunk and jet lagged, but > I'm pretty confident this is correct. > There are only two exit points from pf_route6(), this one only happens > in case of FASTROUTE, not DUPTO (which is the one that duplicates). > So, yes, the duplication is only done if r->rt == PF_DUPTO and the case I fixed is r->rt == PF_FASTROUTE. Regards, Kristof
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20150312001647.GS1975>