Date: Thu, 23 Mar 2006 14:29:12 +0100 (CET) From: "Frank W. Josellis" <frank@dynamical-systems.org> To: Thierry Thomas <thierry@FreeBSD.org> Cc: freebsd-ports-bugs@FreeBSD.org Subject: Re: ports/93972: Update port: astro/xmoontool to 3.0.3 Message-ID: <20060323133612.J6641@pollux.senax.net> In-Reply-To: <200603222154.k2MLsUZJ038943@freefall.freebsd.org> References: <200603222154.k2MLsUZJ038943@freefall.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Wed, 22 Mar 2006, Thierry Thomas wrote: > This port does not respect CFLAGS, CC nor PREFIX; what about the > following patch? (Since I'm there, reorganize Makefile) You are right, but please note that patching PREFIX into the tarball's Makefile has no effect on the port. It's only the install target that involves PREFIX. This isn't used, as the port's installation is solely carried out by do-install in the port's Makefile. Well, I considered the tarball's CC and CFLAGS settings as acceptable for the port and couldn't imagine a situation where it is essential to have them overwritten. But I suppose you are more acquainted with the formal requirements on FreeBSD ports, so I better leave it to you. If you feel it's an advantage which justifies the patch, I won't protest. I wasn't yet aware that USE_REINPLACE meanwhile became obsolete, but I'll know in future. Thanks! Frank Josellis
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20060323133612.J6641>