Date: Fri, 19 Dec 2003 12:06:47 -0500 From: Joe Marcus Clarke <marcus@marcuscom.com> To: Rolf Grossmann <rg@progtech.net> Cc: FreeBSD GNOME Users <gnome@freebsd.org> Subject: Re: Suggested simplification for bsd.gnome.mk Message-ID: <1071853607.762.6.camel@gyros> In-Reply-To: <200312191537.hBJFbwx00597@isis.muc.progtech.intern> References: <200312191537.hBJFbwx00597@isis.muc.progtech.intern>
next in thread | previous in thread | raw e-mail | index | archive | help
--=-I1SqXxIEgucHnLwKPvKB
Content-Type: text/plain
Content-Transfer-Encoding: quoted-printable
On Fri, 2003-12-19 at 10:37, Rolf Grossmann wrote:
> Hi,
>=20
> I'm wondering if you'd be willing to commit a small change to bsd.gnome.m=
k
> that uses the *_DETECT variables for the test argument in *_RUN_DEPENDS,
> see appended patch. It includes one change for libgailgnome_DETECT to
> test the lib instead of the .pc file, taken from the dependency.
>=20
> The changes makes it easier for me to install the whole of gnome in
> a location other than the default and reduces data duplication by using
> the variables.
>=20
> On a side note, while looking over the bsd.gnome.mk, I also noticed what
> looks to be a typo: You're using
>=20
> > libartlgpl1_USE_GNOME_IMPL=3D pkgconfig
>=20
> where I think it should be libartlgpl2_USE_GNOME_IMPL like the rest of th=
e
> variables. I guess nobody would notice since everyone will have pkgconfig
> at that point.
This patch looks good to me. Thanks!
Joe
>=20
> Please let me know what you think.
>=20
> Thanks, Rolf
>=20
> --- bsd.gnome.mk Wed Nov 12 05:11:09 2003
> +++ bsd.gnome.mk.rg Fri Dec 19 16:21:37 2003
> @@ -54,8 +54,8 @@
> s|DATADIRNAME=3Dlib|DATADIRNAME=3Dshare|g'
> =20
>=20
> -gnomehier_RUN_DEPENDS=3D ${X11BASE}/share/gnome/.keep_me:${PORTSDIR}/mis=
c/gnomehier
> gnomehier_DETECT=3D ${X11BASE}/share/gnome/.keep_me
> +gnomehier_RUN_DEPENDS=3D ${gnomehier_DETECT}:${PORTSDIR}/misc/gnomehier
> =20
> GNOME_HTML_DIR?=3D ${PREFIX}/share/doc
> gnomeprefix_CONFIGURE_ENV=3DGTKDOC=3D"false"
> @@ -68,8 +68,8 @@
> =20
> gnometarget_CONFIGURE_TARGET=3D--build=3D${MACHINE_ARCH}-portbld-freebsd=
${OSREL}
> =20
> -gnomeaudio_RUN_DEPENDS=3D ${X11BASE}/share/gnome/sounds/login.wav:${PORT=
SDIR}/audio/gnomeaudio
> gnomeaudio_DETECT=3D ${X11BASE}/share/gnome/sounds/login.wav
> +gnomeaudio_RUN_DEPENDS=3D ${gnomeaudio_DETECT}:${PORTSDIR}/audio/gnomeau=
dio
> =20
> ESD_CONFIG?=3D ${LOCALBASE}/bin/esd-config
> esound_LIB_DEPENDS=3D esd.2:${PORTSDIR}/audio/esound
> @@ -140,9 +140,9 @@
> oaf_DETECT=3D ${OAF_CONFIG}
> oaf_USE_GNOME_IMPL=3D glib12 orbit libxml
> =20
> -gnomemimedata_BUILD_DEPENDS=3D${X11BASE}/libdata/pkgconfig/gnome-mime-da=
ta-2.0.pc:${PORTSDIR}/misc/gnomemimedata
> -gnomemimedata_RUN_DEPENDS=3D${X11BASE}/libdata/pkgconfig/gnome-mime-data=
-2.0.pc:${PORTSDIR}/misc/gnomemimedata
> gnomemimedata_DETECT=3D ${X11BASE}/libdata/pkgconfig/gnome-mime-data-2.0=
.pc
> +gnomemimedata_BUILD_DEPENDS=3D${gnomemimedata_DETECT}:${PORTSDIR}/misc/g=
nomemimedata
> +gnomemimedata_RUN_DEPENDS=3D${gnomemimedata_DETECT}:${PORTSDIR}/misc/gno=
memimedata
> gnomemimedata_USE_GNOME_IMPL=3Dgnomehier pkgconfig
> =20
> GCONF_CONFIG?=3D ${X11BASE}/bin/gconf-config
> @@ -292,8 +292,8 @@
> atspi_DETECT=3D ${X11BASE}/libdata/pkgconfig/cspi-1.0.pc
> atspi_USE_GNOME_IMPL=3D gail libbonobo
> =20
> -libgailgnome_RUN_DEPENDS=3D ${X11BASE}/lib/gtk-2.0/modules/libgail-gnome=
.so:${PORTSDIR}/x11-toolkits/libgail-gnome
> -libgailgnome_DETECT=3D ${X11BASE}/libdata/pkgconfig/libgail-gnome.pc
> +libgailgnome_DETECT=3D ${X11BASE}/lib/gtk-2.0/modules/libgail-gnome.so
> +libgailgnome_RUN_DEPENDS=3D ${libgailgnome_DETECT}:${PORTSDIR}/x11-toolk=
its/libgail-gnome
> libgailgnome_USE_GNOME_IMPL=3D libgnomeui atspi
> =20
> libgtkhtml_LIB_DEPENDS=3D gtkhtml-2.0:${PORTSDIR}/www/libgtkhtml
> _______________________________________________
> freebsd-gnome@freebsd.org mailing list
> http://lists.freebsd.org/mailman/listinfo/freebsd-gnome
> To unsubscribe, send any mail to "freebsd-gnome-unsubscribe@freebsd.org"
--=20
PGP Key : http://www.marcuscom.com/pgp.asc
--=-I1SqXxIEgucHnLwKPvKB
Content-Type: application/pgp-signature; name=signature.asc
Content-Description: This is a digitally signed message part
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.3 (FreeBSD)
iD8DBQA/4zAnb2iPiv4Uz4cRAiJMAJ9PXfKEw5wWKT92LwMAFxCgz0g/OQCgkvhV
u7E5yNPg67ZuAhXAkg9qM8s=
=umef
-----END PGP SIGNATURE-----
--=-I1SqXxIEgucHnLwKPvKB--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?1071853607.762.6.camel>