From owner-freebsd-current  Wed Dec 19 11:17:14 2001
Delivered-To: freebsd-current@freebsd.org
Received: from mail11.speakeasy.net (mail11.speakeasy.net [216.254.0.211])
	by hub.freebsd.org (Postfix) with ESMTP id 4417337B417
	for <freebsd-current@FreeBSD.org>; Wed, 19 Dec 2001 11:17:07 -0800 (PST)
Received: (qmail 5714 invoked from network); 19 Dec 2001 19:17:04 -0000
Received: from unknown (HELO laptop.baldwin.cx) ([64.81.54.73]) (envelope-sender <jhb@FreeBSD.org>)
          by mail11.speakeasy.net (qmail-ldap-1.03) with SMTP
          for <dillon@apollo.backplane.com>; 19 Dec 2001 19:17:04 -0000
Message-ID: <XFMail.011219111641.jhb@FreeBSD.org>
X-Mailer: XFMail 1.4.0 on FreeBSD
X-Priority: 3 (Normal)
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
In-Reply-To: <200112191913.fBJJDBu90110@apollo.backplane.com>
Date: Wed, 19 Dec 2001 11:16:41 -0800 (PST)
From: John Baldwin <jhb@FreeBSD.org>
To: Matthew Dillon <dillon@apollo.backplane.com>
Subject: Re: cvs commit: src/sys/kern vfs_subr.c vfs_vnops.c src/sys/sys
Cc: Josef Karthauser <joe@tao.org.uk>, freebsd-current@FreeBSD.org
Sender: owner-freebsd-current@FreeBSD.ORG
Precedence: bulk
List-ID: <freebsd-current.FreeBSD.ORG>
List-Archive: <http://docs.freebsd.org/mail/> (Web Archive)
List-Help: <mailto:majordomo@FreeBSD.ORG?subject=help> (List Instructions)
List-Subscribe: <mailto:majordomo@FreeBSD.ORG?subject=subscribe%20freebsd-current>
List-Unsubscribe: <mailto:majordomo@FreeBSD.ORG?subject=unsubscribe%20freebsd-current>
X-Loop: FreeBSD.ORG


On 19-Dec-01 Matthew Dillon wrote:
>:>     The structure is being bzero()'d before its dynamic flag gets checked.
>:>     I've included a patch below.  Josef, I would appreciate it if you would
>:>     apply the patch and try your system with the various procfs devices
>:>     mounted again.  It's an obvious bug so I'm comitting it to -current
>:>     now,
>:>     the question is:  Is it the *only* bug?
>:> 
>:>                                               -Matt
>:
>:Hmm, why bzero at all if you are just going to free it?  Why not move the
>:bzero
>:to an else after the ISDYNSTRUCT check?  (Not that this is really all that
>:important, but... :)
>:
>:-- 
>:
>:John Baldwin <jhb@FreeBSD.org>  <><  http://www.FreeBSD.org/~jhb/
> 
>     He is invalidating the structure to catch references to deleted sbufs.
>     (see assert_sbuf_integrity() calls).

Fair enough.  In theory an INVARIANTS kernel with 0xdeadc0de should do that for
you though. :)

-- 

John Baldwin <jhb@FreeBSD.org>  <><  http://www.FreeBSD.org/~jhb/
"Power Users Use the Power to Serve!"  -  http://www.FreeBSD.org/

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-current" in the body of the message