Date: Thu, 08 Jun 1995 20:33:23 -0700 From: David Greenman <davidg@Root.COM> To: Matt Dillon <dillon@best.com>, bugs@FreeBSD.org Subject: Re: connect() bug found and fixed (uninitialized pointer) Message-ID: <199506090333.UAA00143@corbin.Root.COM> In-Reply-To: Your message of "Thu, 08 Jun 95 19:56:32 PDT." <199506090256.TAA00249@corbin.Root.COM>
next in thread | previous in thread | raw e-mail | index | archive | help
>> In case Dima didn't get this off to you, there's a bug in >> netinet/tcp_usrreq.c: tcp_connect()... the ifaddr is left >> uninitialized in the case where in_pcbladdr() fails. The fix >> is to check the error code from in_pcbladdr() and to return >> it rather then fall through to the remaining code if it comes >> back non-zero. >> >> I stuck a printf() in there to catch the condition as well just to >> see how often it occured... got about a hit every 10 minutes >> on our (very busy) FTP/WWW server from ftpd. > > Interesting...I'll have a look. Want to send me a diff for how you think it >should be fixed? Nevermind; it took all of about 2 seconds to see the obvious problem. It then took me a few minutes to determine if the problem would manifest itself. I think it would under some circumstances (resulting in a panic or weird behavior). The fix has been committed to CVS; thanks. -DG
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?199506090333.UAA00143>