From owner-freebsd-ppc@FreeBSD.ORG  Fri Apr 11 08:17:45 2003
Return-Path: <owner-freebsd-ppc@FreeBSD.ORG>
Delivered-To: freebsd-ppc@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 8213A37B401
	for <freebsd-ppc@freebsd.org>; Fri, 11 Apr 2003 08:17:45 -0700 (PDT)
Received: from bothawui.bothan.net (bothawui.bothan.net [66.92.184.160])
	by mx1.FreeBSD.org (Postfix) with SMTP id E8A2043FD7
	for <freebsd-ppc@freebsd.org>; Fri, 11 Apr 2003 08:17:42 -0700 (PDT)
	(envelope-from jtl@bothan.net)
Received: (qmail 1514 invoked from network); 11 Apr 2003 15:17:41 -0000
Received: from unknown (HELO bothan.net) (127.0.0.1)
  by localhost with SMTP; 11 Apr 2003 15:17:41 -0000
Date: Fri, 11 Apr 2003 17:18:22 +0200
X-Image-Url: jtl@bothan.net
Mime-Version: 1.0 (Apple Message framework v552)
Content-Type: text/plain; charset=US-ASCII; format=flowed
From: Joshua LeVasseur <jtl@bothan.net>
To: freebsd-ppc@freebsd.org
Content-Transfer-Encoding: 7bit
Message-Id: <D58FA9D4-6C30-11D7-A2D0-000393DB44E8@bothan.net>
X-Mailer: Apple Mail (2.552)
Subject: some psim bugs
X-BeenThere: freebsd-ppc@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: Porting FreeBSD to the PowerPC <freebsd-ppc.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-ppc>,
	<mailto:freebsd-ppc-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-ppc>
List-Post: <mailto:freebsd-ppc@freebsd.org>
List-Help: <mailto:freebsd-ppc-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-ppc>,
	<mailto:freebsd-ppc-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 11 Apr 2003 15:17:45 -0000


In case any of you still use psim, I uncovered two more bugs (sorry if 
these are repeats) ...

The first concerns the allocation of Open Firmware's htab.  The bug 
exposes itself when you simulate with lots of memory, causing psim to 
complain that the htab location is incompatible with the htabmask.  The 
code calculates an incorrect htabmask.  In file gdb/sim/ppc/hw_htab.c, 
function htab_decode_hash_table(), look for:

     if ((htab_ra & INSERTED32(*htabmask, 7, 15)) != 0) {
         device_error(parent, "htaborg 0x%lx not aligned to htabmask 
0x%lx",
                 (unsigned long)*htaborg, (unsigned long)*htabmask);
     }

And change to:

     if ((htab_ra & (htab_nr_bytes-1)) != 0) {
         device_error(parent, "htaborg 0x%lx not aligned to htabmask 
0x%lx",
                 (unsigned long)*htaborg, (unsigned long)*htabmask);
     }

After fixing this problem, it is no longer necessary to manually 
configure OpenFirmware's layout in memory.


The second bug also concerns the emulated Open Firmware.  The client 
interface function "nextprop" never returns the first property.  In the 
file gdb/sim/ppc/emul_chirp.c, in chirp_emul_nextprop(), look for the 
statement:

     next_prop = device_next_property(prev_prop);

And change to:

     if( *previous == '\0' )
         next_prop = prev_prop;        /* Return the first property! */
     else
         next_prop = device_next_property(prev_prop);


-Josh