From owner-svn-src-all@freebsd.org Fri Nov 13 21:20:43 2015 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id AFA66A2ECFA for ; Fri, 13 Nov 2015 21:20:43 +0000 (UTC) (envelope-from rrs@netflix.com) Received: from mail-pa0-x231.google.com (mail-pa0-x231.google.com [IPv6:2607:f8b0:400e:c03::231]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 75DE31FFD for ; Fri, 13 Nov 2015 21:20:43 +0000 (UTC) (envelope-from rrs@netflix.com) Received: by padhx2 with SMTP id hx2so111132832pad.1 for ; Fri, 13 Nov 2015 13:20:43 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=netflix.com; s=google; h=content-type:mime-version:subject:from:in-reply-to:date:cc :message-id:references:to; bh=PK7y+xNEps/hIQJxKOL34psrsRCnvZhFVjjNaWHN+h4=; b=DUtbDh93lG4Pt4THxU7M9Qjp9YPOBrZXeXgCocNkE/0ThpIHQRTTlWaaXr+CFvF9nm Rx2epqwzXHxd5FLItX0WILXgHy+p6vW9L7z4mum1Mc64hWYC1gHQj2/csR/9P0zSkUar rMjPwEpc5UUX/EXNGC9Is8+GYZpQoDerO9HB8= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:content-type:mime-version:subject:from :in-reply-to:date:cc:message-id:references:to; bh=PK7y+xNEps/hIQJxKOL34psrsRCnvZhFVjjNaWHN+h4=; b=HspPJ6QU+BLyefX6oXj+ULxL8/ikz7Cc8oC+XwAyuUCB3+KmMuwyVlE7zBbC+ZLeGz GPY8dCVMUYj+Qvlxz3zahYo6o/C6dgansyFWjzR8oTt9PLm7Hlh1FvyPcQkrewWXqbpa k1WG4DzH4CvjhUZ+CfaWrBEisBHcV97SOfC16hv7goB7BZciybmYTBm+47xpAVjt+ke/ 9pR+dHA9zTRYLkgInNYBigprdleFBf8N4X5Nbqf+1MLHYXpBzsDf+dANuoGCE8IS3RRW iQLNCG/mVm7HcCuElLf8LbTwwWzJR/3DerA5dZ57oodgTkX6xOrdzrYJfbCGMm1nseHk Uy5g== X-Gm-Message-State: ALoCoQmHojUT50IfSFI62mhZDQal6m0lgXoeT5k6ZYcBnZESj7WBeuTCV0bniVcge0WjvNCjY7zj X-Received: by 10.66.234.8 with SMTP id ua8mr6294212pac.45.1447449642823; Fri, 13 Nov 2015 13:20:42 -0800 (PST) Received: from ip-192-168-70-10.us-west-2.compute.internal ([69.53.245.107]) by smtp.gmail.com with ESMTPSA id ur1sm6420325pbc.44.2015.11.13.13.20.38 (version=TLS1 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Fri, 13 Nov 2015 13:20:42 -0800 (PST) Mime-Version: 1.0 (Mac OS X Mail 7.3 \(1878.6\)) Subject: Re: svn commit: r290664 - in head: share/man/man9 sys/kern sys/sys From: Randall Stewart In-Reply-To: <56465003.8070709@FreeBSD.org> Date: Fri, 13 Nov 2015 16:20:45 -0500 Cc: "Alexander V. Chernikov" , "src-committers@freebsd.org" , "svn-src-all@freebsd.org" , "svn-src-head@freebsd.org" , Adrian Chadd , imp@freebsd.org Message-Id: <4A4A2115-6392-487A-BEBE-499A68689D4A@netflix.com> References: <201511101449.tAAEnXIi065747@repo.freebsd.org> <1660421447413365@web19h.yandex.ru> <56464A90.2040405@FreeBSD.org> <56464CBA.7060206@FreeBSD.org> <56465003.8070709@FreeBSD.org> To: Bryan Drewery X-Mailer: Apple Mail (2.1878.6) Content-Type: text/plain; charset=windows-1251 Content-Transfer-Encoding: quoted-printable X-Content-Filtered-By: Mailman/MimeDel 2.1.20 X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 13 Nov 2015 21:20:43 -0000 No alexander=92s panic=92s are because the LLREF is done if (callout_stop()) But now if it was not running -1 is returned.. Try the patch I just sent.. R On Nov 13, 2015, at 4:02 PM, Bryan Drewery wrote: > On 11/13/2015 1:00 PM, Randall Stewart wrote: >> Bryan: >>=20 >> This looks like a decent thing to do.. >>=20 >> Still wondering why changing the callout.h header file would not have = caused >> things to recompile to pick up the new argument.. >>=20 >> We can do it this way though it looks fine. >>=20 >> You want to commit it or I? >=20 > Well your change is totally safe for compiling. It's just not KBI > backwards compat for older modules. This is not typically a problem = but > I think in this case it is worth doing to avoid random data coming = into > the 'drain' argument if loading an older module. >=20 > I'll do a test build and commit it. Perhaps this is what was leading = to > Alexander's panics. >=20 > I haven't analyzed the return value issue at all. >=20 >=20 > --=20 > Regards, > Bryan Drewery >=20 -------- Randall Stewart rrs@netflix.com 803-317-4952