From owner-freebsd-net@FreeBSD.ORG  Thu Mar  2 14:03:24 2006
Return-Path: <owner-freebsd-net@FreeBSD.ORG>
X-Original-To: freebsd-net@freebsd.org
Delivered-To: freebsd-net@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 2B31716A420;
	Thu,  2 Mar 2006 14:03:24 +0000 (GMT)
	(envelope-from damien.bergamini@free.fr)
Received: from smtp2-g19.free.fr (smtp2-g19.free.fr [212.27.42.28])
	by mx1.FreeBSD.org (Postfix) with ESMTP id A75D043D45;
	Thu,  2 Mar 2006 14:03:22 +0000 (GMT)
	(envelope-from damien.bergamini@free.fr)
Received: from imp7-g19.free.fr (imp7-g19.free.fr [212.27.42.38])
	by smtp2-g19.free.fr (Postfix) with ESMTP id 0E4856D1C2;
	Thu,  2 Mar 2006 15:03:20 +0100 (CET)
Received: by imp7-g19.free.fr (Postfix, from userid 33)
	id 10B1F5CB5; Thu,  2 Mar 2006 15:03:22 +0100 (CET)
Received: from proxy2-ibtnet.bull.fr (proxy2-ibtnet.bull.fr [129.185.75.10]) 
	by imp7-g19.free.fr (IMP) with HTTP 
	for <damien.bergamini@212.27.48.2>; Thu, 02 Mar 2006 15:03:21 +0100
Message-ID: <1141308201.4406fb29ec693@imp7-g19.free.fr>
Date: Thu, 02 Mar 2006 15:03:21 +0100
From: damien.bergamini@free.fr
To: Luigi Rizzo <rizzo@icir.org>
References: <20060301193342.GA11086@totem.fix.no>
	<20060301115655.A50285@xorpc.icir.org>
	<200603012150.44445.max@love2party.net>
	<20060301154342.A53213@xorpc.icir.org>
	<012501c63dcc$4671e590$0300a8c0@COMETE>
	<20060302024926.B61112@xorpc.icir.org>
	<009b01c63dec$9262ea10$0300a8c0@COMETE>
	<20060302052633.B63009@xorpc.icir.org>
In-Reply-To: <20060302052633.B63009@xorpc.icir.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 8bit
User-Agent: Internet Messaging Program (IMP) 3.2.5
X-Originating-IP: 129.185.75.10
Cc: Anders Nordby <anders@freebsd.org>, flz@freebsd.org,
	freebsd-net@freebsd.org, core@freebsd.org, sam@freebsd.org,
	damien@freebsd.org, Max Laier <max@love2party.net>
Subject: Re: iwi stability when doing large file transfers/backups
X-BeenThere: freebsd-net@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Networking and TCP/IP with FreeBSD <freebsd-net.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-net>,
	<mailto:freebsd-net-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-net>
List-Post: <mailto:freebsd-net@freebsd.org>
List-Help: <mailto:freebsd-net-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-net>,
	<mailto:freebsd-net-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 02 Mar 2006 14:03:24 -0000

The one who wrote that diff, whoever he is, obviously don't
understand C code.

Otherwise, why would he write such nonsense:

static uint32_t
iwi_toggle_event(uint32_t r)
{
	r &= ~IWI_RST_STANDBY;
	if (r & IWI_RST_GATE_ODMA)
		r &= ~IWI_RST_GATE_ODMA;
	if (r & IWI_RST_GATE_IDMA)
		r &= ~IWI_RST_GATE_IDMA;
	if (r & IWI_RST_GATE_ADMA)
		r &= ~IWI_RST_GATE_ADMA;
	return r;
}

when you could just write:

r &= ~(IWI_RST_STANDBY | IWI_RST_GATE_ODMA |
       IWI_RST_GATE_IDMA | IWI_RST_GATE_ADMA);

but he sure knows how to steel code from others and
violate the GPL by the way:

>From Linux ipw2200-1.1.0 (GPL):

static u32 ipw_register_toggle(u32 reg)
{
	reg &= ~IPW_START_STANDBY;
	if (reg & IPW_GATE_ODMA)
		reg &= ~IPW_GATE_ODMA;
	if (reg & IPW_GATE_IDMA)
		reg &= ~IPW_GATE_IDMA;
	if (reg & IPW_GATE_ADMA)
		reg &= ~IPW_GATE_ADMA;
	return reg;
}

...mmm very similar right?

Damien