From owner-freebsd-current  Mon Jan 24 10:36:46 2000
Delivered-To: freebsd-current@freebsd.org
Received: from rover.village.org (rover.village.org [204.144.255.49])
	by hub.freebsd.org (Postfix) with ESMTP id 2B50015036
	for <current@FreeBSD.ORG>; Mon, 24 Jan 2000 10:36:39 -0800 (PST)
	(envelope-from imp@harmony.village.org)
Received: from harmony.village.org (harmony.village.org [10.0.0.6])
	by rover.village.org (8.9.3/8.9.3) with ESMTP id LAA01905;
	Mon, 24 Jan 2000 11:36:36 -0700 (MST)
	(envelope-from imp@harmony.village.org)
Received: from harmony.village.org (localhost.village.org [127.0.0.1]) by harmony.village.org (8.9.3/8.8.3) with ESMTP id LAA04877; Mon, 24 Jan 2000 11:36:22 -0700 (MST)
Message-Id: <200001241836.LAA04877@harmony.village.org>
To: Nick Hibma <n_hibma@webweaving.org>
Subject: Re: APM still ignoring DEVICE_SUSPEND errors 
Cc: FreeBSD CURRENT Mailing List <current@FreeBSD.ORG>
In-reply-to: Your message of "Mon, 24 Jan 2000 13:30:54 GMT."
		<Pine.BSF.4.20.0001231408180.4623-200000@localhost> 
References: <Pine.BSF.4.20.0001231408180.4623-200000@localhost>  
Date: Mon, 24 Jan 2000 11:36:22 -0700
From: Warner Losh <imp@village.org>
Sender: owner-freebsd-current@FreeBSD.ORG
Precedence: bulk
X-Loop: FreeBSD.ORG

In message <Pine.BSF.4.20.0001231408180.4623-200000@localhost> Nick Hibma writes:
: The following patch fixes two things: First, DEVICE_SUSPEND errors are
: no longer ignored. Since we have defaults for methods we should no
: longer ignore these errors. Also, DEVICE_RESUME wasn't done when the
: apm_suspend_system event failed.

I had similar patches that workede several months ago, but they have
since been lost.

: Second, in the ordering of DEVICE_* and apm_hook_* is not symmetric for
: suspend and resume. The patch reverses the resume case as well to be
: 
: 	apm_hook_resume(...)
: 	DEVICE_RESUME(root)
: 
: Send me some feedback on this. I've mailed the people mentioned in the
: head of the file, but so far got no response. I would like to make sure
: we get this right when USB devices are used. Some of them don't suspend
: and the suspend should be refused in that case.

Any reason to not shoot the apm_hook_{suspend,resume} in the head and
just use newbus suspend/resume everywhere?

Warner


To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-current" in the body of the message