From owner-cvs-all@FreeBSD.ORG Fri Jan 14 18:09:41 2005 Return-Path: Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 42A0D16A4CE; Fri, 14 Jan 2005 18:09:41 +0000 (GMT) Received: from dragon.nuxi.com (trang.nuxi.com [66.93.134.19]) by mx1.FreeBSD.org (Postfix) with ESMTP id B86BF43D1D; Fri, 14 Jan 2005 18:09:40 +0000 (GMT) (envelope-from obrien@NUXI.com) Received: from dragon.nuxi.com (obrien@localhost [127.0.0.1]) by dragon.nuxi.com (8.13.1/8.13.1) with ESMTP id j0EI9dR4025293; Fri, 14 Jan 2005 10:09:39 -0800 (PST) (envelope-from obrien@dragon.nuxi.com) Received: (from obrien@localhost) by dragon.nuxi.com (8.13.1/8.13.1/Submit) id j0EI9doL025291; Fri, 14 Jan 2005 10:09:39 -0800 (PST) (envelope-from obrien) Date: Fri, 14 Jan 2005 10:09:39 -0800 From: "David O'Brien" To: Kris Kennaway Message-ID: <20050114180939.GB12260@dragon.nuxi.com> References: <200501140709.j0E79NTA046894@repoman.freebsd.org> <20050114131536.GA41709@xor.obsecurity.org> <20050114132433.GA97735@VARK.MIT.EDU> <20050114132829.GA42958@xor.obsecurity.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20050114132829.GA42958@xor.obsecurity.org> User-Agent: Mutt/1.4.1i X-Operating-System: FreeBSD 6.0-CURRENT Organization: The NUXI BSD Group X-Pgp-Rsa-Fingerprint: B7 4D 3E E9 11 39 5F A3 90 76 5D 69 58 D9 98 7A X-Pgp-Rsa-Keyid: 1024/34F9F9D5 cc: cvs-src@FreeBSD.ORG cc: src-committers@FreeBSD.ORG cc: freebsd-amd64@FreeBSD.ORG cc: cvs-all@FreeBSD.ORG Subject: Re: cvs commit: src/lib/msun/alpha fenv.h src/lib/msun/amd64 fenv.h src/lib/msun/arm fenv.h src/lib/msun/i387 fenv.h src/lib/msun/ia64 fenv.h src/lib/msun/powerpc fenv.h src/lib/msun/sparc64 fenv.h X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list Reply-To: freebsd-amd64@FreeBSD.ORG List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 14 Jan 2005 18:09:41 -0000 On Fri, Jan 14, 2005 at 05:28:29AM -0800, Kris Kennaway wrote: > On Fri, Jan 14, 2005 at 08:24:33AM -0500, David Schultz wrote: > > On Fri, Jan 14, 2005, Kris Kennaway wrote: > > > On Fri, Jan 14, 2005 at 07:09:23AM +0000, David Schultz wrote: > > > > das 2005-01-14 07:09:23 UTC ... > > > > Log: > > > > Mark all inline asms that read the floating-point control or status > > > > registers as volatile. Instructions that *wrote* to FP state were > > > > already marked volatile, but apparently gcc has license to move > > > > non-volatile asms past volatile asms. This broke amd64's feupdateenv > > > > at -O2 due to a WAR conflict between fnstsw and fldenv there. > > > > > > Do you think this is likely to the cause of the build failures > > > reported with a number of ports when world is compiled with -O2 > > > (i.e. does the feupdateenv failure cascade to other commonly-used > > > parts of the code)? > > > > No, this would lead to a runtime failure, and I would be surprised > > if very many ports use fenv.h anyway. > > OK :-( > > Someone needs to revert amd64 back to using -O in the meantime, then. I can't tell if you're talking about a need to move back to -O is for /usr/ports or /usr/src? If for /usr/ports, we should just change ports/Mk/bsd.port.mk to s/-O2/-O/ on AMD64? If we move back to -O in /usr/src we'll never get all the issues found and ironed out. -- -- David (obrien@FreeBSD.org)