From owner-freebsd-scsi@FreeBSD.ORG  Mon Oct 26 09:20:05 2009
Return-Path: <owner-freebsd-scsi@FreeBSD.ORG>
Delivered-To: freebsd-scsi@hub.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id B5F4B106566C
	for <freebsd-scsi@hub.freebsd.org>;
	Mon, 26 Oct 2009 09:20:05 +0000 (UTC)
	(envelope-from gnats@FreeBSD.org)
Received: from freefall.freebsd.org (freefall.freebsd.org
	[IPv6:2001:4f8:fff6::28])
	by mx1.freebsd.org (Postfix) with ESMTP id A4CB18FC08
	for <freebsd-scsi@hub.freebsd.org>;
	Mon, 26 Oct 2009 09:20:05 +0000 (UTC)
Received: from freefall.freebsd.org (localhost [127.0.0.1])
	by freefall.freebsd.org (8.14.3/8.14.3) with ESMTP id n9Q9K5nm048431
	for <freebsd-scsi@freefall.freebsd.org>; Mon, 26 Oct 2009 09:20:05 GMT
	(envelope-from gnats@freefall.freebsd.org)
Received: (from gnats@localhost)
	by freefall.freebsd.org (8.14.3/8.14.3/Submit) id n9Q9K5uR048430;
	Mon, 26 Oct 2009 09:20:05 GMT (envelope-from gnats)
Date: Mon, 26 Oct 2009 09:20:05 GMT
Message-Id: <200910260920.n9Q9K5uR048430@freefall.freebsd.org>
To: freebsd-scsi@FreeBSD.org
From: Jaakko Heinonen <jh@FreeBSD.org>
Cc: 
Subject: Re: kern/130735: [patch] pass M_NOWAIT to the malloc() call inside
	cdreaddvdstructure()
X-BeenThere: freebsd-scsi@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
Reply-To: Jaakko Heinonen <jh@FreeBSD.org>
List-Id: SCSI subsystem <freebsd-scsi.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-scsi>,
	<mailto:freebsd-scsi-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-scsi>
List-Post: <mailto:freebsd-scsi@freebsd.org>
List-Help: <mailto:freebsd-scsi-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-scsi>,
	<mailto:freebsd-scsi-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 26 Oct 2009 09:20:05 -0000

The following reply was made to PR kern/130735; it has been noted by GNATS.

From: Jaakko Heinonen <jh@FreeBSD.org>
To: Eygene Ryabinkin <rea-fbsd@codelabs.ru>
Cc: bug-followup@FreeBSD.org
Subject: Re: kern/130735: [patch] pass M_NOWAIT to the malloc() call inside
	cdreaddvdstructure()
Date: Mon, 26 Oct 2009 11:19:20 +0200

 Hi,
 
 On 2009-10-24, Eygene Ryabinkin wrote:
 >  I am feeling myself lucky today -- may be someone will be able
 >  to look at this PR and fix the bad malloc() invocation?
 
 I have been looking at this. The same problem also exists in
 cdreportkey() and cdsendkey(). I think that it's better to drop periph
 lock while doing M_WAITOK malloc instead of using M_NOWAIT. Could you
 test and look at this patch:
 
 http://www.saunalahti.fi/~jh3/patches/scsi_cd-M_WAITOK-fixes.diff
 
 -- 
 Jaakko