From owner-cvs-src  Mon Feb 10  6:42:48 2003
Delivered-To: cvs-src@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id DB3CC37B401; Mon, 10 Feb 2003 06:42:46 -0800 (PST)
Received: from mail.pcnet.com (mail.pcnet.com [204.213.232.4])
	by mx1.FreeBSD.org (Postfix) with ESMTP
	id 0228543FA3; Mon, 10 Feb 2003 06:42:46 -0800 (PST)
	(envelope-from eischen@pcnet1.pcnet.com)
Received: from localhost (eischen@localhost)
	by mail.pcnet.com (8.12.3/8.12.1) with ESMTP id h1AEgiqw006137;
	Mon, 10 Feb 2003 09:42:44 -0500 (EST)
Date: Mon, 10 Feb 2003 09:42:44 -0500 (EST)
From: Daniel Eischen <eischen@pcnet1.pcnet.com>
To: Alexey Zelkin <phantom@FreeBSD.org.ua>
Cc: Alfred Perlstein <alfred@FreeBSD.org>, cvs-src@FreeBSD.org
Subject: Re: cvs commit: src/include pthread.h src/lib/libc_r/uthread
 uthread_attr_getstack.c uthread_attr_setstack.c src/lib/libpthread/thread
 thr_attr_getstack.c thr_attr_setstack.c src/lib/libc_r/man pthread_attr.3
In-Reply-To: <20030210120147.A25796@phantom.cris.net>
Message-ID: <Pine.GSO.4.10.10302100937430.5059-100000@pcnet1.pcnet.com>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
Sender: owner-cvs-src@FreeBSD.ORG
Precedence: bulk
List-ID: <cvs-src.FreeBSD.ORG>
List-Archive: <http://docs.freebsd.org/mail/> (Web Archive)
List-Help: <mailto:majordomo@FreeBSD.ORG?subject=help> (List Instructions)
List-Subscribe: <mailto:majordomo@FreeBSD.ORG?subject=subscribe%20cvs-src>
List-Unsubscribe: <mailto:majordomo@FreeBSD.ORG?subject=unsubscribe%20cvs-src>
X-Loop: FreeBSD.ORG

On Mon, 10 Feb 2003, Alexey Zelkin wrote:
> hi,
> 
> Who reviewed this change ?  Did you told to Dan before doing it ?

Yeah, I want a backout!  Back it out now!  Just kidding :-) :-)

These are added functions in the latest POSIX spec.  They do the
same thing as *_[gs]etstackaddr() and *_[gs]etstacksize().

[In the kindest words imaginable] In the future I would like
to review changes to libc_r.

> And last, that purpose of this functionality ?  (I have seen a diff,
> but it's interesting how these functions are supposed to be used?)
> 
> PS: We have pthread_attr_get_np() which provide functionality similar
> to pthread_attr_getstack() in cleaner and correct way.  Having of
> pthread_attr_setstack() is absolutely crazy idea (IMHO) because using it
> after pthread_create() may (or will) crash application.
> 
> On Mon, Feb 10, 2003 at 12:48:04AM -0800, Alfred Perlstein wrote:
> > alfred      2003/02/10 00:48:04 PST
> > 
> >   Modified files:
> >     include              pthread.h 
> >     lib/libc_r/man       pthread_attr.3 
> >   Added files:
> >     lib/libc_r/uthread   uthread_attr_getstack.c 
> >                          uthread_attr_setstack.c 
> >     lib/libpthread/thread thr_attr_getstack.c thr_attr_setstack.c 
> >   Log:
> >   Add pthread_attr_getstack() and pthread_attr_setstack().
> >   
> >   Submitted by: Craig Rodrigues <rodrigc@attbi.com>
> >   
> >   Revision  Changes    Path
> >   1.27      +4 -0      src/include/pthread.h
> >   1.12      +8 -0      src/lib/libc_r/man/pthread_attr.3
> >   1.1       +59 -0     src/lib/libc_r/uthread/uthread_attr_getstack.c (new)
> >   1.1       +58 -0     src/lib/libc_r/uthread/uthread_attr_setstack.c (new)
> >   1.1       +59 -0     src/lib/libpthread/thread/thr_attr_getstack.c (new)
> >   1.1       +58 -0     src/lib/libpthread/thread/thr_attr_setstack.c (new)

-- 
Dan Eischen


To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-src" in the body of the message