From owner-cvs-all@FreeBSD.ORG Sat Apr 7 16:54:56 2007 Return-Path: X-Original-To: cvs-all@FreeBSD.org Delivered-To: cvs-all@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 5120816A402; Sat, 7 Apr 2007 16:54:56 +0000 (UTC) (envelope-from pjd@garage.freebsd.pl) Received: from mail.garage.freebsd.pl (arm132.internetdsl.tpnet.pl [83.17.198.132]) by mx1.freebsd.org (Postfix) with ESMTP id E06AC13C483; Sat, 7 Apr 2007 16:54:55 +0000 (UTC) (envelope-from pjd@garage.freebsd.pl) Received: by mail.garage.freebsd.pl (Postfix, from userid 65534) id B0521487F3; Sat, 7 Apr 2007 18:54:53 +0200 (CEST) Received: from localhost (cvl74.internetdsl.tpnet.pl [83.19.93.74]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mail.garage.freebsd.pl (Postfix) with ESMTP id 5CB6F487F2; Sat, 7 Apr 2007 18:54:44 +0200 (CEST) Date: Sat, 7 Apr 2007 18:54:35 +0200 From: Pawel Jakub Dawidek To: Andrey Chernov , src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org Message-ID: <20070407165435.GK63916@garage.freebsd.pl> References: <200704071602.l37G2V1c066806@repoman.freebsd.org> <20070407164022.GA10309@nagual.pp.ru> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="q6mBvMCt6oafMx9a" Content-Disposition: inline In-Reply-To: <20070407164022.GA10309@nagual.pp.ru> X-PGP-Key-URL: http://people.freebsd.org/~pjd/pjd.asc X-OS: FreeBSD 7.0-CURRENT i386 User-Agent: mutt-ng/devel-r804 (FreeBSD) X-Spam-Checker-Version: SpamAssassin 3.0.4 (2005-06-05) on mail.garage.freebsd.pl X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=BAYES_00,RCVD_IN_NJABL_DUL autolearn=no version=3.0.4 Cc: Subject: Re: cvs commit: src/include stdio.h src/sys/sys unistd.h X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 07 Apr 2007 16:54:56 -0000 --q6mBvMCt6oafMx9a Content-Type: text/plain; charset=iso-8859-2 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sat, Apr 07, 2007 at 08:40:22PM +0400, Andrey Chernov wrote: > On Sat, Apr 07, 2007 at 04:02:31PM +0000, Pawel Jakub Dawidek wrote: > > - Only define SEEK_DATA and SEEK_HOLE in sys/unistd.h when neither > > _POSIX_SOURCE nor _XOPEN_SOURCE is defined. >=20 > 1) This new addition should be exluded for !define(_C99_SOURCE) > !define(_ANSI_SOURCE) !define(_POSIX_C_SOURCE) too. >=20 > 2) We design our *_VISIBLE framework right for the reason to not mention= =20 > all possible *_SOURCE each time like this, making includes unnecessary bi= g=20 > and hard to adapt to the future *_SOURCE tags, but mention one *_VISIBLE= =20 > tag instead, so please rewrite this thing using it. That's why I asked for help. _CDDL_VISIBLE is not good, because it is not related to CDDL license. _ZFS_VISIBLE is not good, because it is not ZFS-specific. _{SUN,SOLARIS,OPENSOLARIS}_VISIBLE is also not good, because it is already in Linux too. Solaris simply defines __EXTENSIONS__. Maybe we need something like this? I don't think we need separate _*_VISIBLE defines for every new #define in unistd.h and other headers, so something similar to __EXTENSIONS__ makes sense to me. --=20 Pawel Jakub Dawidek http://www.wheel.pl pjd@FreeBSD.org http://www.FreeBSD.org FreeBSD committer Am I Evil? Yes, I Am! --q6mBvMCt6oafMx9a Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.6 (FreeBSD) iD8DBQFGF8zLForvXbEpPzQRAiyYAKDkNB51ETQ4NaEcTkGToqAa9pr5RwCcD9Nl lGdLgmRF+BD+gPHeM2e6I3Y= =ci5B -----END PGP SIGNATURE----- --q6mBvMCt6oafMx9a--