From owner-svn-ports-head@FreeBSD.ORG Wed Sep 10 22:19:30 2014 Return-Path: Delivered-To: svn-ports-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 2391EF0E; Wed, 10 Sep 2014 22:19:30 +0000 (UTC) Received: from apnoea.adamw.org (apnoea.adamw.org [204.109.59.150]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id EF1623CE; Wed, 10 Sep 2014 22:19:29 +0000 (UTC) Received: from [192.168.192.25] (dhcp-108-170-169-12.cable.user.start.ca [108.170.169.12]) (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by apnoea.adamw.org (Postfix) with ESMTPSA id E19ED114007; Wed, 10 Sep 2014 18:19:26 -0400 (EDT) Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 7.3 \(1878.6\)) Subject: Re: svn commit: r367883 - in head: Mk lang/gcc From: Adam Weinberger In-Reply-To: Date: Wed, 10 Sep 2014 18:19:25 -0400 Content-Transfer-Encoding: quoted-printable Message-Id: <38D5E5ED-9C3C-4868-BE12-D9EA877EE9EF@adamw.org> References: <201409101909.s8AJ9wpY028698@svn.freebsd.org> <5410AEB5.9050205@FreeBSD.org> To: Gerald Pfeifer X-Mailer: Apple Mail (2.1878.6) Cc: svn-ports-head@freebsd.org, svn-ports-all@freebsd.org, ports-committers@freebsd.org, Bryan Drewery X-BeenThere: svn-ports-head@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: SVN commit messages for the ports tree for head List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 10 Sep 2014 22:19:30 -0000 On 10 Sep, 2014, at 17:32, Gerald Pfeifer wrote: > On Wed, 10 Sep 2014, Bryan Drewery wrote: >> Thanks for writing up a summary of changes. Very useful. I learned=20 >> about AddressSanitizer being supported. >=20 > You are very welcome! (I haven't tested AddressSanitizer myself,=20 > but think I recall a positive report by a user. If it does not=20 > work properly we might look into lang/gcc49 or lang/gcc5.) >=20 >=20 > On a related note, when trying to commit the PORTREVISION bump=20 > related to this commit, I ended up with: >=20 > svn: E165001: Commit failed (details follow): > svn: E165001: Commit blocked by pre-commit hook (exit code 1) with = output: > Do not commit ports with NOPORTDOCS or NOPORTEXAMPLES. > The port must be converted to proper OPTIONS. See > = http://www.freebsd.org/doc/en_US.ISO8859-1/books/porters-handbook/makefile= -options.html >=20 > Not super helpful since it did not indicate which of the 1000+ ports=20= > actually failed this test. ;-) I could bypass this using Approved: > portmgr (implicit). The only remaining instances of NOPORTDOCS and NOPORTEXAMPLES are where = it is passed through MAKE_ENV or MAKE_ARGS to ports. Well, that and devel/rubygem-activesupport{,4} which mysteriously sets = NOPORTDOCS=3Dyes, but anything goes in ruby@ ports. The NOPORT* hooks could probably safely be altered not to match on = MAKE_{ENV,ARGS}. # Adam --=20 Adam Weinberger adamw@adamw.org http://www.adamw.org