Date: Thu, 14 May 2015 11:07:29 -0500 From: Bryan Drewery <bdrewery@FreeBSD.org> To: Adam Weinberger <adamw@adamw.org>, "Philip M. Gollucci" <pgollucci@p6m7g8.com> Cc: "ports-committers@freebsd.org" <ports-committers@freebsd.org>, "svn-ports-all@freebsd.org" <svn-ports-all@freebsd.org>, "svn-ports-head@freebsd.org" <svn-ports-head@freebsd.org> Subject: Re: svn commit: r386285 - head/security/keychain Message-ID: <5554C841.7050309@FreeBSD.org> In-Reply-To: <5554C761.3060609@FreeBSD.org> References: <201505140101.t4E11r9T031351@svn.freebsd.org> <08F806A7-3CD9-417A-BA4E-AF739E83B6A8@adamw.org> <CACM2dAaFL6F-=mbfODTRrR83L%2BGeLfxzcM16DoroP1shmP6NHQ@mail.gmail.com> <082DB80D-6385-4F4F-8A86-2DB4561E39E8@adamw.org> <5554C761.3060609@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --8rQlNjD9oO7hAxJsN2Je3hcp73O0NwU88 Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: quoted-printable On 5/14/2015 11:03 AM, Bryan Drewery wrote: > On 5/14/2015 11:00 AM, Adam Weinberger wrote: >>> On 13 May, 2015, at 21:20, Philip M. Gollucci <pgollucci@p6m7g8.com> = wrote: >>> >>> Then it needs an option not an if exists() >> >> Bryan, can you please consider reverting it, or giving me approval to = revert it? It may fix the case when the port is built in poudriere withou= t sshd in base, but it is a regression for everybody else. >> >> # Adam >> >> >=20 > No. The way RUN_DEPENDS is supposed to work is what I said in the > commit. These exists() checks are redundant and confuse the package > dependencies. >=20 > How are you building? It's possible the tool you are using is > incorrectly handling RUN_DEPENDS. >=20 Poudriere testport -i confirms this: > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D<p= hase: package >=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D > =3D=3D=3D> Building package for keychain-2.8.0_2 > actual-package-depends: dependency on /usr/bin/ssh-agent not registered= (normal if it belongs to base) =2E.. > root@exp-10amd64-commit-test:~ # pkg info | grep openssh > root@exp-10amd64-commit-test:~ # The ports framework, and poudriere, properly do not actually add this dependency and install it. Poudriere however does incorrectly *build* openssh-portable, but it won't add it as a real package run dependency. --=20 Regards, Bryan Drewery --8rQlNjD9oO7hAxJsN2Je3hcp73O0NwU88 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBAgAGBQJVVMhBAAoJEDXXcbtuRpfPWlEH/1X8s4vrL+VBxFTA8DtFHFvz Gi1GeEJPIbLiFiXea1N9OgSG+/ndqADpzbXz3aQON9wU0Ig92rRw/qvz5Z7UlgwV cYe5hIHq8qgF6mU9ReXw/zsugF5ZdA3Xd+YLleXXsMDdqzw66bEPF4LaLmra40op iVfPSFk51DZkDd6RN67tEikshzr39Ri+EkGQ2ZUQNgn/MW0A45SAO6E7YxPhIzfr A1L4sYS5X8jiM0Eq30GCKQfzyZtxX5CLxXlETtjgSzlKXfOz3EKUO3tAPbXL8PCW RMvledyM29A6mZK9ChKA7ADlgXMITX4LL+MUHpTzhIRi/Rebk3rP0heYjRzlsLY= =atx0 -----END PGP SIGNATURE----- --8rQlNjD9oO7hAxJsN2Je3hcp73O0NwU88--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?5554C841.7050309>