From owner-freebsd-ports@FreeBSD.ORG Wed Mar 4 10:05:59 2015 Return-Path: Delivered-To: freebsd-ports@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id A8C4BC84; Wed, 4 Mar 2015 10:05:59 +0000 (UTC) Received: from mail-pd0-x22c.google.com (mail-pd0-x22c.google.com [IPv6:2607:f8b0:400e:c02::22c]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 702809AC; Wed, 4 Mar 2015 10:05:59 +0000 (UTC) Received: by pdbfl12 with SMTP id fl12so25036382pdb.9; Wed, 04 Mar 2015 02:05:59 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:message-id:date:from:reply-to:user-agent:mime-version:to:cc :subject:references:in-reply-to:content-type :content-transfer-encoding; bh=9aJHGKtoNdq9vnCEHMwsDuHMRKqBJcVuFSxyrvhwmNw=; b=EtXXXORu8DFSQQJbcR9Ogdlnt3f+S8SuRQhdj8dpyn0W0JHYfBi9iQ7GoEjGHLWoJC JFmRTP3aTy5/eaaxe0/5Uc8gD2GCEBua9DnugCmysJmHKh0Sz0NjtR5UYOcYMFL02oOe QMsiBiFVR1TJehGvGJIbfXAUINVgRNiuMM/RQZPGRGwGPQTMCMUUdeTpOOuC6Z6nOL0E 15om8v5BQ8DiN/qQ5/NlBMd82E3GBNcjDAIjmkRusQWM04Lfp/EnbHwPZTaVSKNc6Ld4 aQjf8FGfKXZPL+j1Sagsi9FaoBLhDMuIXAH2fDEFAWh/ywybtCk/WjqGegADZ9xxV4wu HeXA== X-Received: by 10.68.239.69 with SMTP id vq5mr5558989pbc.96.1425463559045; Wed, 04 Mar 2015 02:05:59 -0800 (PST) Received: from [192.168.1.104] (ppp59-167-128-11.static.internode.on.net. [59.167.128.11]) by mx.google.com with ESMTPSA id sf7sm3528001pbc.29.2015.03.04.02.05.56 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 04 Mar 2015 02:05:58 -0800 (PST) Sender: Kubilay Kocak Message-ID: <54F6D8FC.2080703@FreeBSD.org> Date: Wed, 04 Mar 2015 21:05:48 +1100 From: Kubilay Kocak Reply-To: koobs@FreeBSD.org User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:36.0) Gecko/20100101 Thunderbird/36.0 MIME-Version: 1.0 To: Doug Hardie Subject: Re: Approving a patch References: <93878D88-4F1E-41EF-B99B-0B70119DDE0C@lafn.org> <54F6155C.3010405@FreeBSD.org> <54F6AA26.1080404@FreeBSD.org> <2A646BF8-F061-4C8D-ACD3-A08DBF1EF5F0@lafn.org> In-Reply-To: <2A646BF8-F061-4C8D-ACD3-A08DBF1EF5F0@lafn.org> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Cc: freebsd-ports@freebsd.org, "bugmeister@freebsd.org" , Bryan Drewery X-BeenThere: freebsd-ports@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: Porting software to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 04 Mar 2015 10:05:59 -0000 On 4/03/2015 9:00 PM, Doug Hardie wrote: > >> On 3 March 2015, at 22:45, Kubilay Kocak wrote: >> >> >> Canonically and preferred: >> >> Set maintainer-approval flag to + *on the attachment/patch*. >> >> The maintainer-feedback flag is at the issue/bug scope, not the >> attachment/patch scope. >> >> This of course requires the maintainer-approval flag was set to ? with >> your email as the value first. >> >> Currently this is not automatic, but *should be* if there is an >> attachment of type: patch in the issue. I'll create an issue for that >> now for bugmeister@ to look into addressing. >> >> Only in cases where maintainer-approval is *not* already set to"?", is >> using the maintainer-feedback flag + comment flow OK. >> >> Setting maintainer-feedback is ambiguous, and is used to prove >> 'acknowledgement' of an issue or question. >> >> This is especially the case when there are multiple version of patches, >> or patches from multiple contributors. In future it will be used to >> derive "maintainer timeouts" to kick issues along, and open them up for >> someone else to make a decision on. >> >> tldr; Set the maintainer-approval flag to + >> > > Thanks to all who replied. I found and set the maintainer-feedback flag at the issue/bug scope. I couldn’t find any similar flag at the attachment/patch scope. Nothing there was really applicable. > Which issue?