From owner-freebsd-hackers@FreeBSD.ORG Sun Aug 11 19:04:05 2013 Return-Path: Delivered-To: hackers@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTP id EE872639; Sun, 11 Aug 2013 19:04:05 +0000 (UTC) (envelope-from ryao@gentoo.org) Received: from smtp.gentoo.org (dev.gentoo.org [IPv6:2001:470:ea4a:1:214:c2ff:fe64:b2d3]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id B7D0D2311; Sun, 11 Aug 2013 19:04:05 +0000 (UTC) Received: from [192.168.1.2] (pool-173-52-119-53.nycmny.fios.verizon.net [173.52.119.53]) (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) (Authenticated sender: ryao) by smtp.gentoo.org (Postfix) with ESMTPSA id A733C33E72B; Sun, 11 Aug 2013 19:04:03 +0000 (UTC) Message-ID: <5207E00F.4000400@gentoo.org> Date: Sun, 11 Aug 2013 15:03:43 -0400 From: Richard Yao User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130714 Thunderbird/17.0.7 MIME-Version: 1.0 To: Steven Hartland Subject: Re: [PATCH] Add 4K QUIRK for Intel X25-M, MARVELL SD88SA02 and OCZ Agility 2 References: <1376223145-81081-1-git-send-email-ryao@gentoo.org> <8E8C51CCA3474B7A9E2C477D4BCEBB04@multiplay.co.uk> In-Reply-To: <8E8C51CCA3474B7A9E2C477D4BCEBB04@multiplay.co.uk> X-Enigmail-Version: 1.6a1pre Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="----enig2GQJMUOIRBJKJJPJXVXRQ" Cc: hackers@FreeBSD.org, Eitan Adler X-BeenThere: freebsd-hackers@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: Technical Discussions relating to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 11 Aug 2013 19:04:06 -0000 This is an OpenPGP/MIME signed message (RFC 4880 and 3156) ------enig2GQJMUOIRBJKJJPJXVXRQ Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Is there any possibility that these quirks could be added to the upcoming 9.2 release? Pools composed of affected disks will suffer from performance issues until they are reformatted with the correct block size. In addition, a certain benchmarking site, whose benchmarks are often fodder for trolls, uses the Intel X25-M in its benchmarks. Adding the quirk to 9.2 would eliminate an unfair handicap on FreeBSD from their next set of benchmarks= =2E On 08/11/2013 09:48 AM, Steven Hartland wrote: > Thanks Richard I'll commit these when I get in the office next week. >=20 > Regards > Steve > ----- Original Message ----- From: "Richard Yao" > To: > Cc: "Richard Yao" ; "Eitan Adler" = > Sent: Sunday, August 11, 2013 1:12 PM > Subject: [PATCH] Add 4K QUIRK for Intel X25-M, MARVELL SD88SA02 and OCZ= > Agility 2 >=20 >=20 >> Signed-off-by: Richard Yao >> --- >> sys/cam/ata/ata_da.c | 24 ++++++++++++++++++++++++ >> sys/cam/scsi/scsi_da.c | 24 ++++++++++++++++++++++++ >> 2 files changed, 48 insertions(+) >> >> diff --git a/sys/cam/ata/ata_da.c b/sys/cam/ata/ata_da.c >> index f201231..b7f293d 100644 >> --- a/sys/cam/ata/ata_da.c >> +++ b/sys/cam/ata/ata_da.c >> @@ -349,6 +349,14 @@ static struct ada_quirk_entry ada_quirk_table[] =3D= >> }, >> { >> /* >> + * Intel X25-M Series SSDs >> + * 4k optimised & trim only works in 4k requests + 4k aligned >> + */ >> + { T_DIRECT, SIP_MEDIA_FIXED, "*", "INTEL SSDSA2M*", "*" }, >> + /*quirks*/ADA_Q_4K >> + }, >> + { >> + /* >> * Kingston E100 Series SSDs >> * 4k optimised & trim only works in 4k requests + 4k aligned >> */ >> @@ -365,6 +373,22 @@ static struct ada_quirk_entry ada_quirk_table[] =3D= >> }, >> { >> /* >> + * Marvell SSD (entry taken from Open Solaris) >> + * 4k optimised & trim only works in 4k requests + 4k aligned >> + */ >> + { T_DIRECT, SIP_MEDIA_FIXED, "*", "MARVELL SD88SA02*", "*" }, >> + /*quirks*/ADA_Q_4K >> + }, >> + { >> + /* >> + * OCZ Agility 2 SSDs >> + * 4k optimised & trim only works in 4k requests + 4k aligned >> + */ >> + { T_DIRECT, SIP_MEDIA_FIXED, "*", "OCZ-AGILITY2*", "*" }, >> + /*quirks*/ADA_Q_4K >> + }, >> + { >> + /* >> * OCZ Agility 3 SSDs >> * 4k optimised & trim only works in 4k requests + 4k aligned >> */ >> diff --git a/sys/cam/scsi/scsi_da.c b/sys/cam/scsi/scsi_da.c >> index 617afbd..df895be 100644 >> --- a/sys/cam/scsi/scsi_da.c >> +++ b/sys/cam/scsi/scsi_da.c >> @@ -1008,6 +1008,14 @@ static struct da_quirk_entry da_quirk_table[] =3D= >> }, >> { >> /* >> + * Intel X25-M Series SSDs >> + * 4k optimised & trim only works in 4k requests + 4k aligned >> + */ >> + { T_DIRECT, SIP_MEDIA_FIXED, "*", "INTEL SSDSA2M*", "*" }, >> + /*quirks*/ADA_Q_4K >> + }, >> + { >> + /* >> * Kingston E100 Series SSDs >> * 4k optimised & trim only works in 4k requests + 4k aligned >> */ >> @@ -1024,6 +1032,22 @@ static struct da_quirk_entry da_quirk_table[] =3D= >> }, >> { >> /* >> + * Marvell SSD (entry taken from Open Solaris) >> + * 4k optimised & trim only works in 4k requests + 4k aligned >> + */ >> + { T_DIRECT, SIP_MEDIA_FIXED, "*", "MARVELL SD88SA02*", "*" }, >> + /*quirks*/ADA_Q_4K >> + }, >> + { >> + /* >> + * OCZ Agility 2 SSDs >> + * 4k optimised & trim only works in 4k requests + 4k aligned >> + */ >> + { T_DIRECT, SIP_MEDIA_FIXED, "*", "OCZ-AGILITY2*", "*" }, >> + /*quirks*/ADA_Q_4K >> + }, >> + { >> + /* >> * OCZ Agility 3 SSDs >> * 4k optimised & trim only works in 4k requests + 4k aligned >> */ >> --=20 >> 1.8.1.5 >> >> _______________________________________________ >> freebsd-hackers@freebsd.org mailing list >> http://lists.freebsd.org/mailman/listinfo/freebsd-hackers >> To unsubscribe, send any mail to >> "freebsd-hackers-unsubscribe@freebsd.org" >> >=20 > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D > This e.mail is private and confidential between Multiplay (UK) Ltd. and= > the person or entity to whom it is addressed. In the event of > misdirection, the recipient is prohibited from using, copying, printing= > or otherwise disseminating it or any information contained in it. > In the event of misdirection, illegible or incomplete transmission > please telephone +44 845 868 1337 > or return the E.mail to postmaster@multiplay.co.uk. >=20 ------enig2GQJMUOIRBJKJJPJXVXRQ Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.20 (GNU/Linux) Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQIcBAEBAgAGBQJSB+ARAAoJECDuEZm+6ExkM7YP/A8Ox724c2XYnHs8I/BcaN0E uXyucHaUO+nvJUFf0iac5hE8zavKk8TZkLSsAxE29de5U6j5kOBs1uGuI8ypDD1/ bDNpwfzMStu87W/OOYC+xyeqNBJsf/og8D1DLpj/yz7expSVyexplvwg1TF0TFqx ZhhsXsaodWY10mWfYA9Fm3L0omhHdgDe0bQvOAcWSapLhs0XNKZubFOf4c78hpoj dZzbak6xKCnrmQXIYBo3n3b7XKapnDqL530XDmkf9ifGtstXoWeQ21ClEGynP+wr Kj30Abb4ADi7Ty2qdi44Mrh/kNP1Nv1OgwgODts5CtfwDmDySWscQotaXnje1bSo s16xCnrAxDaaOME5m7AAYmx5SFZ3R/Xxc+4cZLrzbTIWl56f1Z0s0smISTL+eMi0 YA+Wi0ApW6zVAhnBabKizGc01Pbr7j2DddbDARSv2z9zNc7hWhW+feoSg/6IcVlw 8H0SPJeD/x/wouX8yRBS7lxTVLKNHfHpHESQyptsjmdXNWGuPyvWi4PptsqpUWI0 LP7M59Wyt6jnY95MUbxhdzGQX1Kv9WFy16fRkmBEKu6LIV2Me2EX7F2yAWXfKiWj bm16m9TP40TJY62paX/gyv/gyFmjUHwg5HEvlanxb1DY4ynyWho2ngHegWwviINk 8f1r1SCXTju5Y4SPQsUg =C09f -----END PGP SIGNATURE----- ------enig2GQJMUOIRBJKJJPJXVXRQ--