From owner-cvs-src@FreeBSD.ORG Tue Aug 22 09:38:21 2006 Return-Path: X-Original-To: cvs-src@freebsd.org Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 4C6DB16A4DD; Tue, 22 Aug 2006 09:38:21 +0000 (UTC) (envelope-from kris@obsecurity.org) Received: from elvis.mu.org (elvis.mu.org [192.203.228.196]) by mx1.FreeBSD.org (Postfix) with ESMTP id E52EF43D46; Tue, 22 Aug 2006 09:38:20 +0000 (GMT) (envelope-from kris@obsecurity.org) Received: from obsecurity.dyndns.org (elvis.mu.org [192.203.228.196]) by elvis.mu.org (Postfix) with ESMTP id C8B971A3C27; Tue, 22 Aug 2006 02:38:20 -0700 (PDT) Received: by obsecurity.dyndns.org (Postfix, from userid 1000) id 0883F513B2; Tue, 22 Aug 2006 05:38:20 -0400 (EDT) Date: Tue, 22 Aug 2006 05:38:19 -0400 From: Kris Kennaway To: Florent Thoumie Message-ID: <20060822093819.GA48419@xor.obsecurity.org> References: <200601161951.k0GJpfNx017833@repoman.freebsd.org> <20060821080945.A48690@p-i-n.com> <20060821110753.GA99959@xor.obsecurity.org> <1156159640.53353.29.camel@mayday.esat.net> <20060821115657.GA1425@xor.obsecurity.org> <1156162582.53353.37.camel@mayday.esat.net> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="tKW2IUtsqtDRztdT" Content-Disposition: inline In-Reply-To: <1156162582.53353.37.camel@mayday.esat.net> User-Agent: Mutt/1.4.2.2i Cc: cvs-src@freebsd.org, src-committers@freebsd.org, "Raphael H. Becker" , cvs-all@freebsd.org, Kris Kennaway Subject: Re: PKGDIR ambiguous (was: cvs commit: src/usr.sbin/pkg_install/info info.h main.c perform.c pkg_info.1 src/usr.sbin/pkg_install/add add.h main.c perform.c pkg_add.1 src/usr.sbin/pkg_install/lib lib.h url.c) X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 22 Aug 2006 09:38:21 -0000 --tKW2IUtsqtDRztdT Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Aug 21, 2006 at 01:16:22PM +0100, Florent Thoumie wrote: > On Mon, 2006-08-21 at 07:56 -0400, Kris Kennaway wrote: > > On Mon, Aug 21, 2006 at 12:27:20PM +0100, Florent Thoumie wrote: > > > On Mon, 2006-08-21 at 07:07 -0400, Kris Kennaway wrote: > > > > On Mon, Aug 21, 2006 at 08:09:45AM +0200, Raphael H. Becker wrote: > > > > >=20 > > > > > Hi Florent, > > > > >=20 > > > > > PKGDIR is ambiguous in the context of ports and packages. > > > > >=20 > > > > > I set PKGDIR=3D/some/where/my/pkg in my /etc/profile which causes= the > > > > > ports to fail badly creating any packages: > > > > >=20 > > > > > It is used in ports/Mk/bsd.port.mk: > > > > > # PKGDIR - A directory containing any package crea= tion > > > > > # files. > > > > > # Default: ${MASTERDIR} > > > > > [...] > > > > > PKGDIR?=3D ${MASTERDIR} > > > > >=20 > > > > > Havin set PKGDIR statically is a very bad idea here. > > > >=20 > > > > Yes, PKGDIR is incorrect in this usage. The documented place where > > > > packages are stored is: > > > >=20 > > > > # PACKAGES - A top level directory where all packages = go (rather than > > > > # going locally to each port). > > > > # Default: ${PORTSDIR}/packages > > > > # > > >=20 > > > PACKAGES is a better choice than PKGDIR, but I'd like to avoid confus= ion > > > between "cached" packages (as in, copies of downloaded packages), and > > > "home-brewed" packages.=20 > >=20 > > Not sure there is a need to; they're both just packages. >=20 > I think there is, or there should be another subdirectory under PACKAGES > to tell where the packages come from. Like what apt does, something like > ${PACKAGES}/ftp.freebsd.org.packages.6.stable/All/blah.tbz. >=20 > You definitely don't want to mix packages from different sources, or > made from different ports trees. I don't really see the need for this; but if you want to go this route there are other tools that also need to be taught about the proposed new directory layout). Kris --tKW2IUtsqtDRztdT Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.5 (FreeBSD) iD8DBQFE6tCLWry0BWjoQKURAlR5AKCBKdVkKhJvOm26dETQxST/yYcnYgCgx0Kn phm40K69eZkdXIC16m4akvE= =yCqp -----END PGP SIGNATURE----- --tKW2IUtsqtDRztdT--