From nobody Wed Nov 29 01:55:31 2023 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4Sg2Tb5TwQz52tRF; Wed, 29 Nov 2023 01:55:31 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Sg2Tb53fLz4CnJ; Wed, 29 Nov 2023 01:55:31 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1701222931; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=QTyquLqQp29J0Scbsk6Z3nK+WPl81drSDtQbtkDv964=; b=Sc5XrLwhoGBcaEGnrXRNM1HeJ5w6QWT6mlZRAnG8J3lu3jfPAzr7jSM9g0Aceo47tl+y4Q H2kwi6um1I7eX/1GVYO9WgqsSgzfz4EQw9GCClTuj3ggXE997a54JsPW13cF/+7pjBbfdR 4OhpvoN2T7j/JB79SUWPth3Yc/J/m8oRbx5o/ef06xCSHWjBbFBTbMUNsWSoFOBPB790SX zdFavZMt4xNRWaH8apvhX84Vs0PNn9pG33R5zjyTCQ1W+pdTO6G6abe4PTS370MPdU0l0o XJmTjlsW50+KFF3vBOGJFOa03h7AqjwHwMb77BilDIp5G3N+tMCaFMkB2yucEg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1701222931; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=QTyquLqQp29J0Scbsk6Z3nK+WPl81drSDtQbtkDv964=; b=Wq3J1vyCwftcN9RedRuHdynWpBuGuzd0R9hojHVIKQZoc9PfL4pOAdK3E8PYhFKUaWOrvH b1zG50eP2dJBT14EXHxknkUEXRgf6yUM2Xz22UPR/1/l3FM+t1kQjNDG6nzgx06HyEO3h+ Hm4dz1i6AmmJuY36gPZH3YXYWkotEwPNWe8UD7w1OyvcpSpA61BePLcjItJSZ6o+jHehdV sCA7kx9YPLEjr8YgSW/OHYhkEgaMQ18ajr4bskeo07D2Po82r3b9FhZp9cEC9IyM1U07eW y+I/QKX4eV9UAoFsovpK7NkISHd3KuNLme9d6MEh8Ew1jpQ/TMMLhH41nunWhw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1701222931; a=rsa-sha256; cv=none; b=nMVyIfeo7tb54bZSVBlBb3K7s5cAagYGZrRW2g3gGi7KkBd1moWXW6eCROwnHHg0SCDR3Q 3mxG8zBUYLk/Xphsk3bxBd0atgNCOhVf4Du4oc7nEUvn4NJchOXcDoRsR2wjSd79HBTTdz nBt3O6rGt1Tm5sUED5BNS2URjeNNQJN0WmZH1p/sO4fkeC4L4Y4ryy4jCAGJVxiumxi8CH VXbFrK3PXRC7/JCWrJ63nnnV5XUsq+AV74XepsFtC7OodNlt6Mh6Wck5N7sjRGSgo85c1K 65OZV9G2nx1zStD9O1LkP1grrYM/DRFqkvNYuqi2sxPKkXdqtZrZd4jj5o3LSw== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4Sg2Tb47fCzmf1; Wed, 29 Nov 2023 01:55:31 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.17.1/8.17.1) with ESMTP id 3AT1tVOu064208; Wed, 29 Nov 2023 01:55:31 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.17.1/8.17.1/Submit) id 3AT1tVh8064205; Wed, 29 Nov 2023 01:55:31 GMT (envelope-from git) Date: Wed, 29 Nov 2023 01:55:31 GMT Message-Id: <202311290155.3AT1tVh8064205@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Warner Losh Subject: git: a2b046620c54 - main - mpi3mr: Remove unused fields in struct mpi3mr_cmd List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-all@freebsd.org X-BeenThere: dev-commits-src-all@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: imp X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: a2b046620c54db977196128b3c53da2704b9fd20 Auto-Submitted: auto-generated The branch main has been updated by imp: URL: https://cgit.FreeBSD.org/src/commit/?id=a2b046620c54db977196128b3c53da2704b9fd20 commit a2b046620c54db977196128b3c53da2704b9fd20 Author: Warner Losh AuthorDate: 2023-11-29 01:49:01 +0000 Commit: Warner Losh CommitDate: 2023-11-29 01:49:01 +0000 mpi3mr: Remove unused fields in struct mpi3mr_cmd All of these fields are either unused, or just initialized. Remove them. This saves about 1MB of memory for the cards that I have which can do 8k transactions at once. Sponsored by: Netflix Reviewed by: mav, jhb Differential Revision: https://reviews.freebsd.org/D42538 --- sys/dev/mpi3mr/mpi3mr.c | 3 --- sys/dev/mpi3mr/mpi3mr.h | 6 ------ 2 files changed, 9 deletions(-) diff --git a/sys/dev/mpi3mr/mpi3mr.c b/sys/dev/mpi3mr/mpi3mr.c index 478b0944defa..9a052c98d13e 100644 --- a/sys/dev/mpi3mr/mpi3mr.c +++ b/sys/dev/mpi3mr/mpi3mr.c @@ -4985,12 +4985,9 @@ mpi3mr_get_command(struct mpi3mr_softc *sc) cmd->data_dir = 0; cmd->ccb = NULL; cmd->targ = NULL; - cmd->max_segs = 0; - cmd->lun = 0; cmd->state = MPI3MR_CMD_STATE_BUSY; cmd->data = NULL; cmd->length = 0; - cmd->out_len = 0; out: mtx_unlock(&sc->cmd_pool_lock); return cmd; diff --git a/sys/dev/mpi3mr/mpi3mr.h b/sys/dev/mpi3mr/mpi3mr.h index 479ba9c7b11b..b00d2ef562d8 100644 --- a/sys/dev/mpi3mr/mpi3mr.h +++ b/sys/dev/mpi3mr/mpi3mr.h @@ -456,19 +456,13 @@ struct mpi3mr_cmd { union ccb *ccb; void *data; u_int length; - u_int out_len; - struct uio uio; - struct iovec iovec[MPI3MR_IOVEC_COUNT]; - u_int max_segs; struct mpi3mr_target *targ; - u_int lun; u_int data_dir; u_int state; bus_dmamap_t dmamap; struct scsi_sense_data *sense; struct callout callout; bool callout_owner; - mpi3mr_cmd_callback_t *timeout_handler; U16 hosttag; U8 req_qidx; Mpi3SCSIIORequest_t io_request;