From owner-svn-ports-all@FreeBSD.ORG  Fri Dec 21 07:18:43 2012
Return-Path: <owner-svn-ports-all@FreeBSD.ORG>
Delivered-To: svn-ports-all@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52])
 by hub.freebsd.org (Postfix) with ESMTP id 7EB3AB1F;
 Fri, 21 Dec 2012 07:18:43 +0000 (UTC)
 (envelope-from araujobsdport@gmail.com)
Received: from mail-qa0-f54.google.com (mail-qa0-f54.google.com
 [209.85.216.54])
 by mx1.freebsd.org (Postfix) with ESMTP id D4A6A8FC12;
 Fri, 21 Dec 2012 07:18:42 +0000 (UTC)
Received: by mail-qa0-f54.google.com with SMTP id j15so3226661qaq.13
 for <multiple recipients>; Thu, 20 Dec 2012 23:18:36 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113;
 h=mime-version:reply-to:in-reply-to:references:date:message-id
 :subject:from:to:cc:content-type;
 bh=DZuKDYSO0cBIouhECLWOqDmlnDuYtTmzAGIc0IIllHE=;
 b=p5Dhsmupz52sW73Ja/3ERsovAel4Qs7mWIVrpnTM30LHUO4fmCN0L3BXGSWFyfzjqz
 EV5mEAOMq26XjkMMJYOy2Vq02SRkYDuKHAU6cukywNqZpRxanaSKA2MkUzNCR5ug1WXF
 d32xWKKoSx8NjnSP2Td2hx9wXwSPhcYSy/sLUbPA8+lHsTzKwSeUOe6MNoNpWswIsf4a
 YynNq+jh6cwPi6J9FJUtfrNePaxpO01kJ4LEJ3KxLw1V3uTXjWRCMPRVFgGqUMSDmj1V
 QC4s8O99GG7Tvu5H83EInVD6fCDlUYOudDy2rldAKIEzTiQrvzEuGJhfan4BAzgPgDwC
 vusQ==
MIME-Version: 1.0
Received: by 10.224.188.13 with SMTP id cy13mr5779336qab.53.1356074315990;
 Thu, 20 Dec 2012 23:18:35 -0800 (PST)
Received: by 10.49.98.3 with HTTP; Thu, 20 Dec 2012 23:18:35 -0800 (PST)
In-Reply-To: <201212210709.qBL793Pf011937@svn.freebsd.org>
References: <201212210709.qBL793Pf011937@svn.freebsd.org>
Date: Fri, 21 Dec 2012 15:18:35 +0800
Message-ID: <CAOfEmZgSq5ZAGeWx0V=S-mZP9amxZKfcTGEv97RtYhG_z59pFA@mail.gmail.com>
Subject: Re: svn commit: r309343 - in head/archivers/fastjar: . files
From: Marcelo Araujo <araujobsdport@gmail.com>
To: Alexey Dokuchaev <danfe@freebsd.org>
Content-Type: text/plain; charset=ISO-8859-1
X-Content-Filtered-By: Mailman/MimeDel 2.1.14
Cc: svn-ports-head@freebsd.org, svn-ports-all@freebsd.org,
 ports-committers@freebsd.org
X-BeenThere: svn-ports-all@freebsd.org
X-Mailman-Version: 2.1.14
Precedence: list
Reply-To: araujo@FreeBSD.org
List-Id: SVN commit messages for the ports tree <svn-ports-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/svn-ports-all>,
 <mailto:svn-ports-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-ports-all>
List-Post: <mailto:svn-ports-all@freebsd.org>
List-Help: <mailto:svn-ports-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-ports-all>,
 <mailto:svn-ports-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 21 Dec 2012 07:18:43 -0000

2012/12/21 Alexey Dokuchaev <danfe@freebsd.org>

>
>
>   Approved by:  maintainer (maho)
>
>
Dear Alexey,

What I'm going to point out is not so important, but as I know that you
like and keep attention of standards and details, I think you shall follow
the Approved by, using the same standard as for mentor.

Approved by: maho (maintainer)
instead of
Approved by: maintainer (maho)

Here is a description from Committers Guide:
"""
Approved by:
The name and e-mail address of the person or people that approved the
change; for committers, just the username on the FreeBSD cluster. It is
customary to get prior approval for a commit if it is to an area of the
tree to which you do not usually commit. In addition, during the run up to
a new release all commits *must*be approved by the release engineering
team. If these are your first commits then you should have passed them past
your mentor first, and you should list your mentor, as in ``*
username-of-mentor* (mentor)''.
"""

Best Regards,
-- 
Marcelo Araujo
araujo@FreeBSD.org