Date: Sun, 24 Jan 2021 20:46:40 +0100 From: Lutz Donnerhacke <lutz@donnerhacke.de> To: Lutz Donnerhacke <donner@FreeBSD.org> Cc: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org Subject: Re: git: 5fe433a6e4d8 - main - netgraph/ng_nat: Add RFC 6598/Carrier Grade NAT support Message-ID: <20210124194640.GA6527@belenus.iks-jena.de> In-Reply-To: <202101241941.10OJfCGA013081@gitrepo.freebsd.org> References: <202101241941.10OJfCGA013081@gitrepo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Sun, Jan 24, 2021 at 07:41:12PM +0000, Lutz Donnerhacke wrote: > commit 5fe433a6e4d8cab6b64284698301afc0c55a9db2 > Author: Neel Chauhan <nc@FreeBSD.org> > AuthorDate: 2021-01-24 19:23:39 +0000 > Commit: Lutz Donnerhacke <donner@FreeBSD.org> > CommitDate: 2021-01-24 19:38:35 +0000 > > netgraph/ng_nat: Add RFC 6598/Carrier Grade NAT support > > This extends upon the RFC 6598 support to libalias/ipfw in r357092. > > Reviewed By: manpages (bcr), donner, adrian, kp > Approved by: kp (mentor) > MFC after: 1 month > Differential Revision: https://reviews.freebsd.org/D23461 git allows us to distinguish between Author and Committer. I used this (after a discussion with my mentor) to attribute a foreign submission (nc has no src bit) directly to the Autor instead of setting "Submitted by:" (as used under subversion) Question: What is the prefered method to commit for an other person? traditional: > Author: committer > Commit: committer > > patch > Submitted by: author or (as above): > Author: author > Commit: committer > > patch Any opinions?
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20210124194640.GA6527>