From owner-freebsd-arch@FreeBSD.ORG Wed Mar 24 13:59:52 2010 Return-Path: Delivered-To: freebsd-arch@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id EF0F6106566C; Wed, 24 Mar 2010 13:59:52 +0000 (UTC) (envelope-from alexander@leidinger.net) Received: from mail.ebusiness-leidinger.de (mail.ebusiness-leidinger.de [217.11.53.44]) by mx1.freebsd.org (Postfix) with ESMTP id 727A28FC12; Wed, 24 Mar 2010 13:59:52 +0000 (UTC) Received: from outgoing.leidinger.net (pD954FFF0.dip.t-dialin.net [217.84.255.240]) by mail.ebusiness-leidinger.de (Postfix) with ESMTPSA id 49AAE844410; Wed, 24 Mar 2010 14:59:46 +0100 (CET) Received: from webmail.leidinger.net (webmail.leidinger.net [192.168.1.102]) by outgoing.leidinger.net (Postfix) with ESMTP id 351F95363; Wed, 24 Mar 2010 14:59:42 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=Leidinger.net; s=outgoing-alex; t=1269439182; bh=83uFMz57JdsoBRVlrYulDHximPH6LEvE0XcTsMsLXBs=; h=Message-ID:Date:From:To:Cc:Subject:References:In-Reply-To: MIME-Version:Content-Type:Content-Transfer-Encoding; b=CgwW3CSZh31IkRG2xhupQe56J/ChU6NT9RhXzpxIQJ64BorMHFnyft9W3jnoiLcZT bsTP3ilrHyaFtbbD/DfpD+mK+Xn8LSDhb73bFvzD0Okv0b/1kwALJhokV3P5YsqiC9 w4sKeCTQTUY2c534h7bwCZzdZOi/o84t7bzVATn0qpNqzPIZKpR5reee2vc9+HxOuk d8qkoz3ARWqEp0Ut5wwwNpZZzMG4qoDbyQrldBiti/LtW5RviCheo53g8esYd5nVKc 0voPF2t8CdSaEBJTi+Yu5XklhAje7xia1Hlf1gTukB7hDQGf+K153ISYpKIzwM/s3G ITN0xkIZbT2Ng== Received: (from www@localhost) by webmail.leidinger.net (8.14.3/8.13.8/Submit) id o2ODxfv7098204; Wed, 24 Mar 2010 14:59:41 +0100 (CET) (envelope-from Alexander@Leidinger.net) Received: from pslux.cec.eu.int (pslux.cec.eu.int [158.169.9.14]) by webmail.leidinger.net (Horde Framework) with HTTP; Wed, 24 Mar 2010 14:59:41 +0100 Message-ID: <20100324145941.181387uohp3zdl1o@webmail.leidinger.net> Date: Wed, 24 Mar 2010 14:59:41 +0100 From: Alexander Leidinger To: John Baldwin References: <20100322.125937.278730673160410010.imp@bsdimp.com> <20100322.203553.752311254955266835.imp@bsdimp.com> <20100323111243.124121qxmpk2c4lc@webmail.leidinger.net> <201003231025.55404.jhb@freebsd.org> In-Reply-To: <201003231025.55404.jhb@freebsd.org> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8; DelSp="Yes"; format="flowed" Content-Disposition: inline Content-Transfer-Encoding: 7bit User-Agent: Dynamic Internet Messaging Program (DIMP) H3 (1.1.4) X-EBL-MailScanner-Information: Please contact the ISP for more information X-EBL-MailScanner-ID: 49AAE844410.E57DF X-EBL-MailScanner: Found to be clean X-EBL-MailScanner-SpamCheck: not spam, spamhaus-ZEN, SpamAssassin (not cached, score=-1.44, required 6, autolearn=disabled, ALL_TRUSTED -1.44, DKIM_SIGNED 0.00, DKIM_VERIFIED -0.00) X-EBL-MailScanner-From: alexander@leidinger.net X-EBL-MailScanner-Watermark: 1270043986.76109@nkmInldpzaCwFQkQSJ1Njw X-EBL-Spam-Status: No Cc: rwatson@freebsd.org, freebsd-arch@freebsd.org Subject: Re: CTF patch for testing/review X-BeenThere: freebsd-arch@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussion related to FreeBSD architecture List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 24 Mar 2010 13:59:53 -0000 Quoting John Baldwin (from Tue, 23 Mar 2010 10:25:55 -0400): > On Tuesday 23 March 2010 6:12:43 am Alexander Leidinger wrote: >> Quoting "M. Warner Losh" (from Mon, 22 Mar 2010 >> 20:35:53 -0600 (MDT)): >> >> > In message: <201003221605.24538.jhb@freebsd.org> >> > John Baldwin writes: >> > : On Monday 22 March 2010 3:05:12 pm M. Warner Losh wrote: >> > : > In message: <20100322.125937.278730673160410010.imp@bsdimp.com> >> > : > M. Warner Losh writes: >> > : > : In message: <20100322172104.14234yawbsev0sw8@webmail.leidinger.net> >> > : > : Alexander Leidinger writes: >> > : > : : Normally we use MK_xxx for things which are opt-in/opt-out. >> > What about >> > : > : : using MK_xxx instead of ENABLE_CTF? If people are in favour >> > of MK_xxx, >> > : > : : what should the xxx part look like? >> > : > : >> > : > : Normally we *TEST* MK_XXX for things which are opt-in/opt-out and >> > : > : require the user to say WITH_XXX or WITHOUT_XXX if they don't like > the >> > : > : default (or want to ensure they get option XXX, even if we turn it > off >> > : > : by default in the future). The default then gets encoded in >> > : > : bsd.own.mk, and permeates the FreeBSD build system since we include >> > : > : that everywhere, directly or indirectly. >> > : > : >> > : > : The problem is that bsd.own.mk is not included in sys.mk, nor should >> > : > : it be. That's why we have the hacky combination of WITH_CTF and >> > : > : NO_CTF that's there today. >> > : > : >> > : > : : Is bsd.kern.mk included in module builds too? >> > : > : >> > : > : Yes. >> > : > >> > : > One last thing I should have said was that the patch that was posted >> > : > earlier in the thread looked ok, and likely couldn't be made >> > : > significantly better due to the bsd.own.mk issue. >> > : >> > : I think the patch is a good approach, I just think it needs to >> > default to not >> > : enabling CTF by default. Instead, various bsd.foo.mk should selectively >> > : enable it. >> > >> > I should have added that bit as well... >> >> And here it is: >> http://www.leidinger.net/test/ctf2.diff >> >> Please pay attention to one XXX comment. Both cases I describe look >> possible, but I would like to get some more eyes on this issues to not >> overlook something. > > I would maybe put a comment in front of the CFLAGS+= line for now and leave > the rest of the XXX comment. I'm not sure of the best way to solve this yet. Done. I want to have a look if it is possible to do it similar to the LD_CTF_FLAG way later. Currently I have the problem that WITH_CTF is not picked up by kmod.mk if "makeoptions WITH_CTF=yes" is used in the kernel config. This means that all makeoptions do not propagate to module builds. Any ideas? Maybe letting makeoptions add lines like "KERNELSUBMAKEARGS+=" and using this for calls to make (I assume kernel modules are build by issuing calls to make in the corresponding directories)? >> I haven't renamed the NO_CTF part yet. Bikeshed: ENABLE_CTF / ADD_CTF >> / MK_CTF / MK_CTFINFO / MK_CTFINC / ...? Cast your vote please. > > I think the naming stuff you have used is fine. I think it is better to use > NO_CTF rather than MK_CTF because this is not set via bsd.own.mk but is a > special case. I agree. Bye, Alexander. -- If graphics hackers are so smart, why can't they get the bugs out of fresh paint? http://www.Leidinger.net Alexander @ Leidinger.net: PGP ID = B0063FE7 http://www.FreeBSD.org netchild @ FreeBSD.org : PGP ID = 72077137