From nobody Fri Dec 29 15:25:33 2023 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4T1q2R4bfpz56JRs; Fri, 29 Dec 2023 15:25:35 +0000 (UTC) (envelope-from mike@karels.net) Received: from mail2.karels.net (mail2.karels.net [3.19.118.201]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "freebsd", Issuer "freebsd" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4T1q2R2Wppz4N2f; Fri, 29 Dec 2023 15:25:35 +0000 (UTC) (envelope-from mike@karels.net) Authentication-Results: mx1.freebsd.org; none Received: from mail2.karels.net (localhost [IPv6:0:0:0:0:0:0:0:1]) by mail2.karels.net (8.17.1/8.17.1) with ESMTP id 3BTFPY3J030203; Fri, 29 Dec 2023 09:25:34 -0600 (CST) (envelope-from mike@karels.net) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=karels.net; s=mail2; t=1703863534; bh=mi9yTQMNWO8725ljb5Yc/ne6yXVdxiSvKG45kAcrMwI=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=kCIAjp6dEa5asqXG16yVVCBoTVloqfCJbhwRPqrGfkca1N/kabffvQK18bLLUOrc2 Z7b2dPPclyIg43PhpmQi2WFAwHnFJkGy+q8T7YKkPsKJGhwi8iJ1iemKOvQMEtjb1U KsO5VjX0zK+kXrulLPP6uGaSxM6nv5cmJYxAtmnyItGygNuxe2o5l122fquK+AU/Tu Ul6StrLiUNFJj9gKjQO3TgeDFVv04fVeum83X2Dd5V6Sl3dvofxITjf6Vj5GbR1ffd Z2VVbeBZ5JVFhhqePFjy4MjlYhGswg/TrxvrLpOz2Ia3P/mHYH9++tprWVGoGTqxk5 DXjhIslDa5N7g== Received: from [10.0.2.130] ([73.62.165.147]) by mail2.karels.net with ESMTPSA id //l3Du7kjmX5dQAAs/W3XQ (envelope-from ); Fri, 29 Dec 2023 09:25:34 -0600 From: Mike Karels To: Xin LI Cc: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org Subject: Re: git: 2f036705f337 - main - Document the two recent newsyslog(8) change (-c option and configuration option). Date: Fri, 29 Dec 2023 09:25:33 -0600 X-Mailer: MailMate (1.14r6015) Message-ID: <90D0905E-AA46-4351-AEE0-9ED9D835DB50@karels.net> In-Reply-To: <202312290846.3BT8kOiO029918@gitrepo.freebsd.org> References: <202312290846.3BT8kOiO029918@gitrepo.freebsd.org> List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-all@freebsd.org X-BeenThere: dev-commits-src-all@freebsd.org MIME-Version: 1.0 Content-Type: text/plain Content-Transfer-Encoding: quoted-printable X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:16509, ipnet:3.16.0.0/14, country:US] X-Spamd-Bar: ---- X-Rspamd-Queue-Id: 4T1q2R2Wppz4N2f On 29 Dec 2023, at 2:46, Xin LI wrote: > The branch main has been updated by delphij: > > URL: https://cgit.FreeBSD.org/src/commit/?id=3D2f036705f337f61cee5a3b4f= 570b023c3da29895 > > commit 2f036705f337f61cee5a3b4f570b023c3da29895 > Author: Xin LI > AuthorDate: 2023-12-29 08:45:52 +0000 > Commit: Xin LI > CommitDate: 2023-12-29 08:45:52 +0000 > > Document the two recent newsyslog(8) change (-c option and > configuration option). > --- > RELNOTES | 20 ++++++++++++++++++++ > 1 file changed, 20 insertions(+) > > diff --git a/RELNOTES b/RELNOTES > index 509cf36c070e..adb9ca67aa0c 100644 > --- a/RELNOTES > +++ b/RELNOTES > @@ -10,6 +10,26 @@ newline. Entries should be separated by a newline. > > Changes to this file should not be MFCed. > > +61174ad88e33: > + newsyslog(8) now supports specifying a global compression method dire= ctly > + at the beginning of the newsyslog.conf file, which will make newsyslo= g(8) > + to behave like the corresponding option was passed to the newly added= > + '-c' option. For example: > + > + none > + > +906748d208d3: > + newsyslog(8) now accepts a new option, '-c' which overrides all histo= rical > + compression flags by treating their meaning as "treat the file as com= pressible" > + rather than "compress the file with that specific method." > + > + The following choices are available: > + * none: Do not compress, regardless of flag. > + * legacy: Historical behavior (J=3Dbzip2, X=3Dxz, Y=3Dzstd, Z=3Dgzip= ). > + * bzip2, xz, zstd, gzip: apply the specified compression method. > + > + We plan to change the default to 'none' in FreeBSD 15.0. Sorry not to have noticed this in the review; it was only when I saw this= message that it sunk in that we now have *three* ways to specify compress= ion, and I'm not even sure what the precedence is. I would have thought that would replace -c. It's a mess if the config file has entries that specify J and X flags as well as none, the config file has zstd, and the -c option is given as well. We now have a knob to override the knob to override a knob. The only reason to keep -c that I can think of is to specify a different compression in a single invocati= on, but as noted, changing compression requires manual operations that make it unreasonable to change it invocation by invocation. Also, using the -c option or (except with legacy) loses the ability to specify different compression types for different files. People have objected to the term "legacy" as well. I still think it would be much better to add an option letter to select the default compression as specified by . This would eliminate= the need for "legacy", and it would add the ability to have both a global= default and an exception. I think the redefinition of the existing flags= to have different meanings if is given is messy. The entry for -c says that we plan to change the default to "none" in 15.= 0. Hopefully that would be done via and not -c. However, there was significant pushback on "none" being the default. Mike